Jump to content

Custom furnace not updating front icon


BH202548

Recommended Posts

The way that the furnace uses is changing the blockID

Block.furnaceIdle.blockID;

Block.furnaceActive.blockID;

 

Yeah this is the way the basic furnace it does.

 

I help the baconMod creator a little bit out. And there i did found a way how to fix the problem.

 

Here: BlockBaconMaker:

package minecraftwero.baconMod.common.blocks;

import java.util.Random;

import minecraftwero.baconMod.Bacon;
import minecraftwero.baconMod.common.lib.BaconGuiIDs;
import minecraftwero.baconMod.common.tile.BaconMaker;
import net.minecraft.block.BlockContainer;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.EntityLivingBase;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.Icon;
import net.minecraft.util.MathHelper;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.common.ForgeDirection;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BlockBaconMaker extends BlockContainer 
{
private String[] texture;
private Icon[] icons = new Icon[6];
public BlockBaconMaker(int par1, String name, String...textures) 
{
	super(par1, Material.rock);
	texture = textures;
	this.setCreativeTab(Bacon.baconMod);

}

@Override
@SideOnly(Side.CLIENT)
public void registerIcons(IconRegister par1) 
{
	for(int i = 0; i<texture.length;i++)
	{
		icons[i] = par1.registerIcon(texture[i]);
	}
}

@Override
@SideOnly(Side.CLIENT)
public Icon getIcon(int par1, int par2) 
{
	if(par1 == ForgeDirection.NORTH.getOpposite().ordinal())return icons[2];
	else if(par1 == ForgeDirection.WEST.ordinal())return icons[3];
	else if(par1 == ForgeDirection.UP.ordinal())return icons[1];
	else return icons[4];
}

    @SideOnly(Side.CLIENT)
    public void randomDisplayTick(World par1World, int par2, int par3, int par4, Random par5Random)
    {
    	BaconMaker tile = (BaconMaker) par1World.getBlockTileEntity(par2, par3, par4);
    	if(tile != null && tile.fuel > 0)
    	{
            int l = tile.getFacing();
            float f = (float)par2 + 0.5F;
            float f1 = (float)par3 + 0.0F + par5Random.nextFloat() * 6.0F / 16.0F;
            float f2 = (float)par4 + 0.5F;
            float f3 = 0.52F;
            float f4 = par5Random.nextFloat() * 0.6F - 0.3F;

            if (l == 4)
            {
                par1World.spawnParticle("smoke", (double)(f - f3), (double)f1, (double)(f2 + f4), 0.0D, 0.0D, 0.0D);
                par1World.spawnParticle("flame", (double)(f - f3), (double)f1, (double)(f2 + f4), 0.0D, 0.0D, 0.0D);
            }
            else if (l == 5)
            {
                par1World.spawnParticle("smoke", (double)(f + f3), (double)f1, (double)(f2 + f4), 0.0D, 0.0D, 0.0D);
                par1World.spawnParticle("flame", (double)(f + f3), (double)f1, (double)(f2 + f4), 0.0D, 0.0D, 0.0D);
            }
            else if (l == 2)
            {
                par1World.spawnParticle("smoke", (double)(f + f4), (double)f1, (double)(f2 - f3), 0.0D, 0.0D, 0.0D);
                par1World.spawnParticle("flame", (double)(f + f4), (double)f1, (double)(f2 - f3), 0.0D, 0.0D, 0.0D);
            }
            else if (l == 3)
            {
                par1World.spawnParticle("smoke", (double)(f + f4), (double)f1, (double)(f2 + f3), 0.0D, 0.0D, 0.0D);
                par1World.spawnParticle("flame", (double)(f + f4), (double)f1, (double)(f2 + f3), 0.0D, 0.0D, 0.0D);
            }
    	}
    }

@Override
public TileEntity createNewTileEntity(World world) 
{
	return new BaconMaker();
}

@Override
@SideOnly(Side.CLIENT)
public Icon getBlockTexture(IBlockAccess par1IBlockAccess, int par2, int par3, int par4, int par5)
{
	int meta = par1IBlockAccess.getBlockMetadata(par2, par3, par4);
	BaconMaker tile = (BaconMaker) par1IBlockAccess.getBlockTileEntity(par2, par3, par4);
	if(tile != null)
	{
	 	if(tile.facing == par5)
	 	{
	 		if(tile.fuel > 0)
	 		{
	 			return icons[5];
	 		}
	 		else 
	 		{
	 			return icons[2];
	 		}
	 	}
	 	else if(par5 == 0)return icons[0];
	 	else if(par5 == 1)return icons[1];
	 	else if(ForgeDirection.getOrientation(tile.facing).getOpposite().ordinal() == ForgeDirection.SOUTH.ordinal())return icons[3];
	 	else return icons[4];
	}
	else
	{
		return null;
	}
}

@Override
public void breakBlock(World par1, int par2, int par3, int par4, int par5, int par6)
{
	super.breakBlock(par1, par2, par3, par4, par5, par6);
}



//Start
@Override
public int quantityDropped(Random par1Random) 
{
	return 1;
}

@Override
public int idDropped(int par1, Random par2Random, int par3)
{
	return this.blockID;
}

@Override
public int damageDropped(int par1) 
{
	return 0;
}
//End

public boolean onBlockActivated(World par1, int par2, int par3, int par4, EntityPlayer par5, int par6, float par7, float par8, float par9)
{
	if(par5.isSneaking())
	{
		return false;
	}

	if(!par1.isRemote)
	{
		BaconMaker tile = (BaconMaker) par1.getBlockTileEntity(par2, par3, par4);
		if(tile != null)
		{
			par5.openGui(Bacon.instance, BaconGuiIDs.baconMaker, par1, par2, par3, par4);
			return true;
		}
	}
	return true;
}

@Override
public void onBlockPlacedBy(World par1, int par2, int par3, int par4, EntityLivingBase par5, ItemStack par6) 
{

	TileEntity tile = par1.getBlockTileEntity(par2, par3, par4);
	int facing = MathHelper.floor_double(par5.rotationYaw * 4.0F / 360.0F + 0.5D) & 3;
	int rotation = 0;
        if (facing == 0) {
            rotation = ForgeDirection.NORTH.ordinal();
        }
        else if (facing == 1) {
            rotation = ForgeDirection.EAST.ordinal();
        }
        else if (facing == 2) {
            rotation = ForgeDirection.SOUTH.ordinal();
        }
        else if (facing == 3) {
            rotation = ForgeDirection.WEST.ordinal();
        }
        else
        {
        	rotation = ForgeDirection.NORTH.ordinal();
        }
        
        if(tile != null && tile instanceof BaconMaker)
        {
        	BaconMaker bot = (BaconMaker) tile;
        	bot.setFacing(rotation);
        }
}

public void updateTick(World world, int i, int j, int k, Random random)
    {
	super.updateTick(world, i, j, k, random);
	notifyNeighbors(world, i, j, k);
	world.scheduleBlockUpdate(i, j, k, blockID, tickRate());
    }

public void onBlockDestroyedByPlayer(World world, int i, int j, int k, int l)
    {
	notifyNeighbors(world, i, j, k);
    }

public void notifyNeighbors(World world, int i, int j, int k)
{
	world.notifyBlocksOfNeighborChange(i, j, k, blockID);
	world.notifyBlocksOfNeighborChange(i, j - 1, k, blockID);
        world.notifyBlocksOfNeighborChange(i, j + 1, k, blockID);
        world.notifyBlocksOfNeighborChange(i - 1, j, k, blockID);
        world.notifyBlocksOfNeighborChange(i + 1, j, k, blockID);
        world.notifyBlocksOfNeighborChange(i, j, k - 1, blockID);
        world.notifyBlocksOfNeighborChange(i, j, k + 1, blockID);
}


public void onBlockAdded(World world, int i, int j, int k)
    {        
        world.scheduleBlockUpdate(i, j, k, blockID, tickRate());
    }

public int tickRate()
{
	return 1;
}

@Override
public int getLightValue(IBlockAccess world, int x, int y, int z) 
{
	BaconMaker tile = (BaconMaker) world.getBlockTileEntity(x, y, z);
	if(tile != null)
	{
		if(tile.fuel > 0)return 8;
		else return 0;
	}
	else
	{
		return 0;
	}
}

}

 

TileEntityBaconMaker:

package minecraftwero.baconMod.common.tile;

import minecraftwero.baconMod.common.core.handlers.BaconMakerRecipes;
import minecraftwero.baconMod.common.items.ItemBlade;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.inventory.IInventory;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.world.World;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

public class BaconMaker extends TileEntityBacon implements IInventory, ISidedInventory
{

ItemStack[] baconInventory = new ItemStack[4];
public int fuel = 0;
public int progress = 0;
public int workingTime = 0;
public boolean update = false;

@SideOnly(Side.CLIENT)
public int getProgressBar(int i)
{
	return progress * i / 300;
}


@SideOnly(Side.CLIENT)
public int getFuel(int i)
{
	return fuel * i / 1000;
}

    public void updateBlock()
    {
        int var1 = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        this.worldObj.markBlockForRenderUpdate(this.xCoord, this.yCoord, this.zCoord);
        markBlockDirty(this.worldObj, this.xCoord, this.yCoord, this.zCoord);
    }

    public void markBlockDirty(World var0, int var1, int var2, int var3)
    {
        if (var0.blockExists(var1, var2, var3))
        {
            var0.getChunkFromBlockCoords(var1, var3).setChunkModified();
        }
    }
    
    public int getSizeInventory()
    {
        return this.baconInventory.length;
    }
    

    public ItemStack getStackInSlot(int par1)
    {
        return this.baconInventory[par1];
    }


    public ItemStack decrStackSize(int par1, int par2)
    {
        if (this.baconInventory[par1] != null)
        {
            ItemStack itemstack;

            if (this.baconInventory[par1].stackSize <= par2)
            {
                itemstack = this.baconInventory[par1];
                this.baconInventory[par1] = null;
                return itemstack;
            }
            else
            {
                itemstack = this.baconInventory[par1].splitStack(par2);

                if (this.baconInventory[par1].stackSize == 0)
                {
                    this.baconInventory[par1] = null;
                }

                return itemstack;
            }
        }
        else
        {
            return null;
        }
    }


    public ItemStack getStackInSlotOnClosing(int par1)
    {
        if (this.baconInventory[par1] != null)
        {
            ItemStack itemstack = this.baconInventory[par1];
            this.baconInventory[par1] = null;
            return itemstack;
        }
        else
        {
            return null;
        }
    }


    public void setInventorySlotContents(int par1, ItemStack par2ItemStack)
    {
        this.baconInventory[par1] = par2ItemStack;

        if (par2ItemStack != null && par2ItemStack.stackSize > this.getInventoryStackLimit())
        {
            par2ItemStack.stackSize = this.getInventoryStackLimit();
        }
    }


    public String getInvName()
    {
        return null;
    }



    public void readFromNBT(NBTTagCompound par1NBTTagCompound)
    {
        super.readFromNBT(par1NBTTagCompound);
        NBTTagList nbttaglist = par1NBTTagCompound.getTagList("Items");
        fuel = par1NBTTagCompound.getInteger("fuels");
        progress = par1NBTTagCompound.getInteger("progresss");
        workingTime = par1NBTTagCompound.getInteger("workingTimes");
        this.baconInventory = new ItemStack[this.getSizeInventory()];

        for (int i = 0; i < nbttaglist.tagCount(); ++i)
        {
            NBTTagCompound nbttagcompound1 = (NBTTagCompound)nbttaglist.tagAt(i);
            byte b0 = nbttagcompound1.getByte("Slot");

            if (b0 >= 0 && b0 < this.baconInventory.length)
            {
                this.baconInventory[b0] = ItemStack.loadItemStackFromNBT(nbttagcompound1);
            }
        }
    }


    public void writeToNBT(NBTTagCompound par1NBTTagCompound)
    {
        super.writeToNBT(par1NBTTagCompound);
        par1NBTTagCompound.setInteger("fuels", fuel);
        par1NBTTagCompound.setInteger("progresss", progress);
        par1NBTTagCompound.setInteger("workingTimes", workingTime);
        NBTTagList nbttaglist = new NBTTagList();

        for (int i = 0; i < this.baconInventory.length; ++i)
        {
            if (this.baconInventory[i] != null)
            {
                NBTTagCompound nbttagcompound1 = new NBTTagCompound();
                nbttagcompound1.setByte("Slot", (byte)i);
                this.baconInventory[i].writeToNBT(nbttagcompound1);
                nbttaglist.appendTag(nbttagcompound1);
            }
        }

        par1NBTTagCompound.setTag("Items", nbttaglist);

    }

    public int getInventoryStackLimit()
    {
        return 64;
    }


@Override
public boolean isUseableByPlayer(EntityPlayer entityplayer) 
{
	return true;
}

@Override
public void openChest() {		
}

@Override
public void closeChest() 
{		
}


@Override
public boolean isInvNameLocalized() {
	return false;
}

@Override
public void updateEntity() 
{


	super.updateEntity();


	if(fuel < 10 && canCook() && baconInventory[2] != null && baconInventory[2].getItem() instanceof ItemBlade)
	{
		addFuel();
		update = true;
	}
	cook();
	damage();
	if(fuel > 0)
	{
		fuel--;
	}

	if(update)
	{
		update = false;
		this.onInventoryChanged();
		updateBlock();
		updateLight();
	}

}

    void updateLight()
    {
        this.worldObj.updateAllLightTypes(this.xCoord, this.yCoord, this.zCoord);
    }


public void damage()
{
	if(workingTime >= 600 && baconInventory[2] != null && baconInventory[2].getItem() instanceof ItemBlade)
	{
		workingTime = 0;
		ItemBlade ib = (ItemBlade) baconInventory[2].getItem();
		ib.damageBlade(baconInventory[2]);
		if(baconInventory[2].getItemDamage() >= baconInventory[2].getMaxDamage())
		{
			baconInventory[2] = null;
		}

	}
}

public void cook()
{
	if(fuel > 0)
	{
		if(canCook())
		{
			if(baconInventory[2] != null && baconInventory[2].getItem() instanceof ItemBlade)
			{
				ItemBlade ib = (ItemBlade) baconInventory[2].getItem();
				progress++;
				workingTime++;
				if(progress >= 300)
				{
					progress = 0;
					ItemStack output = BaconMakerRecipes.getRecipes().getRecipeOuput(baconInventory[1]);
		            if (this.baconInventory[3] == null)
		            {
		                this.baconInventory[3] = output.copy();
		                update = true;
		            }
		            else if (this.baconInventory[3].isItemEqual(output))
		            {
		                baconInventory[3].stackSize += output.stackSize;
		                update = true;
		            }

		            --this.baconInventory[1].stackSize;

		            if (this.baconInventory[1].stackSize <= 0)
		            {
		                this.baconInventory[1] = null;
		                update = true;
		            }
				}
			}
		}
		else
		{
			progress = 0;
		}
	}
}

public boolean canCook()
{
        if (this.baconInventory[1] == null)
        {
            return false;
        }
        else
        {
            ItemStack itemstack = BaconMakerRecipes.getRecipes().getRecipeOuput(baconInventory[1]);
            if (itemstack == null) return false;
            if (this.baconInventory[3] == null) return true;
            if (!this.baconInventory[3].isItemEqual(itemstack)) return false;
            int result = baconInventory[3].stackSize + itemstack.stackSize;
            return (result <= getInventoryStackLimit() && result <= itemstack.getMaxStackSize());
        }
}

public void addFuel()
{
	if(hasFuel(baconInventory[0]))
	{
		int fuelbetween = this.getFuel(baconInventory[0]);
		if(fuelbetween > 0)
		{
			fuel += fuelbetween;
			baconInventory[0].stackSize--;
			update = true;
			if(baconInventory[0].stackSize <= 0)
			{
				baconInventory[0] = baconInventory[0].getItem().getContainerItemStack(baconInventory[0]);
				update = true;
			}
		}


	}
}

public boolean hasFuel(ItemStack par1)
{
	return getFuel(par1) > 0;
}

public int getFuel(ItemStack par1)
{
	if(par1 != null)
	{
		int itemid = par1.getItem().itemID;
		if(itemid == Item.coal.itemID)
		{
			return 1600;
		}
	}

	return 0;
}



    /**
     * Returns an array containing the indices of the slots that can be accessed by automation on the given side of this
     * block.
     */
    public int[] getAccessibleSlotsFromSide(int par1)
    {
    	if(par1 == 0)
    	{
    		return new int[]{0};
    	}
    	else if(par1 == 1)
    	{
    		return new int[]{1};
    	}
    	else
    	{
    		return new int[]{3};
    	}
    }

    /**
     * Returns true if automation can insert the given item in the given slot from the given side. Args: Slot, item,
     * side
     */
    public boolean canInsertItem(int par1, ItemStack par2ItemStack, int par3)
    {
        return this.isItemValidForSlot(par1, par2ItemStack);
    }

    /**
     * Returns true if automation can extract the given item in the given slot from the given side. Args: Slot, item,
     * side
     */
    public boolean canExtractItem(int par1, ItemStack par2ItemStack, int par3)
    {
        return par3 != 1 || par1 != 2 || par2ItemStack.itemID == Item.bucketEmpty.itemID;
    }


@Override
public boolean isItemValidForSlot(int i, ItemStack itemstack) 
{
        if(i == 0)return this.hasFuel(itemstack);
        else if(i == 3)return false;
        else if(i == 1)return true;
        else return false;
}


}

 

The updateBlock function updates the function.

The updateLight function updates the light^^.

i hope it helps^^

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
    • When I came across the 'Exit Code: I got a 1 error in my Minecraft mods, so I decided to figure out what was wrong. First, I took a look at the logs. In the mods folder (usually where you'd find logs or crash reports), I found the latest.log file or the corresponding crash report. I read it through carefully, looking for any lines with errors or warnings. Then I checked the Minecraft Forge support site, where you can often find info on what causes errors and how to fix them. I then disabled half of my mods and tried running the game. If the error disappeared, it meant that the problem was with the disabled mod. I repeated this several times to find the problem mod.
    • I have no idea - switch to a pre-configured modpack and use it as working base    
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.