Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Recipe not working with custom crafter

Crescentine

By Crescentine
in Modder Support

 Share

Recommended Posts

Crescentine Tree Puncher

Crescentine

Posted
Posted

I don't really know how to explain this issue, other than that despite it being registered, no code errors and all that, when I place my items for my test recipe in the slots, it doesn't craft. This is using a custom crafting recipe type, and is the first time I've ever gotten this far with this attempt. (5th one in the past 3-5 months).

This is my github. I can share the individual files via pastebin if requested.

Thanks for any help given. 

https://github.com/Crescentine/Trajans-Tanks-1.18/tree/main/src/main/java/com/crescentine/trajanstanks

Link to comment
Share on other sites
Crescentine Tree Puncher

Crescentine

Posted
  • Author
Posted

Hi there, 

This is a update of my earlier post which was missing information and was requiring potential helpers to look at my entire repo to find the classes in question; I decided to add more information and text here in order to explain what I am trying to do and what is happening.

So I am trying to implement a custom crafter machine for the things in my mod to be made with. There is no errors in my IDE and it compiles fine, yet the issue comes that when the items are all in the slot, it doesn't work. I don't know WHY it doesn't work , as its registered and should work; I've looked at other githubs to try to compare and contrast, yet I don't notice any big difference in the three or so I've looked at.

I do hope someone can help me with this! Thank you for all possible help.

This is the Recipe Class (TankCrafterRecipe)

https://pastebin.com/3tZR2SSB

Recipe Register (ModRecipes)

https://pastebin.com/wbvucnRU

Container for the Crafter (CratferContainer)

https://pastebin.com/xqJDFVW2

Crafter Block Entity / Tile Entity

https://pastebin.com/Av5VBW4W

Crafter Block

https://pastebin.com/tXQ6JB76

Test Recipe (json) (in resources/data/trajanstanks/recipes)

https://pastebin.com/B5jGzSSv

 

Lastly, here is my github for the mod in case any other questions or classes.

https://github.com/Crescentine/Trajans-Tanks-1.18/tree/main/src/main/java/com/crescentine/trajanstanks

 

Link to comment
Share on other sites
Crescentine Tree Puncher

Crescentine

Posted
  • Author
Posted
8 hours ago, diesieben07 said:
  • Why is this static? Please learn the basics of Java.
  • Your BlockEntity has two inventories. Firstly it inherits from InventoryBlockEntity which has the inventory field. Then it also has its own itemHandler field.
  • Here you could use RecipeWrapper instead of copying the inventory every time.

I resolved the two inventories thing and removed the itemHandler field; It now only inherits from the parent class, and I did the other thing. 

Yet it still doesn't work. At this point what else can I do? 

Thanks for the help by the way :)

Link to comment
Share on other sites
Crescentine Tree Puncher

Crescentine

Posted
  • Author
Posted (edited)

Wait so the issue is that it doesn't extract slots 0- 7 and only extracts 0-6 and inserts into 8 leaving one unaccounted for? Did I read that correctly?

So like, I can solve it by adding

"entity.extractItem(7);"

to the CrafterBlockEntity?

Or is there more to this??

Edited by Crescentine
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • brickyboy
      Reloading a single texture/resource (forge 1.20.1)

      By brickyboy · Posted

      A friend found this code, but I don't know where. It seems to be very outdated, maybe from 1.12? and so uses TextureManager$loadTexture and TextureManager$deleteTexture which both don't seem to exist anymore. It also uses Minecraft.getMinecraft().mcDataDir.getCanonicalPath() which I replaced with the resource location of my texture .getPath()? Not sure if thats entirely correct. String textureName = "entitytest.png"; File textureFile = null; try { textureFile = new File(Minecraft.getMinecraft().mcDataDir.getCanonicalPath(), textureName); } catch (Exception ex) { } if (textureFile != null && textureFile.exists()) { ResourceLocation MODEL_TEXTURE = Resources.OTHER_TESTMODEL_CUSTOM; TextureManager texturemanager = Minecraft.getMinecraft().getTextureManager(); texturemanager.deleteTexture(MODEL_TEXTURE); Object object = new ThreadDownloadImageData(textureFile, null, MODEL_TEXTURE, new ImageBufferDownload()); texturemanager.loadTexture(MODEL_TEXTURE, (ITextureObject)object); return true; } else { return false; }   Then I've been trying to go through the source code of the reload resource packs from minecraft, to see if I can "cache" some data and simply reload some textures and swap them out, but I can't seem to figure out where exactly its "loading" the texture files and such. Minecraft$reloadResourcePacks(bool) seems to be mainly controlling the loading screen, and using this.resourcePackRepository.reload(); which is PackRepository$reload(), but that function seems to be using this absolute confusion of a line List<String> list = this.selected.stream().map(Pack::getId).collect(ImmutableList.toImmutableList()); and then this.discoverAvailable() and this.rebuildSelected. The rebuild selected seemed promising, but it seems to just be going through each pack and doing this to them? pack.getDefaultPosition().insert(list, pack, Functions.identity(), false); e.g. putting them into a list of packs and returning that into this.selected? Where do the textures actually get baked/loaded/whatever? Any info on how Minecraft reloads resource packs or how the texture manager works would be appreciated!
    • Palomar
      [Forge 1.17.1 v33] Error after successful install and running the run.bat

      By Palomar · Posted

      Did you end up finding a solution to this?
    • Palomar
      Forge server file raises an error

      By Palomar · Posted

      This might be a long shot , but do you remember how you fixed that?
    • TheMegaNerd
      LegacySourceAccess sporadic crash

      By TheMegaNerd · Posted

      Yeah, I'll start with the ones I added last night.  Wasn't crashing until today and wasn't crashing at all yesterday (+past few days since removing Cupboard), so deductive reasoning says it's likeliest to be one of the new ones.  A few horse armor mods and a corn-based add-on to Farmer's Delight, the latter which I hope to keep - I could do without the horse armor mods if necessary.  Let me try a few things and we'll see. 
    • TileEntity
      When I join my MinecraftWorld it says "Invalid Player Data"

      By TileEntity · Posted

      Add crash-reports with sites like https://mclo.gs/ Add this mod: https://www.curseforge.com/minecraft/mc-mods/packet-fixer/files/5416165

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept