Jump to content

Recommended Posts

Posted (edited)

Hello,

I am trying to render an icon on the screen. I've read https://forums.minecraftforge.net/topic/107635-1165-mcp-render-overlay-errorbackground-black/ and thought this should be easily appliable to my code, but I only get a black square. Furthermore, I've read https://www.minecraftforum.net/forums/mapping-and-modding-java-edition/minecraft-mods/modification-development/1437340-drawing-texture-with-drawtexturedmodalrect-is-too where they say the icon has to be 256x256, so I increased the size of the icon from 16x16 to 256x256.

My code is:

private static final ResourceLocation SS_ICON = new ResourceLocation("sereneseasons", "sereneseasons/textures/item/ss_icon.png");

@SubscribeEvent
public void onRenderGameOverlayEventPost(RenderGameOverlayEvent.Post event) {
    if (event.getType() == RenderGameOverlayEvent.ElementType.ALL) {
        TextureManager textureManager = Minecraft.getInstance().getTextureManager();
        textureManager.bind(SS_ICON);
        GuiUtils.drawTexturedModalRect(event.getMatrixStack(), 50, 50, 0, 0, 8, 8, 0);
    }
}

This is the icon gXFgH89.png This icon is from another mod, sereneseasons and it is inside its assets/sereneseasons/textures/item folder.

What am I missing here? And can someone explain the 4. and 5. parameter that are 0 in my code above?

 

Edited by Ctwx
Posted (edited)
34 minutes ago, diesieben07 said:

You should use AbstractGui.blit instead of drawTexturedModalRect. I recommend Parchment so that you get proper parameter names.

Thank you. I'll check Parchment out.

What does blit do? Without Parchment I see a bunch of different Parameters but all of them just use int and float. Perhaps that will be more clear when I use Parchment.

Edited by Ctwx
Posted (edited)

Okay, Parchment works, and blit also. But still, it is black on the screen:

private static final ResourceLocation SS_ICON = new ResourceLocation("sereneseasons", "sereneseasons/textures/item/ss_icon.png");

@SubscribeEvent
public void onRenderGameOverlayEventPost(RenderGameOverlayEvent.Post pEvent) {
    if (pEvent.getType() == RenderGameOverlayEvent.ElementType.ALL) {
        Minecraft.getInstance().getTextureManager().bind(SS_ICON);
        AbstractGui.blit(pEvent.getMatrixStack(), 50, 50, 0f, 0f, 8, 8, 16, 16);
    }
}

The icon is black in game (when I make it bigger, it is this black/magenta squared texture):

qym7zsQ.png

I also tried it with a different ResourceLocation which works fine: new ResourceLocation("textures/gui/book.png");

I am not sure why it is not able to locate the resource. I also tried to copy it in my src/resources/assets folder, but that does not seem to work either. Do I have to register the resources first?

Edited by Ctwx
Posted (edited)
36 minutes ago, diesieben07 said:

From that screenshot I can tell you have not correctly added Parchment. Did you reimport the project after adding it?

My bad. I checked the additional FAQ, prefixing my parameters with "p" fixed Parchment, but not the icon issue in my answer above. :) Thanks

Edited by Ctwx
Posted

Okay, I fixed it. Thank you very much for the recommendations for Parchment and blit.

The issue that I still had was this:

// I had this:
new ResourceLocation("sereneseasons", "sereneseasons/textures/item/ss_icon.png");
// but I needed this:
new ResourceLocation("sereneseasons", "textures/item/ss_icon.png");

I checked the sereneseasons.jar and the textures where in assets/sereneseasons, so I thought I needed the extra folder name above. Now it works.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Forge only supports Java Edition, you'll need to ask elsewhere for Pocket Edition support. Also, don't post in unrelated topics. I've split your post into its own topic.
    • How do I download mods for minecraft pe
    • I've tried multiple ways to get the chunk coordinates and none of them have worked, so I'm guessing it may be getChunk().  Is there another way to forcibly load a chunk on that same tick? If all else fails I guess I can just delay my action by a tick, but that's a pain in the butt and makes it more complex to provide appropriate feedback... Also welcome, Zander.  If you're searching for a similar solution, I hope this (eventually) helps you too 😅
    • My guess would be that you are not getting the chunk coordinates right, or getChunk dosnt work.
    • Hello, Recently I have been hosting an RLcraft server on Minecraft Forge Version 1.12.2 - 14.23.5.2860 I originally had lag issues and I chalked it up to playing on less than perfect hardware so I moved the server to better hardware(i9-9900k with 64GB of RAM for 1 player.) After lots of troubleshooting I discovered a couple of things. World saving was causing the MSPT to spike to over 2000Miliseconds and was happening every minute. This kind of makes sense as the world was pre-generated and is over 100GB. I learned that I could turn off world saving and just schedule that and that resolved that issue. After that issue was resolved I discovered another issue. It appears that when exploring chunks, any chunks explored stay loaded. They persist. I was originally thinking that this had to be a mod issue, but it didn't seem like anyone was talking about it. This isn't really a problem on packs with few worldgen mods or just few mods in general, but on beefier packs it becomes a problem. I went through forge changelogs and found this line. Build: 1.12.2-14.23.5.2841 - Thu Aug 29 01:58:50 GMT 2019 bs2609: Improve performance of persistent chunk checks (#5706) Is this a related item to what I am dealing with or just something else?   I went ahead and created a new dedicated server with Just Forge 14.23.5.2860, spark reforged, and it's core mods. I was able to replicate the issue and log it with spark. Hopefully you're able to see this spark profile. It basically shows that as I explored the chunk loading persisted(2000 chunks loaded over 10 minutes with one player)The view distance is set to 10 so that should be 200 chunks per player. If I don't move the loaded chunks are 200. I was however able to fix the persistent chunk issue if I save the world more frequently. My question is, is this intended function of the game or is this a bug? Everywhere I read seems to indicate Minecraft servers save every 5 minutes and not every minute. Can chunks not unload if the world does not autosave. Additionally. Autosave specifically appears to fix this issue. Manually running save-all does not resolve the issue.   I realize this is kind of a log one, sorry. Please let me know if you require further information. Thanks in advance for your time. https://spark.lucko.me/NvlMtC39Yt https://imgur.com/a/K0oyukx https://pastebin.com/z0qGu1Vh  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.