Jump to content

More efficient way of assigning values to items, rather than tons of if branches?


Recommended Posts

Posted (edited)

Hiya. I have quite a Java-y question for you today that I'm hoping I can recieve some help with although I still feel it is related enough to Minecraft Forge to warrant posting here. I do apologise for the unclear title.

I'm somewhat experienced in Java; no expert, but I have a lot of time with it under my belt. I know a lot about it but still also have a lot to learn.

Essentially, I'm writing a new gameplay mechanic/system, and as part of this I pass an ItemStack to a custom function. I then need to  return different values, based on what ItemStack it is.

The immediate thought on how to do this is with multiple if branches. However, I worry this may have a performance impact. Since the function may well be called every single tick, or at least several times a second, I don't want to force the program to run through 100 if branches each tick, which I imagine would cause slowdown.

An example of what I would do is below. This is pseudocode, so ignore any errors. It's just to give an idea of the concept of what the code should do.

if (itemType == Items.LEATHER_HELMET) {
	defense += 4
    agility += 4
}
if (itemType == Items.IRON_HELMET) {
	defense += 7
}
if (itemType == Items.GOLD_HELMET) {
	defense += 3
    wisdom += 6
}

Unlike the above example however, I would likely have this iterating over anywhere from 50-200 items.
Is there a more efficient mechanism within Java (or Minecraft Forge) that would achieve the same result, without requiring so many iterations over if statements?

Edited by SpectralGerbil
Edits for clarity

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Looks like some kind of bug with vampiricageing - or a conflict with unusualprehistory
    • Add crash-reports with sites like https://mclo.gs/ Add this mod: https://www.curseforge.com/minecraft/mc-mods/night-config-fixes  
    • Updating to 1.21.8 from 1.21.5 and the recipe book type now throws an error. The exception has written "This is not implemented yet, poke Forge if you actually use this". From net.minecraft.stats.RecipeBookSettings // FORGE -- called automatically on Enum creation - used for serialization     public static void register(RecipeBookType type) {         String name = type.name().toLowerCase(java.util.Locale.ROOT).replace("_","");         var codec = TypeSettings.codec("is" + name + "GuiOpen", "is" + name + "FilteringCraftable");         //TAG_FIELDS.put(type, Pair.of(openTag, filteringTag));         throw new IllegalStateException("This is not implemented yet, poke Forge if you actually use this");     }
    • I am playing a mod (1.16.5) that is heavily modded. I played it for a few hours completely fine but now that I am trying to load in again 6 hours later I crash. I  have 32 gigs of dedicated ram to this mod, and Ive gone into my world save, serverconfigs, and deleted usefulbackpacks-server.toml                 What do I do from here   This is my full crash log from Curseforge at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:61) ~[?:?] at net.minecraftforge.fml.config.ConfigFileTypeHandler$$Lambda$14819/1243247982.apply(Unknown Source) ~[?:?] at net.minecraftforge.fml.config.ConfigTracker.openConfig(ConfigTracker.java:104) ~[?:?] at net.minecraftforge.fml.config.ConfigTracker.lambda$loadConfigs$1(ConfigTracker.java:83) ~[?:?] at net.minecraftforge.fml.config.ConfigTracker$$Lambda$14818/841663910.accept(Unknown Source) ~[?:?] at java.lang.Iterable.forEach(Iterable.java:75) ~[?:1.8.0_51] at java.util.Collections$SynchronizedCollection.forEach(Collections.java:2062) ~[?:1.8.0_51] at net.minecraftforge.fml.config.ConfigTracker.loadConfigs(ConfigTracker.java:83) ~[?:?] at net.minecraftforge.fml.server.ServerLifecycleHooks.handleServerAboutToStart(ServerLifecycleHooks.java:94) ~[?:?] at net.minecraft.server.integrated.IntegratedServer.func_71197_b(IntegratedServer.java:59) ~[?:?] at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:621) [?:?] at net.minecraft.server.MinecraftServer.func_240783_a_(MinecraftServer.java:232) [?:?] at net.minecraft.server.MinecraftServer$$Lambda$21132/2071546526.run(Unknown Source) [?:?] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51] Caused by: com.electronwill.nightconfig.core.io.ParsingException: Not enough data available at com.electronwill.nightconfig.core.io.ParsingException.notEnoughData(ParsingException.java:22) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.io.ReaderInput.directReadChar(ReaderInput.java:36) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.io.AbstractInput.readChar(AbstractInput.java:49) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.io.AbstractInput.readCharsUntil(AbstractInput.java:123) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.toml.TableParser.parseKey(TableParser.java:166) ~[toml-3.6.3.jar:?] at com.electronwill.nightconfig.toml.TableParser.parseDottedKey(TableParser.java:145) ~[toml-3.6.3.jar:?] at com.electronwill.nightconfig.toml.TableParser.parseNormal(TableParser.java:55) ~[toml-3.6.3.jar:?] at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:44) ~[toml-3.6.3.jar:?] at com.electronwill.nightconfig.toml.TomlParser.parse(TomlParser.java:37) ~[toml-3.6.3.jar:?] at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:113) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:219) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.io.ConfigParser.parse(ConfigParser.java:202) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.file.WriteSyncFileConfig.load(WriteSyncFileConfig.java:73) ~[core-3.6.3.jar:?] at com.electronwill.nightconfig.core.file.AutosaveCommentedFileConfig.load(AutosaveCommentedFileConfig.java:85) ~[core-3.6.3.jar:?] at net.minecraftforge.fml.config.ConfigFileTypeHandler.lambda$reader$1(ConfigFileTypeHandler.java:57) ~[?:?] ... 13 more [23:26:44] [Server thread/FATAL]:Preparing crash report with UUID a1e4c58d-8019-4653-affd-236e2af63d55
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.