Jump to content

Recommended Posts

Posted

In a client side mod I am porting, the enchantment glint of enchanted books is changed based on their enchantment type. 

This was done originally in the 1.16.3 version by caching the item currently being rendered (uses a mixin for the "render" method in ItemRenderer) and then changing the glint with a mixin for the "getEntityGlintVertexBuilder" method (same class).

My current code is as follows:

		@Inject(method = "render("
			+ "Lnet/minecraft/world/item/ItemStack;"
			+ "Lnet/minecraft/client/renderer/block/model/ItemTransforms$TransformType;"
			+ "Z" // Boolean
			+ "Lcom/mojang/blaze3d/vertex/PoseStack;"
			+ "Lnet/minecraft/client/renderer/IRenderTypeBuffer;"
			+ "I" // Integer
			+ "I" // Integer
			+ "Lnet/minecraft/client/resources/model/BakedModel;"
			+ ")V", // Returns void
			at = @At("HEAD"))
	private void render(ItemStack itemStackIn, TransformType transformTypeIn, boolean leftHand, PoseStack matrixStackIn, MultiBufferSource bufferIn, int combinedLightIn, int combinedOverlayIn, BakedModel modelIn, CallbackInfo ci) {

		Hooks.stack = itemStackIn;

	}

		@Inject(method = "getFoilBuffer("
			+ "Lnet/minecraft/client/renderer/MultiBufferSource;"
			+ "Lnet/minecraft/client/renderer/RenderType;"
			+ "Z" // Boolean
			+ "Z" // Boolean
			+ ")Lcom/mojang/blaze3d/vertex/VertexConsumer;",
			at = @At("HEAD"),
			cancellable = true)
	private static void getFoilBuffer(MultiBufferSource bufferSource, RenderType renderTypeIn, boolean isItem, boolean glint, CallbackInfoReturnable<VertexConsumer> cir) {

		if (glint && EnchantedBookRedesign.cache.contains(Hooks.stack.getItem())) {

			VertexConsumer newBuilder = VertexMultiConsumer.create(TintedVertexConsumer.withTint(bufferSource.getBuffer(isItem ? ModRenderType.TINTED_GLINT_DIRECT : ModRenderType.TINTED_ENTITY_GLINT_DIRECT), Hooks.getColor(Hooks.stack)), bufferSource.getBuffer(renderTypeIn));

			cir.setReturnValue(newBuilder);

		}

	}

Based on my understanding after reading through the JavaDocs and looking through some source code, I am unable to figure out what the method "VertexBuilderUtils.newDelegate" from Forge 1.16.3 equivalents to  in 1.18.2. Signature for the "VertexMultiConsumer.create" method is rather similar to the old "VertexBuilderUtils.newDelegate" signature, and is what I tried in the code snippet I posted earlier, but it doesn't seem to work.

If I am doing this completely wrong please let me know, otherwise, what am I doing wrong, and what new method equates to the old "VertexBuilderUtils.newDelegate" method?

Thanks!

- Rey

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Thanks, I've now installed a slightly newer version and the server is at least starting up now.
    • i have the same issue. Found 1 Create mod class dependency(ies) in createdeco-1.3.3-1.19.2.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Found 11 Create mod class dependency(ies) in createaddition-fabric+1.19.2-20230723a.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Detailed walkthrough of mods which rely on missing Create mod classes: Mod: createaddition-fabric+1.19.2-20230723a.jar Missing classes of create: com/simibubi/create/compat/jei/category/sequencedAssembly/JeiSequencedAssemblySubCategory com/simibubi/create/compat/recipeViewerCommon/SequencedAssemblySubCategoryType com/simibubi/create/compat/rei/CreateREI com/simibubi/create/compat/rei/EmptyBackground com/simibubi/create/compat/rei/ItemIcon com/simibubi/create/compat/rei/category/CreateRecipeCategory com/simibubi/create/compat/rei/category/WidgetUtil com/simibubi/create/compat/rei/category/animations/AnimatedBlazeBurner com/simibubi/create/compat/rei/category/animations/AnimatedKinetics com/simibubi/create/compat/rei/category/sequencedAssembly/ReiSequencedAssemblySubCategory com/simibubi/create/compat/rei/display/CreateDisplay Mod: createdeco-1.3.3-1.19.2.jar Missing classes of create: com/simibubi/create/content/kinetics/fan/SplashingRecipe
    • The crash points to moonlight lib - try other builds or make a test without this mod and the mods requiring it
    • Do you have shaders enabled? There is an issue with the mod simpleclouds - remove this mod or disable shaders, if enabled  
    • Maybe you need to create file in assets/<modid>/items/<itemname>.json with content like this:   { "model": { "type": "minecraft:model", "model": "modname:item/itemname" } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.