Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Game crashes when using item

Kuikenpower

By Kuikenpower
in Modder Support

 Share

Recommended Posts

Kuikenpower Tree Puncher

Kuikenpower

Posted
Posted

Hi, I want to make an item that will heal entities in an area around the player(it doesn't matter if the player will also heal himself) but when I right-click the game will crash. Here's my code: 

package com.kuikenpower.falidsmp.init.item;

import java.util.List;

import net.minecraft.core.particles.ParticleTypes;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.effect.MobEffectInstance;
import net.minecraft.world.effect.MobEffects;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.ai.memory.NearestVisibleLivingEntities;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.SwordItem;
import net.minecraft.world.item.Tier;
import net.minecraft.world.level.Level;
import net.minecraft.world.phys.AABB;

public class flowerStaff extends SwordItem{

	public flowerStaff(Tier p_43269_, int p_43270_, float p_43271_, Properties p_43272_) {
		super(p_43269_, p_43270_, p_43271_, p_43272_);
		// TODO Auto-generated constructor stub
	}
	
	@Override
	public void inventoryTick(ItemStack itemStack, Level world, Entity entity, int p_41407_, boolean p_41408_) {
		Player player = (Player) entity;
		if(player.isCrouching() && player.getMainHandItem().getItem() instanceof flowerStaff) {
            Double x = player.getX();
            Double y = player.getY();
            Double z = player.getZ();
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 2.5, 5, 5, 5);
		}
		super.inventoryTick(itemStack, world, entity, p_41407_, p_41408_);
	}
	
	@Override
	public InteractionResultHolder<ItemStack> use(Level world, Player player, InteractionHand p_41434_) {
		if(world.isClientSide) {
			AABB healArea = new AABB(player.getX() + 5, player.getY() + 2, player.getZ() + 5, player.getX() - 5, player.getY() - 2, player.getZ() - 5);
			if(player.isCrouching()) {
				List<LivingEntity> entityInArea = world.getNearbyEntities(null, null, player, healArea);
				LivingEntity targets = entityInArea.get(EAT_DURATION);
				targets.addEffect(new MobEffectInstance(MobEffects.HEAL, 20));
			}
		}
		return super.use(world, player, p_41434_);
	}
	
}

 

Kuikenpower Tree Puncher

Kuikenpower

Posted
  • Author
Posted
16 minutes ago, diesieben07 said:

null and null are not valid parameters here.

Hi, Thanks for reacting faster than the flash, but what should I use instead of null and null?

Kuikenpower Tree Puncher

Kuikenpower

Posted
  • Author
Posted
19 hours ago, diesieben07 said:

What if it's not a player?

null and null are not valid parameters here.

Uh, what? Why are you getting the entity at index EAT_DURATION? This makes zero sense. EAT_DURATION is 32, so what if there are only 15 entities nearby? Or none at all? Even if there are 33 or more entities nearby, this achieves nothing useful.

I did everything you said, but it still crashes 

package com.kuikenpower.falidsmp.init.item;

import java.util.List;

import net.minecraft.core.particles.ParticleTypes;
import net.minecraft.world.InteractionHand;
import net.minecraft.world.InteractionResultHolder;
import net.minecraft.world.effect.MobEffectInstance;
import net.minecraft.world.effect.MobEffects;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.LivingEntity;
import net.minecraft.world.entity.ai.targeting.TargetingConditions;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.item.ItemStack;
import net.minecraft.world.item.SwordItem;
import net.minecraft.world.item.Tier;
import net.minecraft.world.level.Level;
import net.minecraft.world.phys.AABB;

public class flowerStaff extends SwordItem{

	public flowerStaff(Tier p_43269_, int p_43270_, float p_43271_, Properties p_43272_) {
		super(p_43269_, p_43270_, p_43271_, p_43272_);
		// TODO Auto-generated constructor stub
	}
	
	@Override
	public void inventoryTick(ItemStack itemStack, Level world, Entity entity, int p_41407_, boolean p_41408_) {
		LivingEntity player = (LivingEntity) entity;
		if(player.isCrouching() && player.getMainHandItem().getItem() instanceof flowerStaff) {
            Double x = player.getX();
            Double y = player.getY();
            Double z = player.getZ();
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z + 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 2.5, y, z - 5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z + 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x + 5, y, z - 2.5, 5, 5, 5);
            world.addParticle(ParticleTypes.HAPPY_VILLAGER, x - 5, y, z - 2.5, 5, 5, 5);
		}
		super.inventoryTick(itemStack, world, entity, p_41407_, p_41408_);
	}
	
	@Override
	public InteractionResultHolder<ItemStack> use(Level world, Player player, InteractionHand p_41434_) {
		if(world.isClientSide) {
			AABB healArea = new AABB(player.getX() + 5, player.getY() + 2, player.getZ() + 5, player.getX() - 5, player.getY() - 2, player.getZ() - 5);
			if(player.isCrouching()) {
				List<LivingEntity> entityInArea = world.getNearbyEntities(LivingEntity.class, TargetingConditions.forNonCombat(), player, healArea);
				LivingEntity targets = entityInArea.get(5);
				targets.addEffect(new MobEffectInstance(MobEffects.HEAL, 20));
			}
		}
		return super.use(world, player, p_41434_);
	}
	
}

 

MFMods Diamond Finder

MFMods

Posted
Posted

invert isClientSide check. you are supposed to heal server entities.

get(5) on a list object returns sixth entity, you intended that for testing, right? and you ensured that there will be five or more entities around you when testing, because otherwise it would crash.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • MarrØw
      Modded Minecaft crashes on initialization

      By MarrØw · Posted

      https://mclo.gs/e8nuqSA My friend and I are having the same issue with this pack. We're trying to play on BMC4 with a bunch of extra mods. The game loads up to 'mod gathering' and then crashes. Mod list changes beyond the modpack: Added mods: alexscaves-2.0.2.jar alexsmobsinteraction-5.4-all.jar Apotheosis-1.20.1-7.4.8.jar ApothicAttributes-1.20.1-1.3.7.jar ApothicCombat-1.20.1-1.1.0.jar ApothicCurios-1.20.1-1.0.3e.jar ArmorPoser-forge-1.20.1-2.2.2.jar ars_nouveau-1.20.1-4.12.7-all.jar attributizer-2.1.jar bendy-lib-forge-4.0.0.jar betterarcheology-1.2.1-1.20.1.jar bettercombat-forge-1.8.6+1.20.1.jar BetterThirdPerson-Forge-1.20-1.9.0.jar born_in_chaos_[Forge]1.20.1_1.7.jar cataclysm_ut_lite-AT - 1.20.1.jar celestisynth-1.20.1-1.3.1.jar cobweb-forge-1.20.1-1.0.1.jar common-networking-forge-1.0.5-1.20.1.jar Critters n' Crawlers-2.2.2-mc1.20.1.jar crittersandcompanions-forge-2.2.2.jar domesticationinnovation-1.7.1-1.20.1.jar dummmmmmy-1.20-2.0.6.jar emotecraft-for-MC1.20.1-2.2.7-b.build.50-forge.jar EmoteTweaks-4.0.2.27-forge.jar exposure-1.20.1-1.7.14-forge.jar faunify-forge-1.20.1-1.1.2.jar hallucinatory_plants-2.3.0-1.20.1-forge.jar Icarus-Forge-2.12.0.jar integrated_api-1.5.1+1.20.1-forge.jar irons_spellbooks-1.20.1-3.4.0.9.jar iwannaskate-1.2.0.jar l2library-2.5.1.jar letsdo-API-forge-1.2.15-forge.jar letsdo-bakery-forge-2.0.5.jar letsdo-brewery-forge-2.0.3.jar letsdo-brewery-forge-2.0.5.jar letsdo-candlelight-forge-2.0.2.jar letsdo-farm_and_charm-forge-1.0.4.jar letsdo-herbalbrews-forge-1.0.12.jar letsdo-nethervinery-forge-1.2.17.jar letsdo-vinery-forge-1.4.39.jar modulargolems-2.5.19.jar mutil-1.20.1-6.2.0.jar Pehkui-3.8.2+1.20.1-forge.jar Placebo-1.20.1-8.6.3.jar player-animation-lib-forge-1.0.2-rc1+1.20.jar Powah-5.0.10.jar productivebees-1.20.1-12.6.0.jar Rats-1.20.1-8.1.3.jar refinedstorage-1.12.4.jar refinedstorageaddons-0.10.0.jar RSInfinityBooster-1.20.1-1.0+41.jar rsjukeboxes-1.20.1-1.0.1.0.jar ScorchedGuns-0.4.1-1.20.1.jar simplyswords-forge-1.56.0-1.20.1.jar sophisticatedbackpacks-1.20.1-3.23.23.1281.jar sophisticatedcore-1.20.1-1.2.75.1033.jar soul-fire-d-forge-1.20.1-4.0.11.jar supermartijn642configlib-1.1.8-forge-mc1.20.jar the_bumblezone-7.7.1+1.20.1-forge.jar the_dirty_stuff-2.1-forge-1.20.1.jar traveloptics-4.4.0-1.20.1.jar unusualprehistory-1.5.0.3.jar voicechat-forge-1.20.1-2.5.30.jar wits-1.1.0+1.20.1-forge.jar xercapaint-1.20.1-1.0.1.jar Updated mods: azurelib (3.0.8 > 3.0.9) lithostitched-forge-1.20.1-1.4.10.jar > lithostitched-forge-1.20.1-1.4.11.jar  
    • Ugdhar
      How many peole in theory could my server support on minecraft.

      By Ugdhar · Posted

      Graphics are irrelevant for a server. According to google, it should support 20-40. I literally asked it "how many players on a lightly modded minecraft server will a ryzen 5 2600 with 32GB ram support?" Maybe someone with some real world experience has further input. I can say without a doubt that if you run Linux as opposed to windows for the server operating system, you will get better performance and have more resources available to your server.
    • s6than
      The game crashed: exception in server tick loop Error: java.lang.NullPointerException: Exception in server tick loop

      By s6than · Posted

      Could someone help me to figure out what's the problem?  I get this crash when I try to enter to a world in forge 1.12.2:  The game crashed: exception in server tick loop Error: java.lang.NullPointerException: Exception in server tick loop Error code: -1 here is the crash report crash-2025-07-15_20.44.02-server333.txt
    • TeaJayy
      The game crashed: ticking memory connection Error: java.lang.Null

      By TeaJayy · Posted

      here is the rest https://mclo.gs/MyQUxLO
    • mojack66
      How many peole in theory could my server support on minecraft.

      By mojack66 · Posted

      I know some one who wants to host a moderately large lightly modded(less than 80~ mods, vanilla + type stuff) minecraft server expecting about 50-60 players at max and 15-25 consistent players. The main game play will be more of a building and mod progression type of thing not a pvp smp. The specs on the pc i use as a standalone server are  -ryzen 5 2600 -32 gb 3600 ram -gtx1050 -Samsung 870 QVO SSD -internet is good enough 700mb up 200mb down Would it be able to support this if not what would you recommend. (I would use server optimization mods and preloading chunks.)

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept