[1.6.2] Fire doesn't extinguish correctly

[sep87x]

Hey lads and gents,

 

I've released a mod yesterday which went pretty well on the Minecraft Forums and Planet Minecraft last night (see here). This mod is about extinguishing fire by blowing into your microphone. Anyway, today I recognized an annoying bug. When I try to extinguish the fire (simply setting block ID to 0), it kinda still exists and creates new fires around the fire which has been "extinguished" ... sometimes at very unusual places like 4 blocks away from the source.

 

I found the extinguishFire() method in the World.java and I tried it, but I found out that it does pretty much the same. It simply sets a new air block instead of the fire block, but I know that this doesn't really work out. Ridiculously, this case only appears when the fire is at the bottom of a block or on the side of a block. Not when the fire is on top of the block. Can anyone help me out? This starts to get really annoying. I'll provide you with code if needed, but I think I explained pretty much all you need

 

Greetings from Germany

~sep87x

[sep87x]

/push

 

Does no one have an idea? I'm a bit in trouble now because the hype about this mod just started and I NEED to get rid of this bug. I have tried some more methods like posting the PlayerInteractEvent to the event bus, use world.setBlockToAir() (also used by the BlockFire class) but none of these worked.

 

I found some further information about this bug. When I try to replace the block with air, the fire still exists, but it is invisible, so players and mobs can still get caught on fire. I don't even need a piece of code to fix this, just tell me your suggestions.

 

~sep87x

[Jacknoshima]

The part of the code you used that turns the block from fire to 0 would be helpful

 

Either way though, I would've though extinguishFire() would work... but seeing the code would help to work out where it's gone wrong

 

also

that mod sounds REALLY awesome

I don't think I've ever seen a mod like that before

[sep87x]

This is the code which extinguishes the fire. All commented lines are things that I tried and never worked.

 

if (sysTime - f.startTime >= 500 + 500 * d) {
//Block.fire.onBlockClicked(world, x, y, z, player);
//Block.fire.breakBlock(world, x, y, z, 0, 0);
//Block.fire.onBlockDestroyedByPlayer(world, x, y, z, 0);
//world.setBlockToAir(x, y, z);
//world.setBlock(x, y, z, 0);
//MinecraftForge.EVENT_BUS.post(new PlayerInteractEvent(player, Action.LEFT_CLICK_BLOCK, x, y, z, 1));

/**for (int i = 0; i <= 5; i++) {
	world.extinguishFire(player, x, y, z, i);
}**/
}

 

The variable f is an object called "FireState". It contains the coordinate of a fire and the start time of the system, when the fire was located. (x, y, z - Fire coordinates) The variable d calculates the distance in blocks from the player to the fire. (0 to 4)

[Mew]

I would suggest trying to get the layout of blocks around, then erasing / replacing them. I know this would not work at all, but that is all the heck I have. ( I left a comment on your PMC post btw, I go by many names )

I wish I could think of something, but

 

Have you tried looking into what water does when it comes into contact with fire? That would seem like another logical place to check. I guess you could also try placing a block of water that disappears again... Hey, you asked for suggestions

 

Also, I do believe that blowing on a fire makes it burn stronger... I would consider that if I were you! Still a great mod idea though...

[sep87x]

I've looked into the code, but found the same code as I tried below. I think I found the source of the error. The change has been submitted to the client, but not for the server, so for the server, the fire still exists. That means I need to send a Packet55BlockDestroy to server, but it needs to come expected. I tried it out but it always came unexpected. Any suggestions?

 

PacketDispatcher.sendPacketToServer(new Packet55BlockDestroy(player.entityId, x, y, z, 15));

^ Code until now

[Mew]

I've looked into the code, but found the same code as I tried below. I think I found the source of the error. The change has been submitted to the client, but not for the server, so for the server, the fire still exists. That means I need to send a Packet55BlockDestroy to server, but it needs to come expected. I tried it out but it always came unexpected. Any suggestions?

 

PacketDispatcher.sendPacketToServer(new Packet55BlockDestroy(player.entityId, x, y, z, 15));

^ Code until now

 

That makes so much sense Why didn't I think of that? *facepalms* of course it's client side, you are working with the clients microphone for crying out loud! So yes, that seems to be the case doesn't it. I am looking into it now. Expand on unexpected please? I am pushing the limits of my awakens right now.

[sep87x]

That makes so much sense Why didn't I think of that? *facepalms* of course it's client side, you are working with the clients microphone for crying out loud! So yes, that seems to be the case doesn't it. I am looking into it now. Expand on unexpected please? I am pushing the limits of my awakens right now.

 

Yeah, I thought of that while I was taking a nap Regarding the "unexpected": this screen pops up.

 

 

Most likely the server found out that this might be something suspicious, like cheating, so I must find a way to tell the server that this is not a cheat.

 

€dit:

 

I found a more appropriate method, but it doesn't really do what I want. Nevertheless, it doesn't raise the "unexpected screen".

 

mc.thePlayer.sendQueue.handleBlockDestroy(new Packet55BlockDestroy(mc.thePlayer.entityId, x, y, z, i));

[Mew]

That to me seems like you have no channel set up... I am not sure if you need it but.. Well, may as well try

[sep87x]

Yeaaaah, I have a channel set up and a packet handler, but the packet handler is pretty useless, because I don't want to recieve packets. I just want to send a packet ... or do I need to recieve this packet in some way? As I looked in the tutorial, it seemed pretty useless for my mod.

[Mew]

Well... I have no clue then Well, have fun. There is a bed with my name on it

 

I need some sleep... Ill sleep on it

[GotoLink]

When you send a packet, it is recommended to receive it yourself.

It also make more sense to send it from your microphone handling class (which is client side) and perform checks and changes on server before sending back the changes to the client.

[sep87x]

I don't think I need to send a custom packet. I found some interesting methods in the sendQueue of the EntityClientPlayerMP (mc.thePlayer).

 

mc.thePlayer.sendQueue.addToSendQueue(new Packet55BlockDestroy(mc.thePlayer.entityId, x, y, z, 15));
mc.thePlayer.sendQueue.handleBlockDig(new Packet14BlockDig(2, x, y, z, 1));

 

They both don't work, or am I missing something?

[Mew]

Wish I knew

 

 

I would agree with GotoLink, but the fact of the matter is that you still have to tell the server that a block w

 

Actually, wouldn't the block break packet be sent from the server to the client? Because the WorldGen and block location stuff is all stored server side, the client just displays that information. That is probably why the first packet is not working. You are sending the packet from the client, back to the client again.

[Jwosty]

@Mew: I've been having the same issue with the packet handlers where if I try to send a custom packet from the client, it comes back to the client and not to the server... Any idea on why it's doing this and how to fix it? It's so very frustrating!

[Mew]

@Mew: I've been having the same issue with the packet handlers where if I try to send a custom packet from the client, it comes back to the client and not to the server... Any idea on why it's doing this and how to fix it? It's so very frustrating!

 

Are you sure it's not making it to the server? Its quite hard ( for me anyway ) to determine wether or not the packet has gone through...

[sep87x]

Actually, the Packet14BlockDig worked in some way. You were able to see this "destroying progress" in the fire (you know, these cracks). Regarding the BlockBreakPacket, you were right. I think I'm thinking too difficult. I know I need to send the fitting packet to the server to make the server recognize that there's no fire anymore, but I won't be able to make this with a custom packet, or am I? I'm a bit confused right now.

[Mew]

No. No. and.... No.

 

You are wanting the SERVER to tell the CLIENT that the fire has disappeared, so you want to have the BlockBreakPacket executed on the server and have the results sent to the client. So yes, I think you may need your own packets because you have to let the server know that the microphone is being blown and how strong etc. Then, in a handler that is server side, do the checks to see if the microphone has been blown enough to put out the fire and send the packet. So I am thinking you will only need one packet, but I may be wrong.

[sep87x]

I'll give myself a break though. I need to reorganize my thoughts while I sleep.

 

Person sep = World.getPersonByUsername("sep87x");
Brain brain = Brain.getInstance(sep);
brain.setActivity(0);
sep.sleepAndRegenerate();

[Jwosty]

@Mew: I've been having the same issue with the packet handlers where if I try to send a custom packet from the client, it comes back to the client and not to the server... Any idea on why it's doing this and how to fix it? It's so very frustrating!

 

Are you sure it's not making it to the server? Its quite hard ( for me anyway ) to determine wether or not the packet has gone through...

 

I'm also finding it quite difficult to do so

 

I've tried a few ways:

 

 

public class PacketHandler implements IPacketHandler {
@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player) {
	if (packet.channel.equals("MyPacket")) {
		this.handleMyPacket(packet);
	}
}

@SideOnly(Side.SERVER)
public void handleMyPacket(Packet250CustomPayload packet) {
	Side effectiveSide = FMLCommonHandler.instance().getEffectiveSide();
	Side side = FMLCommonHandler.instance().getSide();
	Boolean isClient = Minecraft.getMinecraft().theWorld.isRemote;
	// actual code here
}

 

 

Unless I comment out the

@SideOnly

annotation, the game crashes with a NoMethodFound error, indicating that the packet is being handled client-side.

side

and

isClient

get set to

Side.CLIENT

and

true

respectively, which would mean that the code is server-side, while

effectiveSide

is

Side.SERVER

, indicating that the code is being handled client-side. I'm most inclined to believe the SideOnly annotation and the value of

world.isRemote

, especially since the latter should have failed if it were running server side (well, the

Minecraft.getMinecraft()

part)

[Mew]

Try using diesieben07's advanced packet handling tutorial. It works like a charm for me. After being explained what packets do, I now see so many errors that I have had in my mods before

 

Here is the tutorial http://www.minecraftforge.net/wiki/Advanced_Packet_Handling

[Jwosty]

Ok, just finished implementing their packet handler, but the exact same thing happens. See my GitHub repo for the code...

 

PS: I feel like I'm taking over OP's thread... I have my own I created recently. But then again, this _is_ relevant (at least, I _think_ OP and I are having the same problem here...). Should we discuss there or here?

[Mew]

Well... I have no idea. Could I see some of your code? Especially the code that is related to the sending of the packet, the packet, and the any data associated with the packet.

[Jwosty]

Relevant code: PacketHandler.java (code is pretty much copy-paste from the tutorial here), SDPacket.java (once again, no changes other than the name), OutgoingWormholePacket.java (the same as TestPacket but with different data), and finally BlockStargateController.java line 129 (sends the custom packet from the client side with some test data)

 

If it matters, I'm using 1.6.2 but I assumed that's what you assumed

[Mew]

Relevant code: PacketHandler.java (code is pretty much copy-paste from the tutorial here), SDPacket.java (once again, no changes other than the name), OutgoingWormholePacket.java (the same as TestPacket but with different data), and finally BlockStargateController.java line 129 (sends the custom packet from the client side with some test data)

 

If it matters, I'm using 1.6.2 but I assumed that's what you assumed

 

Why are you doing all that queue stuff? You just need to go OutgoingWormholePacket packet = new OutgoingWormholePacket(params); packet.makePacket(); and you should be good