Jump to content

[1.18] Updating multiple containerData in block entity's tick method causes strange behaviour


Myxtro

Recommended Posts

I'm making an incubator block in which you can put eggs which will then result in hatched eggs after some time.
The block entity has 4 slots. Each slot should be able to make it's own progress independently of other slots. When you put an egg in slot 1, the progress of slot 1 should go up over time.

I have the issue where the progress of slots 2 to 4 doesn't go up unless there's eggs in the slots that come before it. For example, slot 2's progress is stuck on 1 if there's no egg in slot 1. As soon as you put an egg in slot 1, the progress of both slots goes up.

Here's the code inside the tick method:
 

public static void tick(Level pLevel, BlockPos pPos, BlockState pState, IncubatorBlockEntity pBlockEntity) {
        if(!pLevel.isClientSide) {
            // Slot 1
            if (hasRecipe(pBlockEntity, 0)) { // 0 references slot 1 which has index 0
                pBlockEntity.slot1Progress++;
                setChanged(pLevel, pPos, pState);
                //System.out.println("Slot 1 progress: " + pBlockEntity.slot1Progress);
                if (pBlockEntity.slot1Progress > pBlockEntity.maxProgress) {
                    craftItem(pBlockEntity, 0); // 0 references slot 1 which has index 0
                    pBlockEntity.resetProgress(0); // 0 references slot 1 which has index 0
                    setChanged(pLevel, pPos, pState);
                }
            } else {
                pBlockEntity.resetProgress(0); // 0 references slot 1 which has index 0
                setChanged(pLevel, pPos, pState);
            }

            // Slot 2
            if (hasRecipe(pBlockEntity, 1)) { // 1 references slot 2 which has index 1
                pBlockEntity.slot2Progress++;
                setChanged(pLevel, pPos, pState);
                //System.out.println("Slot 2 progress: " + pBlockEntity.slot2Progress);
                if (pBlockEntity.slot2Progress > pBlockEntity.maxProgress) {
                    craftItem(pBlockEntity, 1); // 1 references slot 2 which has index 1
                    pBlockEntity.resetProgress(1); // 1 references slot 2 which has index 1
                    setChanged(pLevel, pPos, pState);
                }
            } else {
                pBlockEntity.resetProgress(1); // 1 references slot 2 which has index 1
                setChanged(pLevel, pPos, pState);
            }

		// Slot 3 and 4

 

The constructor with the containerData is as follows:

public IncubatorBlockEntity(BlockPos pWorldPosition, BlockState pBlockState) {
        super(ModBlockEntities.INCUBATOR_BLOCK_ENTITY.get(), pWorldPosition, pBlockState);
        this.data = new ContainerData() {
            @Override
            public int get(int index) {
                return switch (index) {
                    case 0 -> IncubatorBlockEntity.this.slot1Progress;
                    case 1 -> IncubatorBlockEntity.this.slot2Progress;
                    case 2 -> IncubatorBlockEntity.this.slot3Progress;
                    case 3 -> IncubatorBlockEntity.this.slot4Progress;
                    case 4 -> IncubatorBlockEntity.this.maxProgress;
                    default -> 0;
                };
            }

            @Override
            public void set(int index, int value) {
                switch (index) {
                    case 0 -> IncubatorBlockEntity.this.slot1Progress = value;
                    case 1 -> IncubatorBlockEntity.this.slot2Progress = value;
                    case 2 -> IncubatorBlockEntity.this.slot3Progress = value;
                    case 3 -> IncubatorBlockEntity.this.slot4Progress = value;
                    case 4 -> IncubatorBlockEntity.this.maxProgress = value;
                }
            }

            @Override
            public int getCount() {
                return 5;
            }
        };
    }

 

The hasRecipe method simply returns a boolean to tell whether it contains an egg. I'm certain this method doesn't cause issues.

I have determined that the resetProgress method doesn't get called at unintended times either. 

 

So what could be the problem? 

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I want to add trees to my mod but all the examples I've seen so far include data generation, and not json files. The json files for the blocks are not the issue here. Unless trees require certain json files as a structure, I'm certain I've got this part covered. The thing I'm looking for is probably a deferred register or any other way to register something as a tree so it will grow from a sapling. Here is what I currently have: public static final DeferredRegister<ConfiguredFeature<?, ?>> TREES = DeferredRegister.create(Registries.CONFIGURED_FEATURE, ExtinctionCraft.MOD_ID); // How do I register the tree? public static final ResourceKey<ConfiguredFeature<?, ?>> SEQUOIA_KEY = registerKey("sequoia"); public static void bootstrap(BootstapContext<ConfiguredFeature<?, ?>> context) { register(SEQUOIA_KEY, Feature.TREE, new TreeConfiguration.TreeConfigurationBuilder( BlockStateProvider.simple(ModBlocks.SEQUOIA_LOG.get()), new StraightTrunkPlacer(5, 4, 3), BlockStateProvider.simple(ModBlocks.SEQUOIA_LEAVES.get()), new PineFoliagePlacer(ConstantInt.of(3), ConstantInt.of(2), ConstantInt.of(3)), new TwoLayersFeatureSize(1, 0, 2)).build()); } public static ResourceKey<ConfiguredFeature<?, ?>> registerKey(String name) { return ResourceKey.create(Registries.CONFIGURED_FEATURE, new ResourceLocation(ExtinctionCraft.MOD_ID, name)); } private static <FC extends FeatureConfiguration, F extends Feature<FC>> void register(BootstapContext<ConfiguredFeature<?, ?>> context, ResourceKey<ConfiguredFeature<?, ?>> key, F feature, FC configuration) { context.register(key, new ConfiguredFeature<>(feature, configuration)); } I also have this Grower class: public class SequoiaGrower extends AbstractTreeGrower { @Nullable @Override protected ResourceKey<ConfiguredFeature<?, ?>> getConfiguredFeature(RandomSource pRandom, boolean pHasFlowers) { return ModConfiguredFeatures.SEQUOIA_KEY; } } And the registry of the blocks that make up the tree (excluding wood blocks that I have registered but that don't make up part of a tree): public static final RegistryObject<Block> SEQUOIA_LOG = registerBlock("sequoia_log", () -> new ModFlammableRotatedPillarBlock(BlockBehaviour.Properties.copy(Blocks.OAK_LOG).strength(3))); public static final RegistryObject<Block> SEQUOIA_LEAVES = registerBlock("sequoia_leaves", () -> new ModLeavesBlock(BlockBehaviour.Properties.copy(Blocks.OAK_LEAVES))); public static final RegistryObject<Block> SEQUOIA_SAPLING = registerBlock("sequoia_sapling", () -> new SaplingBlock(new SequoiaGrower(), BlockBehaviour.Properties.copy(Blocks.OAK_SAPLING)));   How do I move on from here? Examples of your code are welcome too.
    • These libraries failed to download. Try again. com.google.code.findbugs:jsr305:3.0.2 commons-io:commons-io:2.4
    • Make a test just with Forge - without any mods Then add the latest.log from your logs-folder
    • Make a test with a custom directory https://minecrafthopper.net/help/guides/changing-game-directory/
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.