Jump to content

can i set the critical hit damage on a sword/tool


TwIxToR_TiTaN

Recommended Posts

Can you check the player's equipped weapon/tool, and whether a hit is a crit? If so, you might be able to work something in a LivingHurtEvent.

 

If [DamageSource is Player]
    if [Hit is a Crit]     //Not sure if/how this can be checked. EntityPlayer.java line 1330 may be a start
         If [Player Equipping Proper Weapon]          // If you only want the buffed criticals to apply to certain weapons/tools          
            ammount = weapon.base + crit bonus             //Yes. ammount is misspelled. 

Link to comment
Share on other sites

you do: [.code]YOUR TEXT[/.code]

(remove the dots)

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Link to comment
Share on other sites

maybe this works:

 

@ForgeSubscribe
public void onEntityHit(LivingHurtEvent event)
{
	if (!(event.source instanceof EntityDamageSource))
	{
		return;
	}

	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{
		return;
	}

	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();

	if (!(weapon.getItem() instanceof *PUT_YOUR_SWORD_CLASS_HERE*)) //EDIT: forgot the .getItem()
	{
		return null;
	}

	/**
	 * Copied from {@link EntityPlayer#1345}
	 */
	boolean flag = player.fallDistance > 0.0f && !player.onGround && !player.isOnLadder() && !player.isInWater() && !player.isPotionActive(Potion.blindness) && !player.isRiding();

	if (flag)
	{
		event.ammount += *PUT_CRIT_AMOUNT_HERE*;
	}
}

 

 

If I was any help please hit that "Thank You" button.

Link to comment
Share on other sites

maybe this works:

 

@ForgeSubscribe
public void onEntityHit(LivingHurtEvent event)
{
	if (!(event.source instanceof EntityDamageSource))
	{
		return;
	}

	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{
		return;
	}

	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();

	if (!(weapon.getItem() instanceof *PUT_YOUR_SWORD_CLASS_HERE*)) //EDIT: forgot the .getItem()
	{
		return null;
	}

	/**
	 * Copied from {@link EntityPlayer#1345}
	 */
	boolean flag = player.fallDistance > 0.0f && !player.onGround && !player.isOnLadder() && !player.isInWater() && !player.isPotionActive(Potion.blindness) && !player.isRiding();

	if (flag)
	{
		event.ammount += *PUT_CRIT_AMOUNT_HERE*;
	}
}

do i need to put this code in a eventhandler class or somthing?

Only code when your having fun doing it.

Link to comment
Share on other sites

ok so i modified your code to eliminate errors but i cant seem to make it work xD this is funny coincidence i was trying to do this before i cam on here so yeah.

 

@EventHandler
public void onEntityHit(LivingHurtEvent event)
{
	if (!(event.source instanceof EntityDamageSource))
	{
		return;
	}

	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{
		return;
	}

	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();

	if (!(weapon.getItem() instanceof LightSteelRapier))
	{
		return;
	}


	Random random1Generator = new Random();
	int ran1 = random1Generator.nextInt(25);{

	if (ran1 == 10)
	{
		event.ammount += 10000000;
	}}
}

Use examples, i have aspergers.

Examples make sense to me.

Link to comment
Share on other sites

i found a problem with you code? a bug or somthing?

 

if (!(weapon.getItem() instanceof *PUT_YOUR_SWORD_CLASS_HERE*)) //EDIT: forgot the .getItem()

{

return null;

}

 

 

on this part, the return null is an error, it suggests you remove the "null" but if you do when you hit something with your hand it crashed the game saying ee al one method not closed or something like that and it says that this line is the problem? anyone got any ideas?

Use examples, i have aspergers.

Examples make sense to me.

Link to comment
Share on other sites

i figured out the void bit, i was questioning the code, i didnt write it if you read the above parts of the post. Also would the null check be something like this?

 

@ForgeSubscribe
public void onEntityHit1(LivingHurtEvent event)
{
	if (!(event.source instanceof EntityDamageSource))
	{
		return;
	}
	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();
	if (!(ent instanceof EntityPlayer))
	{
		return;
	}
	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();
	if (!(weapon.getItem() == null)){
	if (weapon.getItem() instanceof ImmortalTheSkewer)
	{
	Random random1Generator = new Random();
	int ran1 = random1Generator.nextInt(100);{
	if (ran1 < 2){
		event.ammount += 100;
	}}}}
}

Use examples, i have aspergers.

Examples make sense to me.

Link to comment
Share on other sites

but if the weapon = null i dont want it do do anything xD

 

this works with my old version of the event, but when i attack with the hand it crashes and says AL lib: (EE) alc_cleanup: 1 device not closed.

 

any other tool or item works fine, so i understand what your saying but isnt it if whats in my hand isn't the specified item it should not do anything? and surly hand does not equal weapon of choice so why the crash???

 

maybe because they hand isnt an item at all...

 

so, i put if weapon item doesnt equal nothing (hand) then check if its the specified item, so why does this not worl?

((!(weapon.getItem() == null)){

 

Use examples, i have aspergers.

Examples make sense to me.

Link to comment
Share on other sites

and finally just for luck,

can you see any errors or modifications that would make the code better?

 

@ForgeSubscribe
public void onEntityHit1(LivingHurtEvent event)
{
	if (!(event.source instanceof EntityDamageSource))
	{
		return;
	}
	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();
	if (!(ent instanceof EntityPlayer))
	{return;}
	Random random1Generator = new Random();
	int ran1 = random1Generator.nextInt(100);
	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();
	if (!(weapon == null)){
if (weapon.getItem() instanceof MythicalVampiricBlade)
		{if (ran1 < 13){
		player.addPotionEffect(new PotionEffect(Potion.field_76444_x.getId(), 600, 4));}}
if (weapon.getItem() instanceof ImmortalTheSkewer)
		{if (ran1 < 2){
		event.ammount += 100;}}
if (!(weapon.getItem() instanceof MythicalSteelRapier))
		{if (ran1 < 80)
		{event.ammount += 10;}}
if (!(weapon.getItem() instanceof SharpWoodSword) || (weapon.getItem() instanceof SharpStoneSword) || (weapon.getItem() instanceof SharpIronSword )|| (weapon.getItem() instanceof SharpSteelSword) || (weapon.getItem() instanceof SharpDiamondSword) || (weapon.getItem() instanceof SharpGoldSword))
		{if (ran1 < 2){
			event.ammount += 100;
		}}}}

 

btw please don't steal my ideas D:

 

-EDIT i just found a misplaced construct have changed the code above, and again xD

Use examples, i have aspergers.

Examples make sense to me.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • rp.crazyheal.xyz mods  
    • I'm developing a dimension, but it's kinda resource intensive so some times during player teleporting it lags behind making the player phase down into the void, so im trying to implement some kind of pregeneration to force the game loading a small set of chunks in the are the player will teleport to. Some of the things i've tried like using ServerLevel and ServerChunkCache methods like getChunk() dont actually trigger chunk generation if the chunk isn't already on persistent storage (already generated) or placing tickets, but that doesn't work either. Ideally i should be able to check when the task has ended too. I've peeked around some pregen engines, but they're too complex for my current understanding of the system of which I have just a basic understanding (how ServerLevel ,ServerChunkCache  and ChunkMap work) of. Any tips or other classes I should be looking into to understand how to do this correctly?
    • https://mclo.gs/4UC49Ao
    • Way back in the Forge 1.17 days, work started for adding JPMS (Java Platform Module Support) to ModLauncher and ForgeModLoader. This has been used internally by Forge and some libraries for a while now, but mods (those with mods.toml specifically) have not been able to take advantage of it. As of Forge 1.21.1 and 1.21.3, this is now possible!   What is JPMS and what does it mean for modders? JPMS is the Java Platform Module System, introduced in Java 9. It allows you to define modules, which are collections of packages and resources that can be exported or hidden from other modules. This allows for much more fine-tuned control over visibility, cleaner syntax for service declarations and support for sealed types across packages. For example, you might have a mod with a module called `com.example.mod` that exports `com.example.mod.api` and `com.example.mod.impl` to other mods, but hides `com.example.mod.internal` from them. This would allow you to have a clean API for other mods to use, while keeping your internal implementation details hidden from IDE hints, helping prevent accidental usage of internals that might break without prior notice. This is particularly useful if you'd like to use public records with module-private constructors or partially module-private record components, as you can create a sealed interface that only your record implements, having the interface be exported and the record hidden. It's also nice for declaring and using services, as you'll get compile-time errors from the Java compiler for typos and the like, rather than deferring to runtime errors. In more advanced cases, you can also have public methods that are only accessible to specific other modules -- handy if you want internal interactions between multiple of your own mods.   How do I bypass it? We understand there may be drama in implementing a system that prevents mods from accessing each other's internals when necessary (like when a mod is abandoned or you need to fix a compat issue) -- after all, we are already modding a game that doesn't have explicit support for Java mods yet. We have already thought of this and are offering APIs from day one to selectively bypass module restrictions. Let me be clear: Forge mods are not required to use JPMS. If you don't want to use it, you don't have to. The default behaviour is to have fully open, fully exported automatic modules. In Java, you can use the `Add-Opens` and `Add-Exports` manifest attributes to selectively bypass module restrictions of other mods at launch time, and we've added explicit support for these when loading your Forge mods. At compile-time, you can use existing solutions such as the extra-java-module-info Gradle plugin to deal with non-modular dependencies and add extra opens and exports to other modules. Here's an example on how to make the internal package `com.example.examplemod.internal` open to your mod in your build.gradle: tasks.named('jar', Jar) { manifest { attributes([ 'Add-Opens' : 'com.example.examplemod/com.example.examplemod.internal' 'Specification-Title' : mod_id, 'Specification-Vendor' : mod_authors // (...) ]) } } With the above in your mod's jar manifest, you can now reflectively access the classes inside that internal package. Multiple entries are separated with a space, as per Java's official spec. You can also use Add-Exports to directly call without reflection, however you'd need to use the Gradle plugin mentioned earlier to be able to compile. The syntax for Add-Exports is the same as Add-Opens, and instructions for the compile-time step with the Gradle plugin are detailed later in this post. Remember to prefer the opens and exports keywords inside module-info.java for sources you control. The Add-Opens/Add-Exports attributes are only intended for forcing open other mods.   What else is new with module support? Previously, the runtime module name was always forced to the first mod ID in your `mods.toml` file and all packages were forced fully open and exported. Module names are now distinguished from mod IDs, meaning the module name in your module-info.java can be different from the mod ID in your `mods.toml`. This allows you to have a more descriptive module name that doesn't have to be the same as your mod ID, however we strongly recommend including your mod ID as part of your module name to aid troubleshooting. The `Automatic-Module-Name` manifest attribute is now also honoured, allowing you to specify a module name for your mod without needing to create a `module-info.java` file. This is particularly useful for mods that don't care about JPMS features but want to have a more descriptive module name and easier integration with other mods that do use JPMS.   How do I use it? The first step is to create a `module-info.java` file in your mod's source directory. This file should be in the same package as your main mod class, and should look something like this: open module com.example.examplemod { requires net.minecraftforge.eventbus; requires net.minecraftforge.fmlcore; requires net.minecraftforge.forge; requires net.minecraftforge.javafmlmod; requires net.minecraftforge.mergetool.api; requires org.slf4j; requires logging; } For now, we're leaving the whole module open to reflection, which is a good starting point. When we know we want to close something off, we can remove the open modifier from the module and open or export individual packages instead. Remember that you need to be open to Forge (module name net.minecraftforge.forge), otherwise it can't call your mod's constructor. Next is fixing modules in Gradle. While Forge and Java support modules properly, Gradle does not put automatic modules on the module path by default, meaning that the logging module (from com.mojang:logging) is not found. To fix this, add the Gradle plugin and add a compile-time module definition for that Mojang library: plugins { // (...) id 'org.gradlex.extra-java-module-info' version "1.9" } // (...) extraJavaModuleInfo { failOnMissingModuleInfo = false automaticModule("com.mojang:logging", "logging") } The automatic module override specified in your build.gradle should match the runtime one to avoid errors. You can do the same for any library or mod dependency that is missing either a module-info or explicit Automatic-Module-Name, however be aware that you may need to update your mod once said library adds one. That's all you need to get started with module support in your mods. You can learn more about modules and how to use them at dev.java.
    • Faire la mise à jour grâce à ce lien m'a aider personnellement, merci à @Paint_Ninja. https://www.amd.com/en/support 
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.