Jump to content

[1.16.5] AbstractChestedHorseEntity (Donkey/Mule) don't work with itemInteractionForEntity


Recommended Posts

Posted

Hey I'm new to this forum and could not find the search function to look if this issues was already solved, sorry for that.

 

So I'm currently working on an item, which act similar like an apple.

The player should be able to eat it and the player should be able to feed it to all horses (incl. zombie, skeleton, mule, donkey).

The first part works fine. Now I wanted to add the feeding function by overriding itemInteractionForEntity(), but if I right click on an donkey/mule it does not target them.

So AbstractHorseEntity works fine, but without mule and donkey, as I can not target them. The function is not triggered in general when right clicking donkey/mule.

    @Override
    public ActionResultType itemInteractionForEntity(ItemStack itemStack, PlayerEntity player, LivingEntity target, Hand hand) {

      	System.out.println(target);
      
        if (!target.world.isRemote) {
            if (target instanceof AbstractHorseEntity) {

                itemStack.shrink(1);
            }
        }
        return super.itemInteractionForEntity(itemStack, player, target, hand);
    }

Is it possible to target mule/donkey, too?

 

And is it possible to disable mounting, if saddled when right click with the food item?

Posted (edited)

Okay I could find a workaround with EntityMountEvent and EntityInteract.

I can now feed every AbstractHorseEntity with the item and was able to cancel the mounting event.

Following Code kinda works fine for me, if someone has the same problem.
Still one bug:

- not tamed Zombie/Skeleton horses eat 2 items per click

    private static void feedingHorse(AbstractHorseEntity target, PlayerEntity player){

        ItemStack rightHand = player.getHeldEquipment().iterator().next();

        if (target.getHealth() < target.getMaxHealth()) {
            target.heal(3.0F);
        }

        if (target.isTame() && target.getTemper() < target.getMaxTemper()) {
            target.increaseTemper(3);
        }

        if (target.isChild()) {
            target.addGrowth(60);
        }

        if (!player.abilities.isCreativeMode) {
            rightHand.shrink(1);
        }
        player.playSound(ModSoundEvents.EATING_HORSE_FOOD.get(), SoundCategory.NEUTRAL, 1, 1);
    }

    @SubscribeEvent
    public static void onEntityMount(EntityMountEvent event) {

        Iterable<ItemStack> equip = event.getEntityMounting().getHeldEquipment();
        ItemStack rightHand = equip.iterator().next();
        Entity entityMounting = event.getEntityMounting();
        Entity target = event.getEntityBeingMounted();

        if (!target.isRidingOrBeingRiddenBy(entityMounting)) {
            if (entityMounting instanceof PlayerEntity) {
                if (target instanceof AbstractHorseEntity) {
                    if (rightHand.getItem() == ModItems.HORSE_FOOD.get()) {

                        feedingHorse((AbstractHorseEntity) target, (PlayerEntity) entityMounting);
                        event.setCanceled(true);
                    }
                }
            }
        }
    }

    /**
     * ADDED FOR NON TAMED HORSES
     */
    @SubscribeEvent
    public static void onPlayerInteractEntity(PlayerInteractEvent.EntityInteract event) {

        PlayerEntity player = event.getPlayer();
        ItemStack rightHand = player.getHeldEquipment().iterator().next();
        Entity target = event.getTarget();

        if(target instanceof AbstractHorseEntity){
            if(!((AbstractHorseEntity) target).isTame()){
                if(rightHand.getItem() == ModItems.HORSE_FOOD.get()){

                    feedingHorse((AbstractHorseEntity) target, player);
                }
            }
        }
    }

 

Edited by DillaSyx

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Please read the FAQ and post logs as described there.
    • Upon starting the server I get; [main/ERROR] [minecraft/Main]: Failed to start the minecraft server net.minecraftforge.fml.LoadingFailedException: Loading errors encountered: [     Framework (framework) has failed to load correctly §7java.lang.NoClassDefFoundError: net/minecraft/client/gui/components/toasts/Toast ] I suspect there is a (possibly a few) client-only mods installed on my server. Any help would be appreciated! (Yes I know there are a lot of mods...) Here is the crash log:   https://paste.ee/p/pRz5mhMl#s=0
    • That's basically what the failure does, my apologies for failing to specify.  It just tries again on the next tick until it detects the entities for that chunk are loaded, and then tries to load the entity.  From there it gets into different failure states depending on what goes wrong, but in short, if the entity fails to load once the entity list becomes available, the request is cleared and must be resubmitted by the end user.  There should be few cases where that actually happens. Yes, that is my understanding of forceloading.  That's why on a successful summon, it removes the forceload.  Otherwise it does just leave the chunks loaded long term. Thank you for your help, any knowledge is useful!  I don't often mess with forceloading and my prior experience is 1.16 so I'm also a bit out of my depth haha.
    • I will have to do more research about 1.18 chunk loading. You were unclear about how your code manages with the entity load failure. If you simply used a loop, I suggest submitting a tick task to the next tick which does the same thing, checking if the entities are loaded and if so teleporting the right one else submitting another tick task etc. Also I think forceloading permanently force loads the chunk, and it only starts to unload when you make a subsequent call to mark the chunk as not forceloaded. I may be completely wrong, I dont know much about 1.18, most of my experience is 1.20. Good luck I hope you figure it out after all this time 😅
    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.