Jump to content

How to set the LootModifier Set Item NBT?


Spring

Recommended Posts

public class AddItemModifier extends LootModifier {

    private final Item item;

    private final CompoundTag compoundTag;

    public static final Supplier<Codec<AddItemModifier>> CODEC =
            Suppliers.memoize(() -> RecordCodecBuilder.create(inst -> codecStart(inst)
                    .and(ForgeRegistries.ITEMS.getCodec().fieldOf("item").forGetter(m -> m.item))
                   //I didn't find anything about CompoundTag in ForgeRegistries?  ForgeRegistries.BIOMES be replaced with?                 
                    .and(ForgeRegistries.BIOMES.getCodec().fieldOf("nbt").forGetter(m -> m.compoundTag))
                    .apply(inst, AddItemModifier::new)));

    protected AddItemModifier(LootItemCondition[] conditionsIn, Item item, CompoundTag compoundTag) {
        super(conditionsIn);
        this.item = item;
        this.compoundTag = compoundTag;
    }

    @Override
    protected @NotNull ObjectArrayList<ItemStack> doApply(ObjectArrayList<ItemStack> generatedLoot,
                                                          LootContext context) {
        if (context.getRandom().nextFloat() >= 0.4f) {
            ItemStack out = new ItemStack(item);
            if (compoundTag != null) {
                out.setTag(compoundTag);
            }
            generatedLoot.add(new ItemStack(item));
        }
        return generatedLoot;
    }

    @Override
    public Codec<? extends IGlobalLootModifier> codec() {
        return CODEC.get();
    }
}

 

loot_modifiers folder

{
  "type": "chinacraft:add_item",
  "conditions": [
    {
      "condition": "forge:loot_table_id",
      "loot_table_id": "minecraft:chests/nether_bridge"
    }
  ],
  "item": "patchouli:guide_book",
  "nbt": "{\"patchouli:book\":\"chinacraft:mencius\"}"
}

thank you ! 

Link to comment
Share on other sites

hmm...

4 hours ago, Spring said:
            ItemStack out = new ItemStack(item);
            if (compoundTag != null) {
                out.setTag(compoundTag);
            }
            generatedLoot.add(new ItemStack(item));

so make a stack, okay, set the tag, okay (i'll just assume you tried that), then disregard the stack you made, make a new one without tag and put in into drops...

might work...

 

Link to comment
Share on other sites

On 12/13/2022 at 4:16 PM, MFMods said:

hmm...

so make a stack, okay, set the tag, okay (i'll just assume you tried that), then disregard the stack you made, make a new one without tag and put in into drops...

might work...

 

 

On 12/13/2022 at 11:50 AM, Spring said:
.and(ForgeRegistries.BIOMES.getCodec().fieldOf("nbt").forGetter(m -> m.compoundTag))

Maybe I didn't express my problem well.

But now it has been solved. This line of code is compiled incorrectly.

 

But I did。

public class AddItemTagModifier extends LootModifier {

    public static final Codec<CompoundTag> TAG_CODEC = Codec.PASSTHROUGH.comapFlatMap((convert) -> {
        Tag tag = convert.convert(NbtOps.INSTANCE).getValue();
        String replace = tag.toString().replace("'", "");
        CompoundTag compoundtag = null;
        try {
            compoundtag = TagParser.parseTag(replace);
        } catch (CommandSyntaxException e) {
            e.printStackTrace();
        }
        return DataResult.success(compoundtag);
    }, (value) -> new Dynamic<>(NbtOps.INSTANCE, value));

    private final Item item;

    private final CompoundTag compoundTag;

    public static final Supplier<Codec<AddItemTagModifier>> CODEC =
            Suppliers.memoize(() -> RecordCodecBuilder.create(inst -> codecStart(inst)
                    .and(ForgeRegistries.ITEMS.getCodec().fieldOf("item").forGetter(m -> m.item))
                    .and(TAG_CODEC.fieldOf("nbt").forGetter(m -> m.compoundTag))
                    .apply(inst, AddItemTagModifier::new)));

    protected AddItemTagModifier(LootItemCondition[] conditionsIn, Item item, CompoundTag compoundTag) {
        super(conditionsIn);
        this.item = item;
        this.compoundTag = compoundTag;
    }

    @Override
    protected @NotNull ObjectArrayList<ItemStack> doApply(ObjectArrayList<ItemStack> generatedLoot,
                                                          LootContext context) {
        if (context.getRandom().nextFloat() >= 0.4f) {
            ItemStack out = new ItemStack(item);
            if (compoundTag != null) {
                out.setTag(compoundTag);
            }
            generatedLoot.add(out);
        }
        return generatedLoot;
    }

    @Override
    public Codec<? extends IGlobalLootModifier> codec() {
        return CODEC.get();
    }

It works very well !

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • plz help me fix this!!: it wasn't doing this before, whenever I try to join my world it just stucks on the options screen and the 0% never ever shows up, and the game is now frozen! help me, please HELP! https://paste.gg/p/anonymous/0b4686cd036d496db16ec497b1ec7fb9
    • Internal ExeptIon server bug Image LInk  l V https://lens.google.com/search?ep=gsbubb&hl=en-CA&re=df&p=AbrfA8p0hRZLHI5ozxFtMWh8xA21sqBQ71eivErBLG_oF8j-5G7yFOjJQP7DxnD3oOFBAYE4ajAvyOag8ykwGITxwfBg-8CpFUB0plaWJyrGKiw28bj9LohjoyyI07OsFTE5vJa1o3aKF80ocbEG8U_v5QhX_B5B3k370goGoohHkTodvClNPrBATvS6rYMKO43iTr_QbdYL_78wxQ%3D%3D#lns=W251bGwsbnVsbCxudWxsLG51bGwsbnVsbCxudWxsLG51bGwsIkVrY0tKR1E1T1RjeU5ETTVMV05pTVRVdE5HWXdNeTA1TmpWbUxXUXdOekZtWVdZeE9EWTJZaElmYTNoV05VWmFVREJJYTFGVWMwNXBYM3AxVm1GWlRWVTNSRnBoTFVob2F3PT0iLG51bGwsbnVsbCxudWxsLG51bGwsbnVsbCxudWxsLG51bGwsWyI4ZDdmNDE1Yi00ZWViLTQ2NzItOWQyOS05MTA2MWNmMzYyNjciXV0=
    • Ensure your system is running the latest version of Java. Sodium requires Java 17 or later for newer Minecraft versions (like 1.17+). 
    • Hi I wanted to my custom mob to hold any sword item, but didn’t rendered properly.   In entity class, make entity hold items as below: @Override public InteractionResult mobInteract(Player pPlayer, InteractionHand pHand) { //… ItemStack itemstack = pPlayer.getItemInHand(pHand); if (this.isTame()) { if ( (itemstack.is(Items.MELON_SLICE) || itemstack.is(Items.HONEY_BOTTLE)) && this.getHealth() < this.getMaxHealth() ) { //… } /* Handle holding sword */ else if (itemstack.getItem() instanceof SwordItem) { pPlayer.displayClientMessage(Component.literal("Clicked with item: " + itemstack.getDisplayName().getString()).withStyle(ChatFormatting.GOLD), true); //Return sword //pPlayer.getInventory().add(this.getItemInHand(InteractionHand.MAIN_HAND)); pPlayer.getInventory().add(this.getItemBySlot(EquipmentSlot.MAINHAND)); //The entity holds item //this.setItemInHand(InteractionHand.MAIN_HAND, itemstack); this.setItemSlot(EquipmentSlot.MAINHAND, itemstack.copy()); //Give copy of itemstack //If player is not in creative mode. From mobInteract() in wolf. if (!pPlayer.getAbilities().instabuild) { //Decrement sword count in hand pPlayer.getItemInHand(pHand).shrink(1); } return InteractionResult.SUCCESS; } else { //If player is sneaking pPlayer.displayClientMessage(getItemInHand(InteractionHand.MAIN_HAND).getDisplayName(), false); if (pPlayer.isShiftKeyDown()) { //Return sword //pPlayer.getInventory().add(this.getItemInHand(InteractionHand.MAIN_HAND)); pPlayer.getInventory().add(this.getItemBySlot(EquipmentSlot.MAINHAND)); //The entity holds nothing this.setItemInHand(InteractionHand.MAIN_HAND, ItemStack.EMPTY); return InteractionResult.SUCCESS; } else { //… } } else { return interactionresult; } }   And in render class, render the item as below: @Override public void render(RanaEntity pEntity, float pEntityYaw, float pPartialTicks, PoseStack pMatrixStack, MultiBufferSource pBuffer, int pPackedLight) { if(pEntity.isBaby()) { pMatrixStack.scale(0.5f, 0.5f, 0.5f); } model.setupAnim(pEntity, 0, 0, 0, pEntityYaw, 0); // //Get location and rotation of arm bone ModelPart rightArm = model.rightArm(); //Get right arm //Get location and rotation of item according to arm bone pMatrixStack.pushPose(); pMatrixStack.translate(rightArm.x, rightArm.y, rightArm.z); //Move to bone location pMatrixStack.mulPose(Axis.XP.rotationDegrees(rightArm.xRot)); //Rotate X pMatrixStack.mulPose(Axis.YP.rotationDegrees(rightArm.yRot)); //Rotate Y pMatrixStack.mulPose(Axis.ZP.rotationDegrees(rightArm.zRot)); //Rotate Z //Draw item //ItemStack itemStack = pEntity.getItemInHand(InteractionHand.MAIN_HAND); ItemStack itemStack = pEntity.getItemBySlot(EquipmentSlot.MAINHAND); if (!itemStack.isEmpty()) { //Offset pMatrixStack.translate(0.0, 0.0, 0.1); // Render the item //Minecraft.getInstance().getItemRenderer().renderStatic(itemStack, ItemDisplayContext.THIRD_PERSON_RIGHT_HAND, pPackedLight, OverlayTexture.NO_OVERLAY, pMatrixStack, pBuffer, pEntity.level(), pEntity.getId()); //itemRenderer.renderStatic(itemStack, ItemDisplayContext.THIRD_PERSON_RIGHT_HAND, pPackedLight, OverlayTexture.NO_OVERLAY, pMatrixStack, pBuffer, pEntity.level(), pEntity.getId()); itemInHandRenderer.renderItem(pEntity, itemStack, ItemDisplayContext.THIRD_PERSON_RIGHT_HAND, false, pMatrixStack, pBuffer, pEntity.getId()); } pMatrixStack.popPose(); super.render(pEntity, pEntityYaw, pPartialTicks, pMatrixStack, pBuffer, pPackedLight); }   I confirmed the entity can properly hold item(logically) but the item which the entity holds is not rendered at all.   Full code: https://github.com/sakiiiiika/ranamod   Thanks.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.