Jump to content

Hooking my forge mod into a Bukkit plugin


Flenix

Recommended Posts

Hey guys,

 

Before I start this thread, I know a lot of people here don't like bukkit or don't "agree" with trying to connect the two. However, due to the nature of my mod, it would be stupid for me to not do this.

If you are opinionated against bukkit, please just keep it to yourself, I just want to get the issue solved without flame wars breaking out :P

 

Right, onto my issue;

 

I'm currently making an economy mod for Forge. It has physical money, which can be stored in a bank (with the balanced stored as NBT data on the player).

 

What I want to do, is add support for Bukkit plugins, if the server is running BukkitForge or MCPC+. For this, I have two options:

 

Option 1:

Hook Vault directly. This would mean that my economy mod would directly support the Vault API, and most bukkit plugins which have economy support will work with it. But, it would be hard to create new accounts on this system, unless I somehow allow players to have multiple accounts which I'm not quite sure how I would do...

 

Option 2:

Create an interfacing bukkit plugin. This would just be a simple bukkit economy plugin, designed to sync with my mod's balances. Using this, I could also have other accounts created very easily - which is essential for plugins like Towny or Factions.

 

 

In terms of Option 1, I did post on the Vault forums about how exactly I'd do that:

make the mod hook vault's economy service and register it into the bukkit service API.

 

What I don't understand is how I would hook Bukkit in the first place with a forge mod, without it being a dependancy. If Bukkit isnt' installed, my mod should continue without the bukkit support, I don't want it crashing if Bukkit isn't there.

 

 

As for Option 2, the main thing I can't figure out is how I would sync the accounts, and what would happen if a non-player account was created. The Forge side is stored as NBT on the player, in the /world directory, and the Bukkit side (I assume) would be stored in some sort of flatfile or db, in the /plugins directory. Both sides need to read each other frequently to check for changes, and sync accordingly. But what if the bukkit plugin creates a new account for a town with the name "Foobar"? There's no player called foobar, so what would the forge mod do when trying to sync that one? I can't just create the NBT... if a player made a town called "Notch" then Notch logged in, he'd have access to that towns money.

 

 

Final note, I have considered there might be issues with sync. For example, say an account has 300 in. If a town claims land and loses 15, but at the same time a player deposits 25 into their account, the numbers would both be off - bukkit would think it was 285 and Forge 325. I would handle this by storing a copy of the balance each time it syncs, then when it resyncs it checks that balance comapred to itself, and instead of saying "I'm 325", it would say "I have added 25". Bukkit would reply with "I have taken 15, so we are adding 10 to the existing balance" and they'd agree to sync on 310. Is that the best way of handling that scenario, or is there something easier? I don't want to sync too often, I was thinking every 5-10 seconds so it shouldn't cause any form of lag.

 

 

I'm open to any ideas, I'm really not sure how I'm going to do this integration at all. I'm pretty much just rambling now.. help! :P

width=463 height=200

http://s13.postimg.org/z9mlly2av/siglogo.png[/img]

My mods (Links coming soon)

Cities | Roads | Remula | SilvaniaMod | MoreStats

Link to comment
Share on other sites

I don't know anything about Bukkit, but I'll give my opinion (on your ideas :P)

 

Option 1:

Reflection.

If Bukkit are good and give an appropriate answer to their registering methods, this could be as simple as any code, except you catch more exceptions.

 

Option 2:

Brings the syncing issue.

I don't know how Forge+Bukkit would load mod+plugin (order, dependency ?), might be messy.

 

About the syncing, I'll say that Forge should keep priority. Isn't the purpose of the Bukkit part for compatibility only ?

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ok yeah I think this might be where the problem starts. For starters, I think you can get rid of your RecipeType impl and make it a static constant instead. I'm not 100% sure this will fix it but it's posssible. RuneInscribingRecipe public class RuneInscribingRecipe implements Recipe<SimpleContainer> { public static final RecipeType<RuneInscribingRecipe> RECIPE_TYPE = new RecipeType<>(){}; // .... @Override public RecipeType<?> getType() { return RECIPE_TYPE; } // .... } RuneInscriberMenu private Optional<RecipeHolder<RuneInscribingRecipe>> getCurrentRecipe() { SimpleContainer inventory = new SimpleContainer(2); inventory.setItem(BASE_INPUT_SLOT, this.inventory.getStackInSlot(BASE_INPUT_SLOT)); inventory.setItem(TEMPLATE_INPUT_SLOT, this.inventory.getStackInSlot(TEMPLATE_INPUT_SLOT)); List<RecipeHolder<RuneInscribingRecipe>> list = this.blockEntity.getLevel().getRecipeManager().getRecipesFor(RuneInscribingRecipe.RECIPE_TYPE, inventory, this.blockEntity.getLevel()); if (list.isEmpty()) { return Optional.empty(); } return Optional.of(list.get(0)); }   Also, this here is a little suspicious where you're getting the `this.inventory.getStackInSlot` calls. I'd try and make sure those are what you expect they are with either a Debug line in IDE or print statement SimpleContainer inventory = new SimpleContainer(2); inventory.setItem(BASE_INPUT_SLOT, this.inventory.getStackInSlot(BASE_INPUT_SLOT)); System.out.printf("CHECKING BASE INPUT OF RECIPE: %s\n", this.inventory.getStackInSlot(BASE_INPUT_SLOT)); inventory.setItem(TEMPLATE_INPUT_SLOT, this.inventory.getStackInSlot(TEMPLATE_INPUT_SLOT)); System.out.printf("CHECKING TEMPLATE INPUT OF RECIPE: %s\n", this.inventory.getStackInSlot(TEMPLATE_INPUT_SLOT)); ^ See what the result of those print statements are, make sure they're right
    • Upon testing again after adding them, the game still doesn't crash however the resource packs are still unfortunately broken.
    • Hi! Can someone please point me to the correct FAQ or place? I'm not able do DuckDuckGo myself out of this one. As you can hopefully see, chunks are not rendered. I run a forge server, fresh install on a linux VM. Curseforge on the Win11 client with Embeddium, Oculus and Unbound shader. No mods. Forge 47.2.23 on server & client.  No errors, no crashes, no apparent CPU or RAM issues with the VM. This screenshot was captured while creative, but the same happens when flying in survival. Waiting (floating) for a few minutes sooner or (often) later, lets the missing chunks appear. Usually takes 5-10 minutes.  When on a local game, the chunks appear slowly, but they do appear without pause.   This must be something simple, obvious, but I can't find the correct "search words" to find my way out. "Chunks not loading / rendering" didn't help. Browsing several forums neither. 
    • This is the Forge forums. We only support Forge here. Read the FAQ
    • 1.The game doesn't crash, everything seems normal, but when i insert the designated items into the block entity, the result item does not show up. 2.Yes, I'm using a custom menu, here's the source code:  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.