Jump to content

Recommended Posts

Posted

Hi, so I have a cannon which works perfectly fine, reloading, firing all that jazz. However when I leave the game and join back, the cannon 'forgets' its direction. So I thought simple fix, ill just save the meta to the TileEntity ntb methods, so I did, but no avail. So in short, the cannons fires in a position according to its direction after re-opening the game it forgets that direction(meta) and defaults to -1 (tileentites default) which makes it not go through with the else-if statement, causing it not to spawn. Bad times.

 

Anyway, heres my code:

package arcticraft.tile_entities;

import net.minecraft.client.Minecraft;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import arcticraft.entities.AC_EntityCannonball;

public class AC_TileEntityCannon extends TileEntity
{
//private int this.blockMetadata = this.blockMetadata;
public boolean isLoaded;
private int fuse;

public AC_TileEntityCannon()
{

}

@Override
public void updateEntity()
{
System.out.println(this.blockMetadata);
if(isLoaded)
{
fuse++;
if(fuse == 100)
{
AC_EntityCannonball cannonball = new AC_EntityCannonball(worldObj, this.xCoord, this.yCoord, this.zCoord);
if(this.blockMetadata == 4)
{
cannonball.setPosition(this.xCoord, this.yCoord + 2, this.zCoord + 2);
cannonball.setVelocity(0, 2.0, 0.7);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 3)
{
cannonball.setPosition(this.xCoord + 1.5, this.yCoord + 2, this.zCoord - 1);
cannonball.setVelocity(0.625, 2.0, 0.025);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 2)
{
cannonball.setPosition(this.xCoord, this.yCoord + 2, this.zCoord - 1);
cannonball.setVelocity(0, 2.0, - 0.7);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 1)
{
cannonball.setPosition(this.xCoord - 1.5, this.yCoord + 2, this.zCoord + 1);
cannonball.setVelocity(- 0.625, 2.0, - 0.025);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
}
}
}

@Override
public void readFromNBT(NBTTagCompound compound)
{
compound.getBoolean("loaded");
compound.getInteger("fuse");
compound.getInteger("meta");
}

public void writeToNBT(NBTTagCompound compound)
{
compound.setBoolean("loaded", isLoaded);
compound.setInteger("fuse", fuse);
compound.setInteger("meta", this.blockMetadata);
}
}

 

On re-entering the game I see that the

System.out.println(this.blockMetadata)

varies between the real direction and -1. But when I first place the cannon its a sold printing of the actual direction.

 

 

*To the people who try get me to tidy my code by placing the spawning of the cannonball and resetting of the fuse and stuff by putting it at the end of the else-if statement. No, because I want it to spawn depending on that meta only, as the positions and velocity correspond to that direction*

 

Thanks ~ Ben

 

P.S Why does using code tags mess up the formatting of your code, its annoying.

Posted

What i think is happening, is that your tile entity is desynchronized between client and server.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

@Override
public void readFromNBT(NBTTagCompound compound)
{
super.readFromNBT(compound);
isLoaded=compound.getBoolean("loaded");
fuse=compound.getInteger("fuse");
blockMetadata=compound.getInteger("meta");
}

Would be better this way.

Posted
  On 9/7/2013 at 12:36 PM, GotoLink said:

@Override
public void readFromNBT(NBTTagCompound compound)
{
super.readFromNBT(compound);
isLoaded=compound.getBoolean("loaded");
fuse=compound.getInteger("fuse");
blockMetadata=compound.getInteger("meta");
}

Would be better this way.

 

Still does the same thing

 

  Quote

What i think is happening, is that your tile entity is desynchronized between client and server.

 

Metadata is client sided and it prints out client side

Posted

Don't use the blockMetadata in the TileEntity, and don't save it in NBT (Minecraft will do that for you). Use getBlockMetadata() instead. You can see in getBlockMetadata() why:

 /**
     * Returns block data at the location of this entity (client-only).
     */
    public int getBlockMetadata()
    {
        if (this.blockMetadata == -1)
        {
            this.blockMetadata = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        }

        return this.blockMetadata;
    }

blockMetadata is just a variable in the TileEntity which holds the metadata, and gets updated when you call getBlockMetadata().

It says in the MCP (?) description that it's client only, but as far as I can see it isn't (and I've used it on server side successfully as well).

 

If you want to set the metadata from your TileEntity use the good old worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, metadata, updateflags).

 

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted
  On 9/7/2013 at 3:44 PM, MineMaarten said:

Don't use the blockMetadata in the TileEntity, and don't save it in NBT (Minecraft will do that for you). Use getBlockMetadata() instead. You can see in getBlockMetadata() why:

 /**
     * Returns block data at the location of this entity (client-only).
     */
    public int getBlockMetadata()
    {
        if (this.blockMetadata == -1)
        {
            this.blockMetadata = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        }

        return this.blockMetadata;
    }

blockMetadata is just a variable in the TileEntity which holds the metadata, and gets updated when you call getBlockMetadata().

It says in the MCP (?) description that it's client only, but as far as I can see it isn't (and I've used it on server side successfully as well).

 

If you want to set the metadata from your TileEntity use the good old worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, metadata, updateflags).

 

 

I tried setting the metadata like that before i made this topic. However, using a combination of setting it and using getBlockMetadata() instead seemed to solve the problem. Thanks :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • inicie un mundo donde instale Croptopia y Farmer's Delight, entonces instale el addon Croptopia Delight pero no funciona. es la version 1.18.2
    • Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
    • sorry, I might be stupid, but how do I open it? because the only options I have are too X out, copy it, which doesn't work and send crash report, which doesn't show it to me, also, sorry for taking so long.
    • Can you reproduce this with version 55.0.21? A whole lot of plant placement issues were just fixed in this PR.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.