Jump to content

Recommended Posts

Posted

Hi, so I have a cannon which works perfectly fine, reloading, firing all that jazz. However when I leave the game and join back, the cannon 'forgets' its direction. So I thought simple fix, ill just save the meta to the TileEntity ntb methods, so I did, but no avail. So in short, the cannons fires in a position according to its direction after re-opening the game it forgets that direction(meta) and defaults to -1 (tileentites default) which makes it not go through with the else-if statement, causing it not to spawn. Bad times.

 

Anyway, heres my code:

package arcticraft.tile_entities;

import net.minecraft.client.Minecraft;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import arcticraft.entities.AC_EntityCannonball;

public class AC_TileEntityCannon extends TileEntity
{
//private int this.blockMetadata = this.blockMetadata;
public boolean isLoaded;
private int fuse;

public AC_TileEntityCannon()
{

}

@Override
public void updateEntity()
{
System.out.println(this.blockMetadata);
if(isLoaded)
{
fuse++;
if(fuse == 100)
{
AC_EntityCannonball cannonball = new AC_EntityCannonball(worldObj, this.xCoord, this.yCoord, this.zCoord);
if(this.blockMetadata == 4)
{
cannonball.setPosition(this.xCoord, this.yCoord + 2, this.zCoord + 2);
cannonball.setVelocity(0, 2.0, 0.7);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 3)
{
cannonball.setPosition(this.xCoord + 1.5, this.yCoord + 2, this.zCoord - 1);
cannonball.setVelocity(0.625, 2.0, 0.025);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 2)
{
cannonball.setPosition(this.xCoord, this.yCoord + 2, this.zCoord - 1);
cannonball.setVelocity(0, 2.0, - 0.7);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 1)
{
cannonball.setPosition(this.xCoord - 1.5, this.yCoord + 2, this.zCoord + 1);
cannonball.setVelocity(- 0.625, 2.0, - 0.025);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
}
}
}

@Override
public void readFromNBT(NBTTagCompound compound)
{
compound.getBoolean("loaded");
compound.getInteger("fuse");
compound.getInteger("meta");
}

public void writeToNBT(NBTTagCompound compound)
{
compound.setBoolean("loaded", isLoaded);
compound.setInteger("fuse", fuse);
compound.setInteger("meta", this.blockMetadata);
}
}

 

On re-entering the game I see that the

System.out.println(this.blockMetadata)

varies between the real direction and -1. But when I first place the cannon its a sold printing of the actual direction.

 

 

*To the people who try get me to tidy my code by placing the spawning of the cannonball and resetting of the fuse and stuff by putting it at the end of the else-if statement. No, because I want it to spawn depending on that meta only, as the positions and velocity correspond to that direction*

 

Thanks ~ Ben

 

P.S Why does using code tags mess up the formatting of your code, its annoying.

Posted

What i think is happening, is that your tile entity is desynchronized between client and server.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

@Override
public void readFromNBT(NBTTagCompound compound)
{
super.readFromNBT(compound);
isLoaded=compound.getBoolean("loaded");
fuse=compound.getInteger("fuse");
blockMetadata=compound.getInteger("meta");
}

Would be better this way.

Posted
  On 9/7/2013 at 12:36 PM, GotoLink said:

@Override
public void readFromNBT(NBTTagCompound compound)
{
super.readFromNBT(compound);
isLoaded=compound.getBoolean("loaded");
fuse=compound.getInteger("fuse");
blockMetadata=compound.getInteger("meta");
}

Would be better this way.

 

Still does the same thing

 

  Quote

What i think is happening, is that your tile entity is desynchronized between client and server.

 

Metadata is client sided and it prints out client side

Posted

Don't use the blockMetadata in the TileEntity, and don't save it in NBT (Minecraft will do that for you). Use getBlockMetadata() instead. You can see in getBlockMetadata() why:

 /**
     * Returns block data at the location of this entity (client-only).
     */
    public int getBlockMetadata()
    {
        if (this.blockMetadata == -1)
        {
            this.blockMetadata = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        }

        return this.blockMetadata;
    }

blockMetadata is just a variable in the TileEntity which holds the metadata, and gets updated when you call getBlockMetadata().

It says in the MCP (?) description that it's client only, but as far as I can see it isn't (and I've used it on server side successfully as well).

 

If you want to set the metadata from your TileEntity use the good old worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, metadata, updateflags).

 

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Posted
  On 9/7/2013 at 3:44 PM, MineMaarten said:

Don't use the blockMetadata in the TileEntity, and don't save it in NBT (Minecraft will do that for you). Use getBlockMetadata() instead. You can see in getBlockMetadata() why:

 /**
     * Returns block data at the location of this entity (client-only).
     */
    public int getBlockMetadata()
    {
        if (this.blockMetadata == -1)
        {
            this.blockMetadata = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        }

        return this.blockMetadata;
    }

blockMetadata is just a variable in the TileEntity which holds the metadata, and gets updated when you call getBlockMetadata().

It says in the MCP (?) description that it's client only, but as far as I can see it isn't (and I've used it on server side successfully as well).

 

If you want to set the metadata from your TileEntity use the good old worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, metadata, updateflags).

 

 

I tried setting the metadata like that before i made this topic. However, using a combination of setting it and using getBlockMetadata() instead seemed to solve the problem. Thanks :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I have no idea what the flip is going on, I can load the modpack just fine at forge 42.2.0 but any forge version above it insta-crashes with exit code 1. Can somebody tell me what's going on, this is minecraft 1.20.1 Latest.log: https://pastebin.com/pBUL1ZFa
    • does anyone know how to incorporate custom noise settings into a custom dimension through the use of datagen, I have created a custon json file for the noise settings that I want but I just don't know how to get it to register with the generated json file of the custom dimension.   here is the code for the dimension class package net.hurst.lustria.worldgen.dimension; import com.mojang.datafixers.util.Pair; import net.hurst.lustria.Lustria; import net.hurst.lustria.worldgen.biome.ModBiomes; import net.hurst.lustria.worldgen.registries.LustriaNoiseSettings; import net.minecraft.core.HolderGetter; import net.minecraft.core.registries.Registries; import net.minecraft.data.worldgen.BootstapContext; import net.minecraft.resources.ResourceKey; import net.minecraft.resources.ResourceLocation; import net.minecraft.tags.BlockTags; import net.minecraft.util.valueproviders.ConstantInt; import net.minecraft.world.level.Level; import net.minecraft.world.level.biome.*; import net.minecraft.world.level.dimension.BuiltinDimensionTypes; import net.minecraft.world.level.dimension.DimensionType; import net.minecraft.world.level.dimension.LevelStem; import net.minecraft.world.level.levelgen.NoiseBasedChunkGenerator; import net.minecraft.world.level.levelgen.NoiseGeneratorSettings; import java.util.List; import java.util.OptionalLong; public class ModDimensions { public static final ResourceKey<LevelStem> LUSTRIA_KEY = ResourceKey.create(Registries.LEVEL_STEM, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<Level> LUSTRIA_LEVEL_KEY = ResourceKey.create(Registries.DIMENSION, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim")); public static final ResourceKey<DimensionType> LUSTRIA_DIM_TYPE = ResourceKey.create(Registries.DIMENSION_TYPE, ResourceLocation.fromNamespaceAndPath(Lustria.MOD_ID, "lustriadim_type")); public static void bootstrapType(BootstapContext<DimensionType> context) { context.register(LUSTRIA_DIM_TYPE, new DimensionType( OptionalLong.of(12000), // fixedTime false, // hasSkylight true, // hasCeiling false, // ultraWarm false, // natural 1.0, // coordinateScale true, // bedWorks false, // respawnAnchorWorks -64, // minY 256, // height 256, // logicalHeight BlockTags.INFINIBURN_OVERWORLD, // infiniburn BuiltinDimensionTypes.OVERWORLD_EFFECTS, // effectsLocation 0.0f, // ambientLight new DimensionType.MonsterSettings(false, false, ConstantInt.of(0), 0))); } public static void bootstrapStem(BootstapContext<LevelStem> context) { HolderGetter<Biome> biomeRegistry = context.lookup(Registries.BIOME); HolderGetter<DimensionType> dimTypes = context.lookup(Registries.DIMENSION_TYPE); HolderGetter<NoiseGeneratorSettings> noiseGenSettings = context.lookup(Registries.NOISE_SETTINGS); NoiseBasedChunkGenerator wrappedChunkGenerator = new NoiseBasedChunkGenerator( new FixedBiomeSource(biomeRegistry.getOrThrow(Biomes.BEACH)), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); NoiseBasedChunkGenerator noiseBasedChunkGenerator = new NoiseBasedChunkGenerator( MultiNoiseBiomeSource.createFromList( new Climate.ParameterList<>(List.of(Pair.of( Climate.parameters(0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BEACH)), Pair.of( Climate.parameters(0.1F, 0.2F, 0.0F, 0.2F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.BIRCH_FOREST)), Pair.of( Climate.parameters(0.3F, 0.6F, 0.1F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.OCEAN)), Pair.of( Climate.parameters(0.4F, 0.3F, 0.2F, 0.1F, 0.0F, 0.0F, 0.0F), biomeRegistry.getOrThrow(Biomes.DARK_FOREST)) ))), noiseGenSettings.getOrThrow(NoiseGeneratorSettings.CAVES)); LevelStem stem = new LevelStem(dimTypes.getOrThrow(ModDimensions.LUSTRIA_DIM_TYPE), noiseBasedChunkGenerator); context.register(LUSTRIA_KEY, stem); } } minecraft version is 1.20.1
    • Please read the FAQ (https://forums.minecraftforge.net/topic/125488-rules-and-frequently-asked-questions-faq/) and post logs as described there using a site like https://mclo.gs and post the link to it here. It may have the information required to solve your problem.  
    • the error code comes up when i trry to run it and ive tried to fix it but i cant  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.