Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

TileEntity bugging out metadata [Solved]

Lua

By Lua
in Modder Support

 Share

Recommended Posts

Lua Creeper Killer

Lua

Posted
Posted

Hi, so I have a cannon which works perfectly fine, reloading, firing all that jazz. However when I leave the game and join back, the cannon 'forgets' its direction. So I thought simple fix, ill just save the meta to the TileEntity ntb methods, so I did, but no avail. So in short, the cannons fires in a position according to its direction after re-opening the game it forgets that direction(meta) and defaults to -1 (tileentites default) which makes it not go through with the else-if statement, causing it not to spawn. Bad times.

 

Anyway, heres my code:

package arcticraft.tile_entities;

import net.minecraft.client.Minecraft;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.tileentity.TileEntity;
import arcticraft.entities.AC_EntityCannonball;

public class AC_TileEntityCannon extends TileEntity
{
//private int this.blockMetadata = this.blockMetadata;
public boolean isLoaded;
private int fuse;

public AC_TileEntityCannon()
{

}

@Override
public void updateEntity()
{
System.out.println(this.blockMetadata);
if(isLoaded)
{
fuse++;
if(fuse == 100)
{
AC_EntityCannonball cannonball = new AC_EntityCannonball(worldObj, this.xCoord, this.yCoord, this.zCoord);
if(this.blockMetadata == 4)
{
cannonball.setPosition(this.xCoord, this.yCoord + 2, this.zCoord + 2);
cannonball.setVelocity(0, 2.0, 0.7);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 3)
{
cannonball.setPosition(this.xCoord + 1.5, this.yCoord + 2, this.zCoord - 1);
cannonball.setVelocity(0.625, 2.0, 0.025);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 2)
{
cannonball.setPosition(this.xCoord, this.yCoord + 2, this.zCoord - 1);
cannonball.setVelocity(0, 2.0, - 0.7);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
else if(this.blockMetadata == 1)
{
cannonball.setPosition(this.xCoord - 1.5, this.yCoord + 2, this.zCoord + 1);
cannonball.setVelocity(- 0.625, 2.0, - 0.025);
Minecraft.getMinecraft().sndManager.playSoundFX("ac:misc.cannon", 1.5F, 1.5F);
worldObj.spawnEntityInWorld(cannonball);
isLoaded = false;
fuse = 0;
}
}
}
}

@Override
public void readFromNBT(NBTTagCompound compound)
{
compound.getBoolean("loaded");
compound.getInteger("fuse");
compound.getInteger("meta");
}

public void writeToNBT(NBTTagCompound compound)
{
compound.setBoolean("loaded", isLoaded);
compound.setInteger("fuse", fuse);
compound.setInteger("meta", this.blockMetadata);
}
}

 

On re-entering the game I see that the 

System.out.println(this.blockMetadata)

varies between the real direction and -1. But when I first place the cannon its a sold printing of the actual direction.

 

 

*To the people who try get me to tidy my code by placing the spawning of the cannonball and resetting of the fuse and stuff by putting it at the end of the else-if statement. No, because I want it to spawn depending on that meta only, as the positions and velocity correspond to that direction*

 

Thanks ~ Ben

 

P.S Why does using code tags mess up the formatting of your code, its annoying.

larsgerrits Reality Controller

larsgerrits

Posted
Posted

What i think is happening, is that your tile entity is desynchronized between client and server.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

GotoLink World Shaper

GotoLink

Posted
Posted 

@Override
public void readFromNBT(NBTTagCompound compound)
{
super.readFromNBT(compound);
isLoaded=compound.getBoolean("loaded");
fuse=compound.getInteger("fuse");
blockMetadata=compound.getInteger("meta");
}

Would be better this way.

Lua Creeper Killer

Lua

Posted
  • Author
Posted 

@Override
public void readFromNBT(NBTTagCompound compound)
{
super.readFromNBT(compound);
isLoaded=compound.getBoolean("loaded");
fuse=compound.getInteger("fuse");
blockMetadata=compound.getInteger("meta");
}

Would be better this way.

 

Still does the same thing

 

What i think is happening, is that your tile entity is desynchronized between client and server.

 

Metadata is client sided and it prints out client side

MineMaarten Creeper Killer

MineMaarten

Posted
Posted

Don't use the blockMetadata in the TileEntity, and don't save it in NBT (Minecraft will do that for you). Use getBlockMetadata() instead. You can see in getBlockMetadata() why:

 /**
     * Returns block data at the location of this entity (client-only).
     */
    public int getBlockMetadata()
    {
        if (this.blockMetadata == -1)
        {
            this.blockMetadata = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        }

        return this.blockMetadata;
    }

blockMetadata is just a variable in the TileEntity which holds the metadata, and gets updated when you call getBlockMetadata().

It says in the MCP (?) description that it's client only, but as far as I can see it isn't (and I've used it on server side successfully as well).

 

If you want to set the metadata from your TileEntity use the good old worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, metadata, updateflags).

 

Author of PneumaticCraft, MineChess, Minesweeper Mod and Sokoban Mod. Visit www.minemaarten.com to take a look at them.

Lua Creeper Killer

Lua

Posted
  • Author
Posted

Don't use the blockMetadata in the TileEntity, and don't save it in NBT (Minecraft will do that for you). Use getBlockMetadata() instead. You can see in getBlockMetadata() why:

 /**
     * Returns block data at the location of this entity (client-only).
     */
    public int getBlockMetadata()
    {
        if (this.blockMetadata == -1)
        {
            this.blockMetadata = this.worldObj.getBlockMetadata(this.xCoord, this.yCoord, this.zCoord);
        }

        return this.blockMetadata;
    }

blockMetadata is just a variable in the TileEntity which holds the metadata, and gets updated when you call getBlockMetadata().

It says in the MCP (?) description that it's client only, but as far as I can see it isn't (and I've used it on server side successfully as well).

 

If you want to set the metadata from your TileEntity use the good old worldObj.setBlockMetadataWithNotify(xCoord, yCoord, zCoord, metadata, updateflags).

 

 

I tried setting the metadata like that before i made this topic. However, using a combination of setting it and using getBlockMetadata() instead seemed to solve the problem. Thanks :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • vals_kenway
      Problem Sync Client-server for Entity Mount

      By vals_kenway · Posted

      Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • TileEntity
      Trying to play any world is stuck on 100% loading and shuts down computer

      By TileEntity · Posted

      Also make a test without EMF (Entity Model Features)
    • TileEntity
      Server Keeps Crashing When I Press E in Creative only

      By TileEntity · Posted

      Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • TileEntity
      Duplicate mod issue on modpack startup

      By TileEntity · Posted

      Keep on this thread:  
    • TileEntity
      Duplicate mod issue on modpack startup

      By TileEntity · Posted

      Remove rubidium - you are already using embeddium, which is a fork of rubidium

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept