Jump to content

[SOLVED] Help with a custom macerator-like tile entity machine


Recommended Posts

Posted

I am trying to add a machine that functions similarly to the macerator found in Industrial-Craft 2. I have done most of the work myself so far, but my updateTick logic is buggy and messy, leading to the following problems:

 

  • Removing the stack from the input slot causes a crash when the recipe time ticks down to zero.
  • Removing the stack from the output slot causes a "ghost item" to appear in the output slot when the recipe time ticks down again, and the player can remove it but attempting to combine it with another stack of the same kind just makes the game realize it doesn't actually exist. Also, throwing the ghost on the ground will crash the game.
  • The output stack's size does not increase correctly. (Increasing it with a constant just results in it not increasing at all, increasing it with the recipe value doubles the size for no apparent reason (I am adding, not multiplying them.))
  • Attempting to place an item in the input slot that is not in a registered recipe as a valid input item will delete the item.

 

Obviously I could just copy the vanilla furnace's updateTick and modify it, but I would rather figure it out mostly on my own.

 

Related code files:

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/tileentity/TileEntityGrinder.java

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/block/BlockGrinder.java

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/api/GrinderRecipe.java

https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/core/CraftingRecipes.java

 

The rest of the code is in the repository, of course.

 

Thanks in advance for any help.

Posted

That was an automatically generated method when I implemented the power interfaces. I don't think it has affected my problems though.

By the way, I figured the rest of the issues out by myself so thanks anyway. The problem was that I was setting the stack to the recipe's stack. I added .copy() to the end and it works fine. At the moment I am finishing it up so it doesn't consume input when the output stacks are full.

 

EDIT: I forgot about the item disappearing if it isn't in a recipe. That still isn't fixed. I could either forget trying to limit it to recipe items or take the extra time to fix that.

Posted

code file: https://github.com/myoKun345/ElementalExperimentation/blob/master/elex_common/elex/tileentity/TileEntityGrinder.java

line: 122

if (GrinderRecipe.canBeDone(getStackInSlot(0)) && this.grinding == false) {
                        
                        recipe = GrinderRecipe.grinderRecipes.get(getStackInSlot(0).getUnlocalizedName());
                        
                        this.grinderGrindTime = recipe.time;
                        this.grinding = true;
                        
                    }

try change to

if (GrinderRecipe.canBeDone(getStackInSlot(0)) && this.grinding == false) {
                        
                        recipe = GrinderRecipe.grinderRecipes.get(getStackInSlot(0).getUnlocalizedName());
                        
                        this.grinderGrindTime = recipe.time;
                        this.grinding = true;
                        
                    } else if (this.grinding == false) return;

 

edit: p.s. if that will not work,somting wrong in you RecipeGrinder

Posted

Then somting wrong with you GrinderRecipe(didnt see it first time)

edit:maybe you will try what i send? and if you want to make free-bug macerator watch furnace code and just edit it,its the best way.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
    • Crashes the server when trying to start. Error code -1. Log  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.