firstly i though id start a new topic because my old thread has gone off on a rather large tangent.

second, i know absolutely nothing about NBT's i only started looking at them about 30 mins ago so please be patient and forgive stupid errors

 

what i am trying to do is make a sword which when it hits a zombie, recognises this and +1 to dmg of the sword to zombies. i tried to do this with

 

package CriticalStrike.common;

import net.minecraft.entity.Entity;
import net.minecraft.entity.monster.EntityZombie;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.util.EntityDamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingHurtEvent;

public class MobDrops {

int Zombie = 0;
   
    @ForgeSubscribe
    public void onEntityAttacked(LivingHurtEvent event) {
    	
    	if (!(event.source instanceof EntityDamageSource))
	{return;}
    	
    	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{return;}

    	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();



            if (event.source.getDamageType().equals("player")) {
            if (!(weapon == null)){
            if (weapon.getItem() instanceof ImmortalAdaptingBlade){
            if (event.entityLiving instanceof EntityZombie) {
            	 Zombie =+ 1;
            	 event.ammount =+ Zombie;
            	
            }}}}
            
            }
    }

 

The result was that the sword only did 1 dmg. i wanted it to do 1 + 1 + 1 + 1 + 1 ...etc

They suggested NBTTagCompound, so here is my effort at that, the problem is that it still seems to do only one dmg not matter how many times i hit a zombie,

 

SwordCode

package CriticalStrike.common;

import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.EnumToolMaterial;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.world.World;
import net.minecraft.potion.Potion;
import net.minecraft.potion.PotionEffect;
import net.minecraft.nbt.*;

public class ImmortalAdaptingBlade extends ItemSword{


public ImmortalAdaptingBlade(int ItemID, EnumToolMaterial Steel){
	super(ItemID, Steel);
}

public void onCreated(ItemStack par1ItemStack, World par2World, EntityPlayer par3EntityPlayer) {
        if( par1ItemStack.stackTagCompound == null )
                par1ItemStack.setTagCompound( new NBTTagCompound( ) );

        int i = 0;
        par1ItemStack.stackTagCompound.setInteger( "Zombie", i );
}

  @Override
  public void registerIcons(IconRegister reg){
          this.itemIcon = reg.registerIcon("criticalstrike:MythicalEmpoweringSword");
  }} 

 

eventClass

 

package CriticalStrike.common;

import java.awt.List;

import net.minecraft.entity.Entity;
import net.minecraft.entity.monster.EntityZombie;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.EntityDamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingHurtEvent;

public class AdaptingBladeEvent {

private int zz;

public void addInformation(ItemStack par1ItemStack, EntityPlayer par2EntityPlayer, List par3List, boolean par4) {
        if( par1ItemStack.stackTagCompound == null )
                par1ItemStack.setTagCompound( new NBTTagCompound( ) );

      
        zz = par1ItemStack.stackTagCompound.getInteger( "Zombie" );
}

    @ForgeSubscribe
    public void onEntityAttacked(LivingHurtEvent event) {
    	
    	if (!(event.source instanceof EntityDamageSource))
	{return;}
    	
    	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{return;}

    	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();

            if (event.source.getDamageType().equals("player")) {
            if (!(weapon == null)){
            if (weapon.getItem() instanceof ImmortalAdaptingBlade){
            if (event.entityLiving instanceof EntityZombie) {
            	 zz =+ 1;
            	 event.ammount =+ zz;
            	
            }}}}
            
            }
    }

 

i summery, i want a sword that stacks +1 dmg every time i hit a zombie, only a zombie mind.

 

All help/suggestions/constructive criticism is great, Thanks

How are you going to use that addInformation method ? 

 

Anyway, here is how I would do it:

 

//Inside of the event
if (weapon.getItem() instanceof ImmortalAdaptingBlade){
            if (event.entityLiving instanceof EntityZombie) {
int dmg = 0;
            	 if(weapon.hasTagCompound && weapon.stackTagCompound.hasKey("Zombie")
{
dmg = weapon.getTagCompound.getShort("Zombie");
}
else
{
NBTTagCompound tag = new NBTTagCompound();
tag.setShort("Zombie", 0);
weapon.setTagCompoung(tag);
}
            	 event.ammount =+ dmg;
            	weapon.getTagCompound.setShort("Zombie",dmg+1);
            }}

did you write this in eclipse? or free hand?

because when i put the code into the event i got a tonne of errors did i do somthing wrong?

anyway can you verify that the changes i made to get rid of errors still do the same things?

and there are two related errors i cant seem to get rid of under  tag.setShort("Zombie", 0); &  weapon.stackTagCompound.setShort("Zombie",dmg+1);

the error is "The method setShort(String, short) in the type NBTTagCompound is not applicable for the arguments (String, int)"

 

package CriticalStrike.common;

import java.awt.List;

import net.minecraft.entity.Entity;
import net.minecraft.entity.monster.EntityZombie;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.EntityDamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingHurtEvent;

public class AdaptingBladeEvent {

    @ForgeSubscribe
    public void onEntityAttacked(LivingHurtEvent event) {
    	
    	if (!(event.source instanceof EntityDamageSource))
	{return;}
    	
    	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{return;}

    	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();

            if (event.source.getDamageType().equals("player")) {
            if (!(weapon == null)){
            	if (weapon.getItem() instanceof ImmortalAdaptingBlade){
                    if (event.entityLiving instanceof EntityZombie) {
        int dmg = 0;
                    if(weapon.hasTagCompound() && weapon.stackTagCompound.hasKey("Zombie"))
        {
        dmg = weapon.stackTagCompound.getShort("Zombie");
        }
        else
        {
        NBTTagCompound tag = new NBTTagCompound();
        tag.setShort("Zombie", 0);
        weapon.setTagCompound(tag);
        }
                    event.ammount =+ dmg;
                    weapon.stackTagCompound.setShort("Zombie",dmg+1);
            	
            }}}}
            
            }
    }

did you write this in eclipse? or free hand?

because when i put the code into the event i got a tonne of errors did i do somthing wrong?

anyway can you verify that the changes i made to get rid of errors still do the same things?

and there are two related errors i cant seem to get rid of under  tag.setShort("Zombie", 0); &  weapon.stackTagCompound.setShort("Zombie",dmg+1);

the error is "The method setShort(String, short) in the type NBTTagCompound is not applicable for the arguments (String, int)"

 

package CriticalStrike.common;

import java.awt.List;

import net.minecraft.entity.Entity;
import net.minecraft.entity.monster.EntityZombie;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.EntityDamageSource;
import net.minecraftforge.event.ForgeSubscribe;
import net.minecraftforge.event.entity.living.LivingHurtEvent;

public class AdaptingBladeEvent {

    @ForgeSubscribe
    public void onEntityAttacked(LivingHurtEvent event) {
    	
    	if (!(event.source instanceof EntityDamageSource))
	{return;}
    	
    	EntityDamageSource dmgSource = (EntityDamageSource) event.source;
	Entity ent = dmgSource.getEntity();

	if (!(ent instanceof EntityPlayer))
	{return;}

    	EntityPlayer player = (EntityPlayer) ent;
	ItemStack weapon = player.getCurrentEquippedItem();

            if (event.source.getDamageType().equals("player")) {
            if (!(weapon == null)){
            	if (weapon.getItem() instanceof ImmortalAdaptingBlade){
                    if (event.entityLiving instanceof EntityZombie) {
        int dmg = 0;
                    if(weapon.hasTagCompound() && weapon.stackTagCompound.hasKey("Zombie"))
        {
        dmg = weapon.stackTagCompound.getShort("Zombie");
        }
        else
        {
        NBTTagCompound tag = new NBTTagCompound();
        tag.setShort("Zombie", 0);
        weapon.setTagCompound(tag);
        }
                    event.ammount =+ dmg;
                    weapon.stackTagCompound.setShort("Zombie",dmg+1);
            	
            }}}}
            
            }
    }

try to change setShort&getShort to setInt&getInt OR OR OR OR change type of dmg to short,but idk will that help or no

edit: that will help

ok i have changed it to set int, i dont know if it will work, but it got rid of the errors. I always feel so dumb when i cant figure somthing out, come on here and you guys are like "oh right just..." and im like oh shit, ofc.

so now all ok with it? p.s. i can rewrite all you code,but if that what you have works,i will not

it does but im a pretty nooby coder so if you want to rewrite my code to make it better, go for it. Im pretty sure the more advaned guys on here look at at and cry somtimes

it does but im a pretty nooby coder so if you want to rewrite my code to make it better, go for it. Im pretty sure the more advaned guys on here look at at and cry somtimes

i was crying at all you code

if you want to rewrite all you code,then plz send it to me on skype,my skype is fhntv24.Beacos that will be a lot faster =) and i can teach you for somting,and i have very goon online so i can teach you amost all times

__________________________

              -Good fhntv24,that want to help noobs,beacos he was noob,and know,how is that,be a noob

 

<3

 

can i upload it to dropbox and just mail you a link?

also i dont have skype do you have steam?

&& i have a lvls, so coursework to do, and as i am at school i am internet limited, i am using a mobile hotspot atm

but i love to do this in my spare time along with dooootaaaaaaa

<3

 

can i upload it to dropbox and just mail you a link?

also i dont have skype do you have steam?

&& i have a lvls, so coursework to do, and as i am at school i am internet limited, i am using a mobile hotspot atm

but i love to do this in my spare time along with dooootaaaaaaa

heh then just send drop box link to me in PM.I have steam,but dont give it to anyone

Fair nough, i will send it once it uploaded

it may take some time as i am using the mobile internets.

one final question regarding this particular topic, how do i reset the Zombie value to zero?

nbt.setShort("Zombie",0)

I lied, if i had two tags, tow integers and i wanted to make sure the second was zero but i hadn't used it yet? because the code i have been graciously given courtesy of goto, checks the key then uses them. is there a way i can check all the tags i need earlier? then change them as i wish?

 

Or am i just being a dumbass and i don't even need to check them? as nbts are uniquely named can i just reference one and it will know what i am talking about?

nvm just had a good plan

i lied

 

Finished, thread closed.