Jump to content

1.19.3 Doing something during a specific block state


Recommended Posts

Posted

Hello I have a question. I want to create a simple block mechanic: make a sound when powered by redstone. I assigned the property "powered" to the block. I also created a system that manipulates its value accordingly. I managed to make that when a signal is detected, the sound is played. But how do I make it play in a loop until the signal is interrupted? Please note that when you rejoin the world, the activity is supposed to resume.

My existing code:

@Override
public void neighborChanged(BlockState blockState, Level level, BlockPos blockPos, Block block, BlockPos p_60513_, boolean p_60514_) {
    if (!level.isClientSide()) {
        if (blockState.getValue(POWERED) !=
            level.hasNeighborSignal(blockPos)) {
            BlockState cycledBlockState = blockState.cycle(POWERED);

            level.setBlock(blockPos, cycledBlockState, 2);

            if (cycledBlockState.getValue(POWERED))
                level.playSound(null, blockPos, MyMod.SOUND.get(),
                    SoundSource.BLOCKS, 2, 1); //This plays a single sound
        }
    }
}

 

Posted
  On 2/14/2023 at 3:28 PM, ChampionAsh5357 said:

You would probably need to make an entire ticking sound instance handler that you can set at some position to play the sound while on and stop when off.

Expand  

Thanks for answer! Is it possible to call some function for each block instance on world join? Then I could check the state of the block and possibly schedule a task to play the sound.

Posted

make the sound 20 ticks long and made the block tick every 20 until power goes off 

 

	    // ########## ########## ########## ##########
    public boolean turn_on(Postate postate, Entity entity) {
	        if (!postate.get_POWERED()) {
            Level warudo = postate.level();
            BlockPos pos = postate.get_blockpos();
	            postate.set_POWERED(true);
            postate.update_WATERLOGGED();
            postate.setBlock(2);
	            this.updateNeighbours(postate.getBlockState(), warudo, pos);
            warudo.gameEvent(entity, true ? GameEvent.BLOCK_ACTIVATE : GameEvent.BLOCK_DEACTIVATE, pos);
            update_neighbours(warudo, pos, true);
	 
	            //cause the block to tick in 20 
            postate.level().scheduleTick(pos, this, 20); 
	        }
        return false;
    }
	 
	    // ########## ########## ########## ##########
    public void tick(BlockState blkstate, ServerLevel serverlevel, BlockPos pos, RandomSource random) {
	        update_neighbours((Level) serverlevel, pos, false);
	        serverlevel.gameEvent((Entity) null, GameEvent.BLOCK_DEACTIVATE, pos);
        serverlevel.playSound((Player) null, pos.getX(), pos.getY(), pos.getZ(), SoundEvents.CROSSBOW_LOADING_END,
                SoundSource.PLAYERS, 1.0F, 1.0F);
	        if (blkstate.getValue(POWERED)) {
            serverlevel.setBlock(pos, blkstate.setValue(POWERED, Boolean.valueOf(false)), 3);
            // this.updateNeighbours(blkstate, serverlevel, pos);
            // this.playSound((Player)null, serverlevel, pos, false);
	        }
    }
	 
	

Posted
  On 2/14/2023 at 4:36 PM, Adixe said:

Is it possible to call some function for each block instance on world join?

Expand  

Sure, it depends on how you design the system. You would most likely need to send a packet so the sound is properly synced or don't care about the currently running sound and start it when the player joins.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.