(1.18.2) desync block entity information (CompoundTag)

[ElTotisPro50]

When I say information i mean strings, booleans, integers; saved in the block entity

I made a block entity that can teleport me to 8 different saved locations, but for some reason, the information that i put from the screen to the block entity synchronizes with other places block entities, if i place one, break it and place it again the information should remove, but it doesnt. And if i place 2 or more block entities and modify one of them, the other one modifies too, basically like an ender chest, they sync with each-other and that SHOULD NOT happen (Video: https://imgur.com/a/viFLTRy)

I spent days looking at the code and i cant find the bug lol

BTW: the code is not clean and obviously is bad written, but right now my priority is to solve this problem; later, i will clean the code

 

WarpPipeBlockEntity: https://pastebin.com/mGCNHwwm

TeleporterMenu: https://pastebin.com/ZdwJ8DvP

TeleporterScreen: https://pastebin.com/HELZBAqQ

TeleportCrystalItem: https://pastebin.com/8fD9wkdW

PacketSyncTeleporterPosToClient: https://pastebin.com/RNyY1miv

ModMessages: https://pastebin.com/Zw0ShuLs

[ChampionAsh5357]

Makes sense, all of your fields are static, so they would be shared across all instances.

[ElTotisPro50]

  On 2/20/2023 at 3:17 PM, ChampionAsh5357 said:

Makes sense, all of your fields are static, so they would be shared across all instances.

Expand  

I solved that, but now, I can't send information from screen to blockentity, it doesnt crash or anything, it just doesnt send what i need

TeleporterScreen: https://pastebin.com/Qbp4GKK0

WarpPipeBlockEntity: https://pastebin.com/s6dXa7EX

PacketSyncTeleporter2S: https://pastebin.com/u0S1jDx8

PacketSyncTeleporterPosToClient: https://pastebin.com/7A0Wccfc

[ChampionAsh5357]

  On 2/20/2023 at 3:20 PM, ElTotisPro50 said:

I solved that, but now, I can't send information from screen to blockentity, it doesnt crash or anything, it just doesnt send what i need

Expand  

Could you define doesn't send what you need? From what I'm looking at, all I can see is that you're trying to sync everything to the block entity client when creating the menu, which is an idea and should roughly work, but doesn't help me understand the issue. Additionally, I think breakpoints would be really helpful here so you can view what your own code is doing.

[ElTotisPro50]

  On 2/20/2023 at 3:25 PM, ChampionAsh5357 said:

Could you define doesn't send what you need? From what I'm looking at, all I can see is that you're trying to sync everything to the block entity client when creating the menu, which is an idea and should roughly work, but doesn't help me understand the issue. Additionally, I think breakpoints would be really helpful here so you can view what your own code is doing.

Expand  

I still cant figure it out, im trying to pass the variables from the screen to the block entity, actually, if i pass the values without sending them to the server with a package, it works, but if i close the menu and open it again the information removes

public void savePos(int q) {
		ItemStack item = menu.getBlockEntity().getItemFromSlot(0);
		CompoundTag tag = item.getTag();
		if(tag != null && tag.contains("hasInfo")) {
			String name = (!item.hasCustomHoverName()) ? "" : TotisPlayerUtils.getItemDisplayName(item);
			//ModMessages.sendToServer(new PacketSyncTeleporter2S(q, tag.getInt("x"),tag.getInt("y"),tag.getInt("z"), q, true, tag.getString(Constants.DIMENSION), name, menu.getBlockEntity().getBlockPos()));
			menu.getBlockEntity().setPosX(tag.getInt("x"), q);
			menu.getBlockEntity().setPosY(tag.getInt("y"), q);
			menu.getBlockEntity().setPosZ(tag.getInt("z"), q);
			menu.getBlockEntity().setSelectedWheelPart(q);
			menu.getBlockEntity().setDestName(q,name);
			menu.getBlockEntity().setDestExists(q,true);
			menu.getBlockEntity().setDestDimension(q,tag.getString(Constants.DIMENSION));
			player.sendMessage(new TextComponent("Saved position in space "+q), player.getUUID());
        }
}

 

[ChampionAsh5357]

  On 2/20/2023 at 6:10 PM, ElTotisPro50 said:

I still cant figure it out, im trying to pass the variables from the screen to the block entity, actually, if i pass the values without sending them to the server with a package, it works, but if i close the menu and open it again the information removes

Expand  

Are you sure the block entity on the client has the correct position? Additionally, you're reading the sent data to the server incorrectly. The order you write the bytes must be the order your read them.

[ElTotisPro50]

  On 2/20/2023 at 6:22 PM, ChampionAsh5357 said:

Are you sure the block entity on the client has the correct position? Additionally, you're reading the sent data to the server incorrectly. The order you write the bytes must be the order your read them.

Expand  

 

  On 2/20/2023 at 6:22 PM, ChampionAsh5357 said:

Are you sure the block entity on the client has the correct position?

Expand  

menu.getBlockEntity().getBlockPos() is the default method that gets the worldposition of the block entity, i checked just in case, and the position is correct: player.sendMessage(new TextComponent(menu.getBlockEntity().getBlockPos().getX()+","+menu.getBlockEntity().getBlockPos().getY()+","+menu.getBlockEntity().getBlockPos().getZ()), player.getUUID());

 

 

with "The order you write the bytes must be the order your read them." you mean i have to order the readers and writers in the constructor's order?

public PacketSyncTeleporter2S(
            int dest, int x,int y,int z, int selected, boolean exists, String dimension, String name, BlockPos pos) {
        this.blockPos = pos;
        this.exists = exists;
        this.name = name;
        this.dimension = dimension;
        this.dest = dest;
        this.x = x;
        this.y = y;
        this.z = z;
        this.selected = selected;
    }

//read
    public PacketSyncTeleporter2S(FriendlyByteBuf buf) {
        this.dimension = buf.readUtf();
        this.name = buf.readUtf();
        this.blockPos = buf.readBlockPos();
        this.x = buf.readInt();
        this.y = buf.readInt();
        this.z = buf.readInt();
        this.exists = buf.readBoolean();
        this.dest = buf.readInt();
        this.selected = buf.readInt();
    }

    //write
    public void toBytes(FriendlyByteBuf buf) {
        buf.writeInt(x);
        buf.writeInt(y);
        buf.writeInt(z);
        buf.writeInt(selected);
        buf.writeInt(dest);
        buf.writeUtf(dimension);
        buf.writeUtf(name);
        buf.writeBoolean(exists);
        buf.writeBlockPos(blockPos);
    }

 

[ChampionAsh5357]

  On 2/20/2023 at 6:33 PM, ElTotisPro50 said:

with "The order you write the bytes must be the order your read them." you mean i have to order the readers and writers in the constructor's order?

Expand  

The #toBytes method must write the bytes in the same order as PacketSyncTeleporter2S(FriendlyByteBuf) reads them. Otherwise, you are reading inaccurate data which could affect some of the results.