Jump to content

(1.18.2) desync block entity information (CompoundTag)


ElTotisPro50

Recommended Posts

When I say information i mean strings, booleans, integers; saved in the block entity

I made a block entity that can teleport me to 8 different saved locations, but for some reason, the information that i put from the screen to the block entity synchronizes with other places block entities, if i place one, break it and place it again the information should remove, but it doesnt. And if i place 2 or more block entities and modify one of them, the other one modifies too, basically like an ender chest, they sync with each-other and that SHOULD NOT happen (Video: https://imgur.com/a/viFLTRy)

I spent days looking at the code and i cant find the bug lol

BTW: the code is not clean and obviously is bad written, but right now my priority is to solve this problem; later, i will clean the code

 

WarpPipeBlockEntity: https://pastebin.com/mGCNHwwm

TeleporterMenu: https://pastebin.com/ZdwJ8DvP

TeleporterScreen: https://pastebin.com/HELZBAqQ

TeleportCrystalItem: https://pastebin.com/8fD9wkdW

PacketSyncTeleporterPosToClient: https://pastebin.com/RNyY1miv

ModMessages: https://pastebin.com/Zw0ShuLs

Link to comment
Share on other sites

Just now, ChampionAsh5357 said:

Makes sense, all of your fields are static, so they would be shared across all instances.

I solved that, but now, I can't send information from screen to blockentity, it doesnt crash or anything, it just doesnt send what i need

TeleporterScreen: https://pastebin.com/Qbp4GKK0

WarpPipeBlockEntity: https://pastebin.com/s6dXa7EX

PacketSyncTeleporter2S: https://pastebin.com/u0S1jDx8

PacketSyncTeleporterPosToClient: https://pastebin.com/7A0Wccfc

Link to comment
Share on other sites

1 minute ago, ElTotisPro50 said:

I solved that, but now, I can't send information from screen to blockentity, it doesnt crash or anything, it just doesnt send what i need

Could you define doesn't send what you need? From what I'm looking at, all I can see is that you're trying to sync everything to the block entity client when creating the menu, which is an idea and should roughly work, but doesn't help me understand the issue. Additionally, I think breakpoints would be really helpful here so you can view what your own code is doing.

Link to comment
Share on other sites

2 hours ago, ChampionAsh5357 said:

Could you define doesn't send what you need? From what I'm looking at, all I can see is that you're trying to sync everything to the block entity client when creating the menu, which is an idea and should roughly work, but doesn't help me understand the issue. Additionally, I think breakpoints would be really helpful here so you can view what your own code is doing.

I still cant figure it out, im trying to pass the variables from the screen to the block entity, actually, if i pass the values without sending them to the server with a package, it works, but if i close the menu and open it again the information removes

public void savePos(int q) {
		ItemStack item = menu.getBlockEntity().getItemFromSlot(0);
		CompoundTag tag = item.getTag();
		if(tag != null && tag.contains("hasInfo")) {
			String name = (!item.hasCustomHoverName()) ? "" : TotisPlayerUtils.getItemDisplayName(item);
			//ModMessages.sendToServer(new PacketSyncTeleporter2S(q, tag.getInt("x"),tag.getInt("y"),tag.getInt("z"), q, true, tag.getString(Constants.DIMENSION), name, menu.getBlockEntity().getBlockPos()));
			menu.getBlockEntity().setPosX(tag.getInt("x"), q);
			menu.getBlockEntity().setPosY(tag.getInt("y"), q);
			menu.getBlockEntity().setPosZ(tag.getInt("z"), q);
			menu.getBlockEntity().setSelectedWheelPart(q);
			menu.getBlockEntity().setDestName(q,name);
			menu.getBlockEntity().setDestExists(q,true);
			menu.getBlockEntity().setDestDimension(q,tag.getString(Constants.DIMENSION));
			player.sendMessage(new TextComponent("Saved position in space "+q), player.getUUID());
        }
}

 

Link to comment
Share on other sites

11 minutes ago, ElTotisPro50 said:

I still cant figure it out, im trying to pass the variables from the screen to the block entity, actually, if i pass the values without sending them to the server with a package, it works, but if i close the menu and open it again the information removes

Are you sure the block entity on the client has the correct position? Additionally, you're reading the sent data to the server incorrectly. The order you write the bytes must be the order your read them.

Link to comment
Share on other sites

1 minute ago, ChampionAsh5357 said:

Are you sure the block entity on the client has the correct position? Additionally, you're reading the sent data to the server incorrectly. The order you write the bytes must be the order your read them.

 

3 minutes ago, ChampionAsh5357 said:

Are you sure the block entity on the client has the correct position?

menu.getBlockEntity().getBlockPos() is the default method that gets the worldposition of the block entity, i checked just in case, and the position is correct: player.sendMessage(new TextComponent(menu.getBlockEntity().getBlockPos().getX()+","+menu.getBlockEntity().getBlockPos().getY()+","+menu.getBlockEntity().getBlockPos().getZ()), player.getUUID());

 

 

with "The order you write the bytes must be the order your read them." you mean i have to order the readers and writers in the constructor's order?

public PacketSyncTeleporter2S(
            int dest, int x,int y,int z, int selected, boolean exists, String dimension, String name, BlockPos pos) {
        this.blockPos = pos;
        this.exists = exists;
        this.name = name;
        this.dimension = dimension;
        this.dest = dest;
        this.x = x;
        this.y = y;
        this.z = z;
        this.selected = selected;
    }

//read
    public PacketSyncTeleporter2S(FriendlyByteBuf buf) {
        this.dimension = buf.readUtf();
        this.name = buf.readUtf();
        this.blockPos = buf.readBlockPos();
        this.x = buf.readInt();
        this.y = buf.readInt();
        this.z = buf.readInt();
        this.exists = buf.readBoolean();
        this.dest = buf.readInt();
        this.selected = buf.readInt();
    }

    //write
    public void toBytes(FriendlyByteBuf buf) {
        buf.writeInt(x);
        buf.writeInt(y);
        buf.writeInt(z);
        buf.writeInt(selected);
        buf.writeInt(dest);
        buf.writeUtf(dimension);
        buf.writeUtf(name);
        buf.writeBoolean(exists);
        buf.writeBlockPos(blockPos);
    }

 

Link to comment
Share on other sites

15 minutes ago, ElTotisPro50 said:

with "The order you write the bytes must be the order your read them." you mean i have to order the readers and writers in the constructor's order?

The #toBytes method must write the bytes in the same order as PacketSyncTeleporter2S(FriendlyByteBuf) reads them. Otherwise, you are reading inaccurate data which could affect some of the results.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I've had this problem for a long while now, and am just now remembering that Forge has a forum site. I feel dumb that I could've had this problem solved sooner. Though it is a problem I've only experienced as of 1.20(to my memory). Everything prior to that version worked fine up until I installed Forge 1.20. Anyway, I've tried some things including trying previous versions and (at the recommendation of others)taking my resource pack off. Paste.ee link lol Running Minecraft version 1.12 is the version of Forge that works without issues. I've deduced that this is because the overlay that loads the game and mods in future versions of Forge is not present, but this still doesn't solve my problem of how to fix the crashing of said future versions, or why it crashes in the first place. Yes, this happens even without mods. I'm not very good at messing with files, so here I am. Hopefully I did this right after looking at the FAQ.
    • it seems i can put back my mods in my mods folder one by one with their dependencies to get the config file, but when i put 2 or more it doesn't create it
    • Call+27732318372 $100‱-Authentic-Love Spells New York-London-Tokyo-Sydney-Toronto Visit website: https://www.strongspellcaster.us.com. For Rebinding Love Spells New York, Best love spells New York, Genuine love spells New York, Attraction love spells New York, Marriage spells New York, Divorce spells New York, Stop Cheating spells New York, Return Ex-Lover New York, Real Love spells New York, Bring back Ex Lover and Psychic Reader in USA. +27732318372 Are you currently seeing someone? Are you feeling that your lover’s love for is slowly diminishing? Are you looking for something that will instantly strengthen your relationship? Have you tried seeking help from various spell casters but failed because they only gave false hope? Are you hoping to win your lost lover back? Is your current relationship giving you so much misery? Do you want the man/girl of your dreams to find you alluring? Then you are at the right place because here you will find exactly what you have been searching for and that is the Return of Your Lost Love My name is Aadila. During the last 30 years, I have helped many people solve their relationship problems and financial difficulties with powerful Egyptian magic spells. All my clients had different problems, wishes, and goals. All situations involved various people, different spirits, and different souls and as the name goes I am truly a Lovespell Expert. Therefore it is very important that I get to know you, and your problem and gain profound insight into your situation. All my spell work is tailored to your specific needs because this is the only way you will receive your results, and your problems will be solved in a timely manner. You contacted me because you have a problem in your life, which you would like to solve through authentic spiritual means. I am here to assist you. While browsing my site, you will get to know me better, and this site will prepare you to make the right decision. website: https://www.strongspellcaster.us.com. Vodoo is an oral tradition practised by extended families that inherit familial spirits, along with the necessary devotional practices, from their elders. In the cities, local hierarchies of priestesses or priests (manbo and oungan), “children of the spirits” (ounsi), and ritual drummers (ountògi) comprise more formal “societies” or “congregations” (sosyete). In these congregations, knowledge is passed on through a ritual of initiation (kanzo) in which the body becomes the site of spiritual transformation. There is some regional difference in ritual practice across Haiti, and branches of the religion include Rada, Daome, Ibo, Nago, Dereal, Manding, Petwo, and Kongo. There is no centralized hierarchy, no single leader, and no official spokesperson, but various groups sometimes attempt to create such official structures. There are also secret societies, called Bizango or Sanpwèl, that perform a religio-juridical function. I have been having lots of questions from clients about our prices, As a voodoo Priest, it’s 100% forbidden to tax anyone for our services (It's a Taboo). We will only accept FREE WILL DONATIONS AFTER YOU HAVE SEEN RESULTS and not forgetting that every ritual has a list of items to use so all customers PROVIDE JUST THEIR ITEMS NEEDED FOR THEIR WORK Depending on their request!
    • Call +27732318372 $100‱ -Lottery Spells USA: Most Powerful Lottery Spells to Win the Mega Millions in New York. Visit website: https://www.strongspellcaster.us.com I'm William Jones  from the United States. I started playing lottery games 4 years ago and I have never won big. I went online to seek help on how I can win big in my lottery games and I saw some nice reviews about Prof Mama Khulusum who has made different people huge winners in their lottery games with her prayers. I gave it a try and I contacted Prof Mama Khulusum who told me how and what to do before I can become a big lotto winner and I accepted. 
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.