Jump to content

How do you add to a block class without breaking existing worlds?


Lycanus Darkbinder

Recommended Posts

I noticed while debugging and testing that if you add methods to a block's class and then load a world where blocks have already been placed, it will crash:

 

"error while ticking block"

 

I'm not talking about changing block IDs or anything crazy like that, simply adding a few new methods (no, not removing methods). How does one go about updating their mod or adding new features after it's been released to the public without breaking the worlds people have built?

 

I can't put my finger on it yet but sometimes I have to delete my test world or it simply crashes over and over after making changes. I assumed that as long as you weren't deleting methods then it would be fine.

Link to comment
Share on other sites

The worlds only store Block ID's and metadata, unless there are TE's involved :)

 

If you give us the crash logs and a more detailed description of what you are trying to do, then we should be better able to help you :)

 

 

edit: Are you replacing the block entierly or are you manipulating it's class file by ASM?

If you guys dont get it.. then well ya.. try harder...

Link to comment
Share on other sites

I don't have a crash log at the moment but if I get another I'll definitely post it.

 

I'm not using ASM but there are TileEntities involved. What I did was place a block to see if the TileEntity's fields were set properly, then I quit the game and added a couple new methods to the block's class file and I think one new method to the TileEntity.

 

When I started the world again it crashed instantly with that "error ticking block". I had to delete the world and recreate it.

 

I was under the impression that the TileEntity would still function because Minecraft doesn't save the actual TileEntity but rather it's fields. When you load your world it calls createNewTileEntity which returns a blank TileEntity that is then populated from readNBT(). This should allow you to add new features without breaking existing worlds.

Link to comment
Share on other sites

Well, it is likely that you tried to use or load data that didn't exist the first time you placed the block and saved it.

You would need to catch those cases and save some default value.

 

NBT returns zero on an attempt to retrieve a value for a key that has not been saved. None of the fields in my TileEntity would cause a crash with a value of zero. Worst case is the block would display the wrong texture or light value, or allow someone who is not the block's owner to interact with it.

Link to comment
Share on other sites

I was thinking about List, Map, Arrays or other data structure rather than a simple int.

 

Oh, I don't store anything that complex.

 

I only track the owner of the block (string) so not just anyone can fiddle with it as well as a few integers and floats. That's why I was surprised when it crashed after making a change.

 

More than likely I did something I shouldn't but I'll have to wait until next time because once I remade the world it stopped crashing. I'm certain it had to do with my TileEntity though because the offending class is the only one that makes use of it.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, Hi and I am making a forge 1.12.2 mod and also trying to get a custom model helmet item (I made a joker mask) and exported it to .json format and put it in the ~/namespace/models/item folder. Though, I'm struggling to get the item to render what I want it to be rendered like as I've positioned it in the 'head' window view in blockbench. How did you render out your model? I checked your code and it looks like no references to the actual model are being made. I'm new to this forge modding stuff (was a fabric modder) and I desperately need some help. Is there a way to standardly render out armor models made using blockbench? any methods that one can use? My model in JSON: ```json { "credit": "Made with Blockbench", "texture_size": [160, 160], "textures": { "0": "ydyrn:items/joker_mask_texture", "particle": "ydyrn:items/joker_mask_texture" }, "elements": [ { "from": [0, 0, 0], "to": [16, 16, 1], "faces": { "north": {"uv": [0, 1.7, 16, 14.2], "texture": "#0"}, "east": {"uv": [0, 4, 0.9, 5.6], "texture": "#0"}, "south": {"uv": [0, 5.8, 1.6, 7.4], "texture": "#0"}, "west": {"uv": [0, 1.9, 1.3, 3.5], "texture": "#0"}, "up": {"uv": [0, 3.4, 1.6, 4.2], "texture": "#0"}, "down": {"uv": [0, 9, 1.6, 9.7], "texture": "#0"} } }, { "from": [15.8, 11, 0.5], "to": [16.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } }, { "from": [0.2, 11, 14.6], "to": [15.8, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"} } }, { "from": [-0.2, 11, 0.5], "to": [0.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } } ], "display": { "thirdperson_righthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "thirdperson_lefthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "firstperson_righthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "firstperson_lefthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "ground": { "rotation": [40, 0, 0], "translation": [0, -2.5, 0], "scale": [0.5, 0.5, 0.5] }, "gui": { "rotation": [0, 180, 0] }, "head": { "translation": [0, 0, 0.25], "scale": [0.82773, 0.73594, 0.9] }, "fixed": { "translation": [0, 0, 8.75] } }, "groups": [ 0, { "name": "straps", "origin": [0, 0, 0], "color": 0, "children": [1, 2, 3] } ] } ```
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • In your config folder, delete the sophisticatedcore-common.toml file and test it again
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • I am getting an error message that my mods and my server are not on the same minecraft version when they clearly are. My server and my mods are on 1.20.1 and the error says that the server is 1.20 even though it's on forge 47.2.30.  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.