Jump to content
View in the app

A better way to browse. Learn more.

Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.

Featured Replies

Posted

Hi,

As the title states I'm trying to port a mod from 1.17.1 to 1.18.2. Haven't coded in a few years and I'm currently stuck with this final issue.

private boolean isTower(ServerLevel level, BlockPos pos) {
LOGGER.info("Checking for tower...");
StructureFeature<?> structure;
StructureStart structurePos;

for (String s : Arrays.asList("tower", "ice_tower", "jungle_tower", "derelict_tower", "derelict_grass_tower", "ocean_tower", "ocean_warm_tower")) {
structure = ForgeRegistries.STRUCTURE_FEATURES.getValue(ResourceLocation.tryParse(TOWERS_MODID + ":" + s));
if (structure == null) {
continue;
}
structurePos = level.structureFeatureManager().getStructureAt(pos, false, structure);
if (structurePos.isValid()) {
// Manhattan distance without Y coord
float f = (float) Math.abs(pos.getX() - structurePos.getLocatePos().getX());
float f1 = (float) Math.abs(pos.getZ() - structurePos.getLocatePos().getZ());
if (f + f1 <= 30) {
return true;
}
}
}

The error being "Expected 2 arguments but found 3" because of the code below.

structurePos = level.structureFeatureManager().getStructureAt(pos, false, structure);
if (structurePos.isValid()) {
// Manhattan distance without Y coord
float f = (float) Math.abs(pos.getX() - structurePos.getLocatePos().getX());
float f1 = (float) Math.abs(pos.getZ() - structurePos.getLocatePos().getZ());
if (f + f1 <= 30) {
return true;
}
}
Has anyone run into this or does anyone know what exactly to change in the code above in order to resolve the issue?
I already looked into the changes between https://nekoyue.github.io/ForgeJavaDocs-NG/javadoc/1.17.1/net/minecraft/world/level/levelgen/structure/StructureStart.html and https://nekoyue.github.io/ForgeJavaDocs-NG/javadoc/1.18.2/net/minecraft/world/level/levelgen/structure/StructureStart.html but I haven't been able to figure it out.

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

Important Information

By using this site, you agree to our Terms of Use.

Configure browser push notifications

Chrome (Android)
  1. Tap the lock icon next to the address bar.
  2. Tap Permissions → Notifications.
  3. Adjust your preference.
Chrome (Desktop)
  1. Click the padlock icon in the address bar.
  2. Select Site settings.
  3. Find Notifications and adjust your preference.