Jump to content

[SOLVED] 1.19.2 MySQL Query in parallel Thread and MultiThread in Maincraft


Recommended Posts

Posted (edited)

Hi guys, my Java is BAD, and my English is verry BAD... Therefore, what I will write may not be clear, but I really ask you to try to figure it out and help me if someone knows an alternative or has already done something like this.

 

I am having the following problem with my mod:

There is a game store in the mod, how is it? Its alpha version, which will be improved from the current state... And this store is working properly... But, when buying from the store, the entire server stops at the moment the item is received from the store. The reason for this is one thread (Main Thread).

Now the purchase code works like this:

1) By pressing the key, GUI opens, information from the player's balance database is loaded into the GUI;

2) When you click on the purchase button, a packet is sent to the server with information that the player pressed the button

3) The server, having received the packet, makes a request to the database with a balance check. If the balance allows, the server issues the item to the player, makes a database query, writing the new balance.

I noticed that at the time of requests to the database, the server just sleeps. It stops generating ticks until it receives a response from the database. If you spam multiple clicks on the button, then you can observe a complete stop of the world, at the time of loading requests to the database. As far as I realized myself in Java, I understand that the reason for all this is: the sequence of code execution in the main thread, all operations are performed strictly in order ...

So, in order to fix this, based on my knowledge, I assume that you need to move database queries to a separate thread ... What is a thread and how to create it, I know a little, but very little. Of course, I will pump my knowledge in this direction.

 

But I would like to know from you:

1) Where should the new thread be written?

2) Safe syntax for opening a stream, and in which part of the code

3) Methods for transferring information from the second stream to the main one

 

I will be glad if you at least point to actual examples on the github in which this is practiced. 

Due to my limited knowledge of languages, I experience some difficulties in finding information. I will be glad for any help

GitHub

Edited by andreybadrey
  • andreybadrey changed the title to [SOLVED] 1.19.2 MySQL Query in parallel Thread and MultiThread in Maincraft
Posted

In general, as always, I independently found a solution

in fact, the topic of multithreading turned out to be very simple to understand and apply in minecraft

The point is to output each server action to a separate thread, of course, where possible and safe

For those who are interested, I am attaching my first multithread model

GITHUB

On the example of using packages, I brought each server action to a separate thread through a class with inheritance of the Thread class

class MyThread extends Thread { 

 

   @Override
   public void run() {

         any code

    }

}

Having trouble defining NetworkEvent.Context.  To define it and pass it to a new thread, I defined a static object in the package class


public class ByeAppleC2SPacket {
    public static NetworkEvent.Context val;
    public ByeAppleC2SPacket() {}

}

define a variable(object) val in the handler method and Starting the second thread

public boolean handle(Supplier<NetworkEvent.Context> supplier) {
   NetworkEvent.Context context = supplier.get();
   context.enqueueWork(() -> {
   val = context;
   MyThread myThread = new MyThread();
   myThread.start();
   });

  return true;
}

Now in a new thread, we can perform actions on the player through ByeAppleC2SPacket.val.getSender()

Also in the stream method run() we can start new threads

as a result, after performing each action in a new thread, we give a minimum drawdown on the TPS server and speed up the mod tenfold

Before using this model, the code provided in the github gave a huge drawdown of the TPS, and caused the server to crash. Now when spamming at 10 packets per second, and with three operations per packet: Request balance, give an item, update the balance. All operations are parallelized into separate threads, and do not slow down the server

Use this if you are interested ... I will ask experienced developers for feedback ...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.