1.19.2 Custom Player Data Not Saving On EntityJoinLevelEvent

[ChubbyUnicorn]

Hello everyone! I have been working on a mod that gives each player a limited amount of lives to start with. I am able to set the lives when the player first joins the world to 3. However, once the player dies and they respawn, the lives are set to 0. They should be kept at 3 since I still have not added any code to reduce lives. I believe the lives are being reset to the default value which is 0 whenever the player entity joins the world which includes even after respawning. I am trying to make sure the lives transfer correctly even after death. I have been stuck on this issue for days! Any help would be greatly appreciated!

 

Code--------------------------------------------------------------------------------------------------

 

ModEvent Class:

package net.roberto.chubbyuhc.events;

import net.minecraft.nbt.CompoundTag;
import net.minecraft.network.chat.Component;
import net.minecraft.resources.ResourceLocation;
import net.minecraft.server.level.ServerPlayer;
import net.minecraft.world.entity.Entity;
import net.minecraft.world.entity.player.Player;
import net.minecraft.world.level.Level;
import net.minecraftforge.api.distmarker.Dist;
import net.minecraftforge.client.event.RegisterGuiOverlaysEvent;
import net.minecraftforge.client.event.RenderGuiOverlayEvent;
import net.minecraftforge.common.capabilities.RegisterCapabilitiesEvent;
import net.minecraftforge.event.AttachCapabilitiesEvent;
import net.minecraftforge.event.TickEvent;
import net.minecraftforge.event.entity.EntityJoinLevelEvent;
import net.minecraftforge.event.entity.living.LivingDeathEvent;
import net.minecraftforge.event.entity.player.PlayerEvent;
import net.minecraftforge.eventbus.api.SubscribeEvent;
import net.minecraftforge.fml.LogicalSide;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.util.thread.EffectiveSide;
import net.roberto.chubbyuhc.ChubbyUHC;
import net.roberto.chubbyuhc.client.ClientLivesData;
import net.roberto.chubbyuhc.client.LivesHudOverlay;
import net.roberto.chubbyuhc.functions.PlayerFunctions;
import net.roberto.chubbyuhc.joinstatus.PlayerJoinStatus;
import net.roberto.chubbyuhc.joinstatus.PlayerJoinStatusProvider;
import net.roberto.chubbyuhc.lives.PlayerLives;
import net.roberto.chubbyuhc.lives.PlayerLivesProvider;
import net.roberto.chubbyuhc.networking.ModMessages;
import net.roberto.chubbyuhc.networking.packet.ChubbyUHCC2SPacket;
import net.roberto.chubbyuhc.networking.packet.LivesDataSyncS2CPacket;

import java.awt.font.FontRenderContext;
import java.awt.image.renderable.RenderContext;
import java.lang.ref.Reference;

@Mod.EventBusSubscriber(modid = ChubbyUHC.MOD_ID)
public class ModEvents {
    @SubscribeEvent
    public static void onAttachCapabilitiesPlayer(AttachCapabilitiesEvent<Entity> event){
        if(event.getObject() instanceof Player player){
            if(!event.getObject().getCapability(PlayerLivesProvider.PLAYER_LIVES).isPresent()){
                event.addCapability(new ResourceLocation(ChubbyUHC.MOD_ID, "properties"), new PlayerLivesProvider());
            }
            if(!event.getObject().getCapability(PlayerJoinStatusProvider.PLAYER_JOIN_STATUS).isPresent()){
                event.addCapability(new ResourceLocation(ChubbyUHC.MOD_ID, "status"), new PlayerJoinStatusProvider());
            }
        }
    }

    //For Lives
    @SubscribeEvent
    public void onPlayerCloned(PlayerEvent.Clone event){
        if(event.isWasDeath()){
            event.getOriginal().getCapability(PlayerLivesProvider.PLAYER_LIVES).ifPresent(oldStore ->{
                event.getOriginal().getCapability(PlayerLivesProvider.PLAYER_LIVES).ifPresent(newStore ->{
                    newStore.copyFrom(oldStore);
                });
            });
            event.getOriginal().getCapability(PlayerJoinStatusProvider.PLAYER_JOIN_STATUS).ifPresent(oldStore ->{
                event.getOriginal().getCapability(PlayerJoinStatusProvider.PLAYER_JOIN_STATUS).ifPresent(newStore ->{
                    newStore.copyFrom(oldStore);
                });
            });
        }
    }


    @SubscribeEvent
    public static void onRegisterCapabilities(RegisterCapabilitiesEvent event){
        event.register(PlayerLives.class);
    }

    /*
    @SubscribeEvent
    public static void onPlayerDeath(LivingDeathEvent event){
            event.getEntity().getCapability(PlayerLivesProvider.PLAYER_LIVES).ifPresent(lives ->{
                if(event.getEntity() instanceof ServerPlayer player) {
                    ModMessages.sendToPlayer(new LivesDataSyncS2CPacket(lives.getLives()), player);
                    //lives.subLives(1);
                    //ModMessages.sendToServer(new ChubbyUHCC2SPacket());
                    player.sendSystemMessage(Component.literal("CURRENT LIVES: " + lives.getLives()));
                }
                //lives.subLives(1);
            });
    }

     */

@SubscribeEvent
    public static void onPlayerJoinWorld(EntityJoinLevelEvent event) {
    if (!event.getLevel().isClientSide()) {

        if (!(event.getEntity() instanceof Player)) {
            return;
        }
        event.getEntity().getCapability(PlayerLivesProvider.PLAYER_LIVES).ifPresent(lives ->{

            if(event.getEntity() instanceof ServerPlayer player) {

                if(PlayerFunctions.isJoiningWorldForTheFirstTime(player,ChubbyUHC.MOD_ID)){
                    lives.addLives(3);
                    ModMessages.sendToPlayer(new LivesDataSyncS2CPacket(lives.getLives()), player);
                }

                          ModMessages.sendToPlayer(new LivesDataSyncS2CPacket(lives.getLives()), player);
                          player.sendSystemMessage(Component.literal("Lives-> " + lives.getLives()));
            }
        });
    }

}

}

LivesDataSyncS2CPacket

package net.roberto.chubbyuhc.networking.packet;

import net.minecraft.ChatFormatting;
import net.minecraft.network.FriendlyByteBuf;
import net.minecraft.network.chat.Component;
import net.minecraft.server.level.ServerLevel;
import net.minecraft.server.level.ServerPlayer;
import net.minecraftforge.network.NetworkEvent;
import net.roberto.chubbyuhc.client.ClientLivesData;
import net.roberto.chubbyuhc.lives.PlayerLivesProvider;

import java.util.function.Supplier;

public class LivesDataSyncS2CPacket {
    private final int lives;

    public LivesDataSyncS2CPacket(int lives){
        this.lives = lives;
    }

    public LivesDataSyncS2CPacket(FriendlyByteBuf buf){
        this.lives = buf.readInt();
    }

    public void toBytes(FriendlyByteBuf buf){
        buf.writeInt(lives);
    }

    public boolean handle(Supplier<NetworkEvent.Context> supplier){
        NetworkEvent.Context context = supplier.get();
        context.enqueueWork(() ->{
        //CLIENT
            ClientLivesData.set(lives);
            context.getSender().sendSystemMessage(Component.literal("LIVES = " + lives));
        });
    return true;
    }
}

PlayerLives Class:

package net.roberto.chubbyuhc.lives;

import net.minecraft.nbt.CompoundTag;

public class PlayerLives {
    private int lives;
    private final int MIN_LIVES = 0;
    private final int MAX_LIVES = 3;

    public int getLives(){
        return lives;
    }

    public void addLives(int add){
         this.lives = Math.min(lives +add, MAX_LIVES);
    }

    public void subLives(int add){
        this.lives = Math.max(lives - add, MIN_LIVES);
    }

    public void copyFrom(PlayerLives source){
        this.lives = source.lives;
    }

    public void saveNBTData(CompoundTag nbt){
        nbt.putInt("lives", lives);
    }

    public void loadNBTData(CompoundTag nbt){
        lives = nbt.getInt("lives");
    }

}

PlayerLivesProvider:

package net.roberto.chubbyuhc.lives;

import net.minecraft.core.Direction;
import net.minecraft.nbt.CompoundTag;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.CapabilityManager;
import net.minecraftforge.common.capabilities.CapabilityToken;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.common.util.INBTSerializable;
import net.minecraftforge.common.util.LazyOptional;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

public class PlayerLivesProvider implements ICapabilityProvider, INBTSerializable<CompoundTag> {
    public static Capability<PlayerLives> PLAYER_LIVES = CapabilityManager.get(new CapabilityToken<PlayerLives>() {});

    private PlayerLives lives = null;
    private final LazyOptional<PlayerLives> optional = LazyOptional.of(this::createPlayerLives);

    private PlayerLives createPlayerLives() {
        if(this.lives == null){
            this.lives = new PlayerLives();
        }
        return this.lives;
    }

    @Override
    public @NotNull <T> LazyOptional<T> getCapability(@NotNull Capability<T> cap, @Nullable Direction side) {
        if(cap == PLAYER_LIVES){
            return optional.cast();
        }
        return LazyOptional.empty();
    }

    @Override
    public CompoundTag serializeNBT() {
        CompoundTag nbt = new CompoundTag();
        createPlayerLives().saveNBTData(nbt);
        return nbt;
    }

    @Override
    public void deserializeNBT(CompoundTag nbt) {
        createPlayerLives().loadNBTData(nbt);
    }
}