Give Item to player

[deantonious]

Hi, I made a block that on right click executes a random action. I want In all of them to give an Item to the player that clicked the block. This Items are from other mod so i think the best way would be giving it by ID.

 

Thanks

[dvd604]

If it's a block, using onActivated from the block class should do the trick, just throw in

 

player.inventory.addItemStackToInventory(ItemStack);

 

Where player is your EntityPlayer.

 

As for the ID, that's up to you

[TLHPoE]

You could look into how the /give command works. I'm 100% sure it's method uses the item's/block's ID.

[deantonious]

I've got this

((EntityPlayer)MinecraftServer.getServer().getConfigurationManager().playerEntityList.get(0)).inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.explorerKit));

 

But I cant use the item ID... I've already look into the CommandGive without getting any idea of how to do it...

[TLHPoE]

My bad, the /give command uses an ItemStack.

 

You could get the item itself by using the findItem method in GameRegistry. All you need is the mod's ID and the item's name.

 

Item item = GameRegistry.findItem("ic2", "copperIngot");

[deantonious]

I don't know Mod's ID... thats why I want to use the ID, but if anyone knows th ID of the PixelmonMod please post it

[dvd604]

If you install the mod, then goto the Mods tab on the MC start screen, and click the mod you're looking for, it should tell you the ID

[deantonious]

I found it in the Mod Main class. Lets try if it works

[deantonious]

Not working...

[dvd604]

Sorry, I havnt done much in the way of tinkering with other peoples mods. My only help would be, try putting a "mod_" before the modID, to see if that helps

[deantonious]

I fixed it with addItemStackToInventory(new ItemStack(GameRegistry.findItem("pixelmon", "itemname")));

Thaks so much!

[deantonious]

I tried the mod in my server and I found an error:

It gives you the item, but only in Client Side... When I right click on the inventory, all the items that the mod gave me disapears... How I enable this to be in server side?

package deantonious.blocks;

import java.util.ArrayList;
import java.util.Random;
import java.util.Timer;
import java.util.TimerTask;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;

import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.SideOnly;

import deantonious.ModPowderCraft;
import net.minecraft.block.material.Material;
import net.minecraft.block.Block;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.monster.EntityCreeper;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.server.MinecraftServer;
import net.minecraft.src.ModLoader;
import net.minecraft.world.World;
import net.minecraftforge.client.MinecraftForgeClient;
import net.minecraftforge.common.MinecraftForge;

public class BlockMenaSubsuelo extends Block 
{

        public BlockMenaSubsuelo(int id, Material material) 
        {
                super(id, material);
        }
        
        @Override
    	public boolean onBlockActivated(World par1World, int par2, int par3, int par4, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    	{

            if(par5EntityPlayer.getHeldItem() == null)
    		{
            	if(par1World.isRemote){
            		ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Necesitas un Cincel");
        			
            	}
            	return super.onBlockActivated(par1World, par2, par3, par4, par5EntityPlayer, par6, par7, par8, par9);
    		}

    		if(par5EntityPlayer.getHeldItem().itemID == ModPowderCraft.cincel.itemID)
    		{

    			par5EntityPlayer.getHeldItem().stackSize -= 1; //only if you want to use the item when you do this.
    			if(par1World.isRemote)
    			{
    				par1World.playSound((double)par2 + 0.5D, (double)par3 + 0.1D, (double)par4 + 0.5D, "random.break", 0.3F, 0.5F, blockConstructorCalled);
    				par1World.playSound((double)par2 + 0.5D, (double)par3 + 0.1D, (double)par4 + 0.5D, "random.orb", 0.3F, 0.5F, blockConstructorCalled);
    				
    				int rand = par1World.rand.nextInt(60);

    	                if(rand<=8 && rand>=0){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado una Gema Azul");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaazul));
        	                
    	                }
    	                else if(rand<=16 && rand>={
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado una Gema Roja");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaroja));
        	                
    	                }
    	                else if(rand<=24 && rand>=16){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado una Gema Verde");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaverde));
        	                
    	                }
    	                else if(rand<=32 && rand>=24){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado una Gema Blanca");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemablanca));
        	                
    	                }
    	                else if(rand<=40 && rand>=32){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado una Gema Prisma");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaprisma));
        	                
    	                }
    	                else if(rand<=42 && rand>=40){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.ArmorFossilCovered));
    	                
    	                }
    	                else if(rand<=44 && rand>=42){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.ClawFossilCovered));
    	                }
    	                else if(rand<=46 && rand>=44){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.CoverFossilCovered));
    	                }
    	                else if(rand<=48 && rand>=46){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.DomeFossilCovered));
    	                }
    	                else if(rand<=50 && rand>=48){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.HelixFossilCovered));
    	                }
    	                else if(rand<=52 && rand>=50){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.OldAmberCovered));
    	                }
    	                else if(rand<=54 && rand>=52){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.PlumeFossilCovered));
    	                }
    	              
    	                else if(rand<=56 && rand>=54){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.RootFossilCovered));
    	                }
    	                else if(rand<=58 && rand>=56){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.SkullFossilCovered));
    	                }
    	                else if(rand<=60 && rand>=58){
    	                	ModLoader.getMinecraftInstance().thePlayer.addChatMessage("Has encontrado un Hueso");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Item.bone));
    	                }          
    	                return true;
    	                

    				
    			}
    			
        		par1World.setBlock(par2, par3, par4, Block.dirt.blockID);
    			return false;
    			    			
    		            
    		
    		}

    		return false;
    	}
          

}

[GotoLink]

if(par1World.isRemote)

You set yourself on client side.

 

ModLoader.getMinecraftInstance().thePlayer

Why ? You are not happy with the player the method gives you ?

 

 

[deantonious]

Everything works on single player, but when I play MP it gives the items, messages, etc. and then whe you try to take them, all the items disapear... But that only happens in survival mode, in creative mode it works...

[deantonious]

Bump

[deantonious]

If I don't use the isRemote, It makes the action two times... (Without the isRemote the ploblem dosn't fix)

It's just in survival mode... Remember you are right clicking on a block

[TheGreyGhost]

Hi

 

What they mean is... you should perform this action on the server side only, not the client side.

 

if(!par1World.isRemote) { 
  // give item code
}

The other bit I suspect might be important is to tell the server to send the updated inventory to the client

 

((EntityPlayerMP)par5EntityPlayer).sendContainerToPlayer(par5EntityPlayer.inventoryContainer);

 

- see BlockCauldron.onBlockActivated

 

-TGG

 

 

 

 

 

[deantonious]

This is the actual code, please tell me what I need to change:

package deantonious.blocks;

import java.util.ArrayList;
import java.util.Random;
import java.util.Timer;
import java.util.TimerTask;
import java.util.concurrent.Executors;
import java.util.concurrent.ScheduledExecutorService;

import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

import deantonious.ModPowderCraft;
import net.minecraft.block.material.Material;
import net.minecraft.block.Block;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.entity.monster.EntityCreeper;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.server.MinecraftServer;
import net.minecraft.src.ModLoader;
import net.minecraft.world.World;
import net.minecraftforge.client.MinecraftForgeClient;
import net.minecraftforge.common.MinecraftForge;

public class BlockMenaSubsuelo extends Block 
{

        public BlockMenaSubsuelo(int id, Material material) 
        {
                super(id, material);
        }
        
        @Override
    	public boolean onBlockActivated(World par1World, int par2, int par3, int par4, EntityPlayer par5EntityPlayer, int par6, float par7, float par8, float par9)
    	{

            if(par5EntityPlayer.getHeldItem() == null)
    		{
            	if(par1World.isRemote){
            		par5EntityPlayer.addChatMessage("Necesitas un Cincel");
        			
            	}
            	return super.onBlockActivated(par1World, par2, par3, par4, par5EntityPlayer, par6, par7, par8, par9);
    		}

    		if(par5EntityPlayer.getHeldItem().itemID == ModPowderCraft.cincel.itemID)
    		{

    			par5EntityPlayer.getHeldItem().stackSize -= 1; //only if you want to use the item when you do this.
    			if(par1World.isRemote)
    			{
    				par1World.playSound((double)par2 + 0.5D, (double)par3 + 0.1D, (double)par4 + 0.5D, "random.break", 0.3F, 0.5F, blockConstructorCalled);
    				par1World.playSound((double)par2 + 0.5D, (double)par3 + 0.1D, (double)par4 + 0.5D, "random.orb", 0.3F, 0.5F, blockConstructorCalled);
    				
    				int rand = par1World.rand.nextInt(60);

    	                if(rand<=8 && rand>=0){
    	                	par5EntityPlayer.addChatMessage("Has encontrado una Gema Azul");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaazul));
        	                
    	                }
    	                else if(rand<=16 && rand>={
    	                	par5EntityPlayer.addChatMessage("Has encontrado una Gema Roja");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaroja));
        	                
    	                }
    	                else if(rand<=24 && rand>=16){
    	                	par5EntityPlayer.addChatMessage("Has encontrado una Gema Verde");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaverde));
        	                
    	                }
    	                else if(rand<=32 && rand>=24){
    	                	par5EntityPlayer.addChatMessage("Has encontrado una Gema Blanca");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemablanca));
        	                
    	                }
    	                else if(rand<=40 && rand>=32){
    	                	par5EntityPlayer.addChatMessage("Has encontrado una Gema Prisma");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.gemaprisma));
        	                
    	                }
    	                else if(rand<=42 && rand>=40){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.ArmorFossilCovered));
    	                
    	                }
    	                else if(rand<=44 && rand>=42){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.ClawFossilCovered));
    	                }
    	                else if(rand<=46 && rand>=44){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.CoverFossilCovered));
    	                }
    	                else if(rand<=48 && rand>=46){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.DomeFossilCovered));
    	                }
    	                else if(rand<=50 && rand>=48){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.HelixFossilCovered));
    	                }
    	                else if(rand<=52 && rand>=50){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.OldAmberCovered));
    	                }
    	                else if(rand<=54 && rand>=52){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.PlumeFossilCovered));
    	                }
    	              
    	                else if(rand<=56 && rand>=54){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.RootFossilCovered));
    	                }
    	                else if(rand<=58 && rand>=56){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Fosil Cubierto");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(ModPowderCraft.SkullFossilCovered));
    	                }
    	                else if(rand<=60 && rand>=58){
    	                	par5EntityPlayer.addChatMessage("Has encontrado un Hueso");
    	                	par5EntityPlayer.inventory.addItemStackToInventory(new ItemStack(Item.bone));
    	                }          
    	                return true;
    				
    			}
    			
        		par1World.setBlock(par2, par3, par4, Block.dirt.blockID);
    			return false;	            
    		
    		}

    		return false;
    	}
          

}

[deantonious]

I want all of them to execute in both server and client. I don't really know what .isRemote is, but without it, it gives two items

[deantonious]

Is there any way of spawning an Item in the block position?

[GotoLink]

Change

if(par1World.isRemote)

to

if(!par1World.isRemote)

[deantonious]

When I change it to !isRemote, it gives me the item but its invisible... when I click on it all of them apear... adn also the block doesn't sets to dirt...

[TheGreyGhost]

Hi

 

I suspect it might be important to tell the server to send the updated inventory to the client

 

((EntityPlayerMP)par5EntityPlayer).sendContainerToPlayer(par5EntityPlayer.inventoryContainer);

 

- see BlockCauldron.onBlockActivated

 

-TGG