Jump to content

Recommended Posts

Posted

First of all for organization, do you use the multi-project setup?

if not check this out:

 

Now that being said you can put the blocks where ever you like.

 

I use a class called ModBlocks which holds all the blocks and has a method called init which intialize them.

So in the @Mod file (or well in the CommonProxy is where I do it, but whatever, details!) I just do

ModBlocks.init();

 

When I want to reference a block I've made like BlockBoom's ID I just do

ModBlocks.BlockBoom.blockID

If you guys dont get it.. then well ya.. try harder...

Posted

Important to remember that despite the fact that you are modding a game, you are still using Java.

every java technique you know can be used!

If you guys dont get it.. then well ya.. try harder...

Posted

Yes, you can.

 

I'd recommend object oriented code, though.

A fast template :

 

public class BlockHandler{

public int blockId//hold the unique data id for the block

    public BlockHandler(Class<? extends Block> clazz,Class[] paramType, Object[] param, int id, String unlocName, String oreName,...){
        blockId = id;
        Block block = null;
        try{
           block = clazz.getConstructor(paramType).newInstance(param);//building the block
        }catch(Exception e){}
        if(block!=null){
            block.setUnlocalizedName(unlocName).set...//finalizing the block
            GameRegistry.registerBlock(block,unlocName);//registering...
            OreDictionary.registerOre(oreName,block);
        }
    }
}

Then you only need a List or Map in another class to hold all the BlockHandler.

Like,

BlockHandlerRegistry.register(this);

Posted

I'd say because people tend to follow tutorials and prefer to copy/paste lines like

Block myBlock = new BlockWTV(...

Block myBlock1 = new BlockWTV(...

Block myBlock2 = new BlockWTV(...

Block myBlock3 = new BlockWTV(...

Ugly as hell.  :'(

Posted

That's true, but I expected that some of the larger mods (EE, BC etc.) would have used such systems? :P

It's bothered me a lot the way I do my own blocks but as I've not seen anyone else attempt it I figured it for some reason couldn't be helped and left it at that.

 

And here I keep telling people not to lose sight of the fact that they are programming when they are modding and that they should use their java knowlegde to the best of their ability and not get locked into the ways of minecraft modding :P

 

 

If you guys dont get it.. then well ya.. try harder...

Posted

Hello,

 

@GotoLink

 

You don't even need a list or a map if you use my code:

 

 

static void RegisterBlocks()
{
	try
	{
		for (Field field : ModClass.class.getFields())
		{				
			if (field.getType() == Block.class)
			{
				if (((Block)field.get(null)).damageDropped(1) == 0)
				{
					GameRegistry.registerBlock((Block)field.get(null), field.getName());
				}

				else
				{						
					GameRegistry.registerBlock((Block)field.get(null), (Class)Class.forName(field.get(null).getClass().getName() + "Item"), field.getName());
				}

				if (field.getType() == BlockContainer.class)
				{
					GameRegistry.registerTileEntity((Class)Class.forName(field.get(null).getClass().getName() + "TileEntity"), field.getName());
				}
			}
		}
	}

	catch (Exception ex)
	{
		ex.printStackTrace();
	}
}

 

 

with that damageDropped(1) == 0 thingy i'm checking if the block is a metadata block because i'm always overriding that in my metadata blocks.

 

BTW: It also registers TileEntity's automatically!

 

I'm using this for all my mods and it works perfectly!

 

ss7

You sir are a god damn hero.

Posted

@ss7

Nice use of reflection here, but you have

for (Field field : ModClass.class.getFields())

Which means you set a field for each block. Granted, a lot of people do this. I even do this (:P) when i don't have much.

 

But my suggestion only has two fields. (and it could be reduced to one, if you so wish)

public class HandlerRegistry{

    public static Map<String,BlockHandler> blocks = new HashMap();
    public static Map<String,ItemHandler> items = new HashMap();

    public static void register(BlockHandler block){
         blocks.put(block.getName(), block);
    }

    public static void register(ItemHandler item){
         items.put(item.getName(), item);
    }

    public static BlockHandler getBlock(String name){
         blocks.get(name);
    }

    public static ItemHandler getItem(String name){
         items.get(name);
    }
}

And that is only needed for blocks interactions anyway. Everything else can be done within BlockHandler.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
    • Add the mods in groups
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.