Jump to content

Recommended Posts

Posted

Hey all, Question for you:

 

I have a TileEntity that does some relatively heavy calculations and stores some data, fortunately it does this only once every 10 seconds. The client has no need of the data except when the Block's GUI is open.  So I have only the server running the calculations.  After much confusion, I had the "ah ha" moment that the client's TileEntity needs to be updated, from the server.  There seems to be a few ways to do this:

 

1. Use the getDescriptionPacket (Packet132) method in the TileEntity.  From what I read, this will update players in the vicinity on some periodic basis. My concern, this is a lot of extra traffic if people never open the GUI (which they prob. wont most of the time), and I'm not totally sure what the interval is, so I don't know if its fast enough to keep the GUI in sync with the TileEntity.

 

2. Send a custom packet (Packet250) from the server when the server executes the openGui().  This avoid unnecessary traffic, but causes a bit of a visible delay, as the GUI appears, then the packet is received, then the GUI is updated.

 

My question is two parts a) Is the TileEntity the right place for this kind of work, looking at source of other mods seems to suggest the Tile is the "workhorse" for your blocks b) Am I being overly concerned about traffic and should just go with #1 for the better GUI experience, or does the packet system incur a lot of overhead and should be used as sparingly as possible.

 

Thanks

-pete

Posted

You know, you can use the *public void updateScreen()* in GuiContainer to update your Gui

"Thinking that coding is the nerdy IT guy at work rebooting your computer is like thinking that music is what happens when the piano tuner comes round." - Ed Rex

Posted

You know, you can use the *public void updateScreen()* in GuiContainer to update your Gui

 

Will updateScreen() cause the Server-side TileEntity to update the client side entity?  Must understanding is "no" but I may be mistaken.  I know that I can do an onInventoryChanged() on the server, which will send an update, but it's my understanding that also will not sync custom data fields I am storing in my TileEntity.

 

 

Posted

1. Use the getDescriptionPacket (Packet132) method in the TileEntity.  From what I read, this will update players in the vicinity on some periodic basis. My concern, this is a lot of extra traffic if people never open the GUI (which they prob. wont most of the time), and I'm not totally sure what the interval is, so I don't know if its fast enough to keep the GUI in sync with the TileEntity.
First to answer your question: The Packet132 is send:

  • Whenever a player starts watching (= tracking) the chunk the TE is in
  • Whenever a block update on that block is done (which you can force via markBlockForUpdate or something like that in the World class).

 

But also: Packet132 sucks. It sucks badly. Why? It's much heavier than it needs to be. It always sends the overhead of a NBTTagCompound, which could be avoided. I suggest just making your own Packet250 to both tell the client to open the Gui (don't use FML's system) and transfer the data. that way you avoid the delay.

 

I also felt Packet132 was bloated.  I like your idea of going around FML to open the GUI, I'm going to try that tonight.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
    • Add the mods in groups
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.