Jump to content

[Forge 4.0.0.204] Entity spawn not synced properly


SirEntropy

Recommended Posts

I'm writing a mod to add a new type of boat: the Dinghy and an ItemDinghy that spawns the dinghy in a similar way as a vanilla boat. However, when I spawn a dinghy in the world, strange things happens: Instead of the dinghy appearing right in front of the player, the dinghy appears at position 0,0,0, then quickly moves to the correct position. I printed the position of both the client-side and server-side dinghy entities. The client-side dinghy has the correct position from the beginning (right in front of the player). The server-side dinghy starts with position 0,0,0, then quickly moves to the correct position.

 

This problem does not happen with the vanilla boat when the mod is installed.

 

The code that registers the dinghy entity is:

 

protected void registerEntity(Class<? extends Entity> entityClass, String entityName,
		int trackingRange, int updateFrequency, boolean sendsVelocityUpdates) {
	int id = ModLoader.getUniqueEntityId();
	EntityRegistry.registerModEntity(entityClass, entityName, id, mod, trackingRange,
			updateFrequency, sendsVelocityUpdates);
	EntityRegistry.registerGlobalEntityID(entityClass, entityName, id);
}
...
registerEntity(Dinghy.class, "EntityDinghy", 80, 3, false);

 

The code of Dinghy entity

 

public class Dinghy extends EntityAnyBoat {

public Dinghy(World world, double x, double y, double z) {
	super(world, x, y, z, 1.5f, 0.5f);
}

public Dinghy(World world) {
	super(world);
}

@Override
protected double getSpeedFactor() {
	return 0.1;
}

@Override
protected int getMaxHP() {
	return 100;
}

}


public abstract class EntityAnyBoat extends EntityBoat {

public EntityAnyBoat(World world, double x, double y, double z, float width, float height) {
	super(world, x, y, z);
	setSize(width, height);
	this.yOffset = this.height / 2.0F;
}

public EntityAnyBoat(World world) {
	super(world);
}

protected abstract double getSpeedFactor();

protected abstract int getMaxHP();
}

 

And the code of the Item that creates the dinghy:

 

public abstract class ItemAnyBoat extends Item {

public ItemAnyBoat(int par1) {
	super(par1);
	this.maxStackSize = 1;
	this.setTabToDisplayOn(CreativeTabs.tabTransport);
}

@Override
public ItemStack onItemRightClick(ItemStack itemStack, World world, EntityPlayer player) {

	if (!world.isRemote) {
                        // findBoatPosition has the same code that ItemBoat uses to find the spawn position of the boat
		Vec3 pos = WorldUtil.findBoatPosition(itemStack, world, player);
		if (pos != null) {
			world.spawnEntityInWorld(createBoat(world, pos));
			if (!player.capabilities.isCreativeMode) {
				--itemStack.stackSize;
			}
		}
	}
	return itemStack;
}

public abstract EntityAnyBoat createBoat(World world, Vec3 pos);

@Override
public String getTextureFile() {
	return SABResourceRegistry.ITEMS;
}
}

public class ItemDinghy extends ItemAnyBoat {

public ItemDinghy(int par1) {
	super(par1);
	setMaxStackSize(1);
	setIconIndex(items.DINGHY);
}

@Override
public EntityAnyBoat createBoat(World world, Vec3 pos) {
	return new Dinghy(world, pos.xCoord, pos.yCoord, pos.zCoord);
}



}

 

Could you please tell me what I'm doing wrong?

Link to comment
Share on other sites

Don't use the ModLoader.getUniqueEntityID() method!

 

Use the EntityRegistry.findGlobalUniqueEntityId() instead.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

hm, okay then, but I would rather use the method from the EntitiyRegistry instead of the ModLoader equivalent, because you don't have troubles then when Forge will be updated and something has changed in the ModLoader compatibility layer of forge.

 

Anyway, try to use this as the constructor of your boat entity:

public Dinghy(World world, double x, double y, double z) {
	super(world, x, y, z, 1.5f, 0.5f);
	setPosition(x, y, z);
}

 

Sometimes my entities spawn at 0,0,0 client-side, too. Then the server will teleport the client-side entity to the right location. But I would say it occurs only in 1 out of 25 spawns for me.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

hm, okay then, but I would rather use the method from the EntitiyRegistry instead of the ModLoader equivalent, because you don't have troubles then when Forge will be updated and something has changed in the ModLoader compatibility layer of forge.

 

Anyway, try to use this as the constructor of your boat entity:

public Dinghy(World world, double x, double y, double z) {
	super(world, x, y, z, 1.5f, 0.5f);
	setPosition(x, y, z);
}

 

Sometimes my entities spawn at 0,0,0 client-side, too. Then the server will teleport the client-side entity to the right location. But I would say it occurs only in 1 out of 25 spawns for me.

 

I tried it and it doesn't work. My problem is entities spawning at 0,0,0 at the server side.

 

Any other ideas on how to fix this problem?

Link to comment
Share on other sites

Update: I found the problem. Actually, there were two:

 

- The entity with position 0,0,0 is at the client-side. My mistake

- The problem is with EntityBoat.setPositionAndRotation2. The last parameter of this method (par9) is used by the EntityBoat class to smoothly move the client-side boat from its current position to the latest position reported by the server. The problem is the number of steps in that movement, stored in the attribute boatPosRotationIncrements, is calculated in a very weird way. See this snippet of EntityBoat.setPositionAndRotation2:

 

if (this.field_70279_a)
        {
            this.boatPosRotationIncrements = par9 + 5;
        }
        else
        {
           ...

            this.boatPosRotationIncrements = 3;
        }

 

The solution is to completely rewrite EntityBoat.onUpdate and EntityBoat.setPositionAndRotation2 in my subclass.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The mobs are moving normally for a second, then freeze, then go back to normal, and this repeats. I describe this as mob lag, bc they stutter as if they were lagging. I don't have the best wifi, but that shouldn't matter since its 10mbps which is enough for a server. I have 8 gigs of ram for it, no optimizations have worked, if there is anything more you may need to help lmk, ill describe. The modlist is pretty hefty: VS_ClockworkSurvivalSupportV1.4 aether-1.20.1-1.2.0-neoforge.jar alexsdelight-1.5.jar alexsmobs-1.22.7.jar appleskin-forge-mc1.20.1-2.5.1.jar backpacked-forge-1.20.1-2.2.5.jar balm-forge-1.20.1-7.2.1.jar bettervillage-forge-1.20.1-3.2.0.jar BiomesOPlenty-1.20.1-18.0.0.598.jar botarium-forge-1.20.1-2.3.2.jar CGM-Unofficial-1.4.11+Forge+1.20.1.jar citadel-2.5.2-1.20.1.jar clockwork-1.20.1-0.1.2-forge-05f5d5fbbb.jar configured-forge-1.20.1-2.2.2.jar connectivity-1.20.1-4.9.jar create-1.20.1-0.5.1.f.jar create-new-age-forge-1.20.1-1.1.2.jar createarmoryv0.6.1n.jar createbigcannons-forge-1.20.1-0.5.3.b.jar createchunkloading-1.6.0-forge.jar createdeco-2.0.1-1.20.1-forge.jar createdieselgenerators-1.20.1-1.2h.jar createendertransmission-2.0.7-1.20.1.jar create_misc_and_things_ 1.20.1_4.0A.jar cristellib-1.1.5-forge.jar cupboard-1.20.1-2.3.jar curios-forge-5.7.0+1.20.1.jar destroy-1.20.1-0.8.jar Dungeon Crawl-1.20.1-2.3.14.jar FallingTree-1.20.1-4.3.4.jar FarmersDelight-1.20.1-1.2.4.jar framework-forge-1.20.1-0.6.26.jar geckolib-forge-1.20.1-4.4.2.jar InsaneLib-1.12.1-mc1.20.1.jar Jade-1.20.1-forge-11.8.0.jar jei-1.20.1-forge-15.3.0.4.jar journeymap-1.20.1-5.9.18-forge.jar JustEnoughResources-1.20.1-1.4.0.247.jar kotlinforforge-4.10.0-all.jar l2library-2.4.23.jar libraryferret-forge-1.20.1-4.0.0.jar macawsbridgesbop-1.20-1.1.jar mcw-bridges-2.1.0-mc1.20.4forge.jar moonlight-1.20-2.9.17-forge.jar morevillagers-forge-1.20.1-5.0.0.jar Mo_ZombiesWave-1.20.1-0.1.0-forge.jar NaturesCompass-1.20.1-1.11.2-forge.jar Placebo-1.20.1-8.6.1.jar refinedstorage-1.12.4.jar soundphysics-forge-1.20.1-1.1.2.jar spark-1.10.53-forge.jar stealing_villagers-forge-1.20.1-1.0.0.jar s_a_b-1.3.0_1.20.1.jar takesapillage-1.0.3-1.20.1.jar TerraBlender-forge-1.20.1-3.0.1.4.jar tombstone-1.20.1-8.6.2.jar Towns-and-Towers-1.12-Fabric+Forge.jar twilightforest-1.20.1-4.3.2145-universal.jar valkyrienskies-120-2.1.3-beta.1.jar veinmining-forge-1.3.0+1.20.1.jar waystones-forge-1.20-14.1.3.jar YungsApi-1.20-Forge-4.0.3.jar YungsBetterDesertTemples-1.20-Forge-3.0.3.jar YungsBetterDungeons-1.20-Forge-4.0.3.jar YungsBetterEndIsland-1.20-Forge-2.0.5.jar YungsBetterJungleTemples-1.20-Forge-2.0.4.jar YungsBetterMineshafts-1.20-Forge-4.0.4.jar YungsBetterNetherFortresses-1.20-Forge-2.0.5.jar YungsBetterOceanMonuments-1.20-Forge-3.0.4.jar YungsBetterStrongholds-1.20-Forge-4.0.3.jar YungsBetterWitchHuts-1.20-Forge-3.0.3.jar YungsBridges-1.20-Forge-4.0.3.jar zaynens_leather_from_rotten_flesh_mod_1.20.1.jar
    • Thank you so much! Unfortunately before reading this I reinstalled my java installer. Now when I try to open the forge installer I receive an error message stating 'Unable to install Java' even though I have definitely downloaded and installed the latest version. Any idea what this could be or how I could fix it?  
    • IT WORKED! THANK YOU!
    • sorry for the stuborn ness ss   test code logs and planks return nothing on minable but i can use the other tags  name minecraft:oak_log BlockTags.LOGS name minecraft:oak_planks BlockTags.PLANKS   it kinda works but its not like like perfect             
    • I'm making a custom modpack for 1.20.1 and everything else seems to work except this Passive skilltree mod. The world loads fine but when I press the keybind to open the mod's GUI, the world immediately saves and crashes with this report: https://pastebin.com/svEPsRty Any help or insight towards the right direction is greatly appreciated!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.