[1.6.2][SOLVED] Help with removing metadata items

[ThePocketSoul]

Hello! I'm having a problem with removing metadata items.

The problem isn't its not removing one of the item, it does, but it removes one of each of the metadata items if you have them in your inventory...

Code:

public void removeItem(EntityPlayer ep, ItemStack removeitem, int remove) {
    	IInventory inv = ep.inventory;
    	for(int i=0; i < inv.getSizeInventory(); i++)
    	{
    		if(inv.getStackInSlot(i) != null)
    		{
    			ItemStack j = inv.getStackInSlot(i);
    			if(j.getItem() != null && j.getItem() == removeitem.getItem())
    			{
    				inv.decrStackSize(i, remove);
    			}
    		}
    	}
    }

 

Thanks ahead of time!

[Busti]

You need to test for the metadata because the item never changes with the metadata.

[robin4002]

public void removeItem(EntityPlayer ep, ItemStack removeitem, int remove, int metadata) {
    	IInventory inv = ep.inventory;
    	for(int i=0; i < inv.getSizeInventory(); i++)
    	{
    		if(inv.getStackInSlot(i) != null)
    		{
    			ItemStack j = inv.getStackInSlot(i);
    			if(j.getItem() != null && j.getItem() == removeitem.getItem() && j.getItemDamage() == metadata)
    			{
    				inv.decrStackSize(i, remove);
    			}
    		}
    	}
    }

[ThePocketSoul]

public void removeItem(EntityPlayer ep, ItemStack removeitem, int remove, int metadata) {
    	IInventory inv = ep.inventory;
    	for(int i=0; i < inv.getSizeInventory(); i++)
    	{
    		if(inv.getStackInSlot(i) != null)
    		{
    			ItemStack j = inv.getStackInSlot(i);
    			if(j.getItem() != null && j.getItem() == removeitem.getItem() && j.getItem().getItemDamage() == metadata)
    			{
    				inv.decrStackSize(i, remove);
    			}
    		}
    	}
    }

Thanks but getItemDamage doesn't work...

i changed it to this and it worked

public void removeItem(EntityPlayer ep, ItemStack removeitem, int remove, int metadata) {
    	IInventory inv = ep.inventory;
    	for(int i=0; i < inv.getSizeInventory(); i++)
    	{
    		if(inv.getStackInSlot(i) != null)
    		{
    			ItemStack j = inv.getStackInSlot(i);
    			if(j.getItem() != null && j.getItem() == removeitem.getItem() && j.getItem().getDamage(j) == metadata)
    			{
    				inv.decrStackSize(i, remove);
    			}
    		}
    	}
    }

[SamTebbs33]

You need to use j.getItemDamage(). That gets the damage/metadata of the itemstack

[robin4002]

Thanks but getItemDamage doesn't work...

My bad, getItemDamage() is in ItemStack.java, not Item.java.

j.getItemDamage() should work.