1.20.1 1.20.1 Crash "Cannot invoke "net.minecraft.client.player.LocalPlayer.m_6117_()" because "this.f_91074_" is null"

[HeyKatu]

Forge 47.2.17

I am tearing my hair out over this one. I am having an issue where something in my modded instance is causing the mod resources to fail at loading. Each time this happens, I get a notification of "Resource reload failed," and some of the time it crashes as well. When it does not crash, my Mods screen shows only Minecraft and Forge. When I next launch, all of my resourcepacks are reset to default. I have been troubleshooting this for literal days now so I may get at this out of order, but I'll do my best. Firstly, here is the crash report and the associated latest.log: https://gist.github.com/katubug/04d946d2879dbb9d6abaf1cb923ebca0

Initially it was only happening about once every ten or so launches, which made it insanely hard to troubleshoot. I googled the issue and only found one relevant post, which stated that it was due to a mod being incompatible with recent forge updates. The post suggested doing a binary search for the offending mod. Hard to do with an inconsistent crash, so I gave up for a bit.

Then I found a way to replicate it reliably - I used a mod called Resource Pack Overrides to set my game to apply all my resource packs by default. Now that it was happening every launch, I did the binary search and I THOUGHT I'd found the offending files: Dramatic Doors and Dynamic View. I removed them both and everything was fine...until I zipped up the pack and sent it to my sibling. They still got the resource reload failed and the crash. At this point I am still launching fine on my PC, but on theirs the exact same pack gives this error.

I also googled "resource reload failed," and many of the posts attributed this error to a resourcepack being too large, or Optifine. I do not have optifine, and the issue occurred periodically even without resource packs applied. That brought me to believe that perhaps there was something in the mod_resources which was causing the error. My sibling's PC is less powerful than mine, so that could explain why they're crashing but I'm not.

I have been combing the logs, thought I'd isolated the incident to being related to the Supplementaries mod or KubeJS - but in both cases I now believe they were just providing error information after something else went wrong. Here is a crash and latest.log of an instance with Supplementaries removed: https://gist.github.com/katubug/effe28a9a4d36f7378fd8161d6495741

It seems as if the game is trying to load mod resources multiple times and then breaking. I am at my wits' end. I have ended up reporting this to so many places who ended up not being the culprit, lol. Please, someone tell me you have a fix, a lead, anything. Thank you.

Edited December 19, 2023 by HeyKatu

[TileEntity]

Make some tests without these mods:

xaeroworldmap/minimap
dynamiclightsreforged
modernfix
rubidium/rubidiumextra/oculus/embeddium/embeddiumplus
drippyloadingscreen
nochatreports

Start with removing rubidium/rubidiumextras/oculus/embeddium/embeddiumplus

 

 

[HeyKatu]

I removed the Rubidium addon as it apparently doesn't work with Embeddium.

I disabled the Embeddium mods and Oculus and indeed, the crash has stopped. Added them back in to be sure, crashed again. Removed the other mods with Embeddium and Oculus in - crashed. Or, well, not always a full crash, sometimes just the "resource reload failed."

Tested with just Oculus, no Embeddium, no crash. I'll have to check with my other users to see if it fixes theirs as well, but this may be the solution! Fingers crossed.

[HeyKatu]

After discussing this with the Embeddium dev for a while, it seems that this probably isn't the culprit.

They said: "what I suspect is happening is that something else goes wrong internally and closes the resource pack zip file, without printing an error.

then later the next subsystem to access the resource pack crashes with the "zip file closed" exception.

note that that is just an educated guess, based on the fact that the crash makes no sense without a preceding error."

I mentioned the Dramatic Doors thing fixing it for me, and they then said "ok yeah if you can remove two distinct mods like that (embeddium/dramatic doors) and they both solve the problem, I'd guess it's related to load order."

Doing more testing now.

[HeyKatu]

I had disabled and reenabled a few mods to find the crash.

Then activated everything - all mods, all resourcepacks - to replicate the crash to be certain... it didn't crash. So it's definitely not embeddium and frankly I have no idea what is even going on.

Embeddium dev said that suggests it's not even a load order issue, it's a race condition. Help is still very welcome.

Edited December 21, 2023 by HeyKatu

[HeyKatu]

Still having the crash, still trying to troubleshoot. I managed to get it to only "Resource Reload Failed" as opposed to the full CTD, and had a look at the mods list. Most said they were "process_imc," but a handful said "error." Forge included. This occurs on 47.2.0 as well as 47.2.17. I reverted to an older version to see if it would help.

Here's that list: https://pastebin.com/Ha68X99Q

I don't know what they all have in common, but maybe someone smarter than me has an idea. I can confirm that every time the Resource Reload Failed occurs, it's the same mods erroring.

I've tried putting them in their own instance to test, but so far no crash. I'm also testing the main instance without them/adding them in one at a time. However, since the crash is alleviated simply by disabling apparently any mod, this is guesswork at best.

I will pay literal real world money to anyone who can fix this. I am losing my mind - I can't release a modpack with this crash active, and I have no other projects atm.

Edited December 21, 2023 by HeyKatu

[HeyKatu]

So, hopefully a final update: the crash hasn't occurred in a while. I'm not 100% sure why, but I think it might have been an issue with the mod Merchant Markers. The reason I think that is because someone in their issue tracker reported this same problem (although they could have been mistaken, they didn't seem super knowledgeable). And the crash hasn't occurred since I removed the mod.

I feel it might still be too early to call it, but I wanted to update in case anyone finds this on google.

[jadan1213]

I have had this issue off and on, and it's been a headache. Disabled merchant markers and i was able to load into game. I enabled merchant markers again but this time set show_on_minimap = false and I was able to load in. Disabling showing the markers on the minimap might be a fix if you want to use merchant markers.

[jadan1213]

I also just noticed that an update was released for Xaero's world map and minimap, I'm going to install them and re-enable that setting and see what happens.

[jadan1213]

well scratch that, the update didn't change it. still got a crash.

[Resulon12]

For people coming across this issue: 

 

I solved it for my Modpack by disabling the Holiday hats feature in the config file of "Thermal Series". 

Apparently it is incompatible with some mods like "Creeper Overhaul"