mabutingtao Posted December 23, 2023 Posted December 23, 2023 (edited) I have a block with entity block which should emit redstone signal if there's a player nearby. I have a POWER property that represents the redstone signal power, it's updated from the block entity tick and I do update the blockstate and notify neighbors about it (if I do it in a right way, I'm new to modding in Minecraft :D) According to what I see from some debugging, ticks actually happen and property actually changes its value (I didn't test that from the block code though, only in the block entity code) but redstone signal doesn't change. Here's my block code: package net.mabutingtao.fadinglight.block; import net.mabutingtao.fadinglight.init.MyBlockEntityRegistry; import net.mabutingtao.fadinglight.util.TickableBlockEntity; import net.minecraft.world.level.block.entity.BlockEntityTicker; import net.minecraft.world.level.block.entity.BlockEntityType; import net.minecraft.world.level.block.state.StateDefinition; import net.minecraft.world.level.block.state.properties.IntegerProperty; import net.minecraft.world.level.block.state.properties.Property; import net.minecraft.world.phys.shapes.VoxelShape; import net.minecraft.world.phys.shapes.Shapes; import net.minecraft.world.phys.shapes.CollisionContext; import net.minecraft.world.level.storage.loot.LootParams; import net.minecraft.world.level.block.state.properties.NoteBlockInstrument; import net.minecraft.world.level.block.state.BlockState; import net.minecraft.world.level.block.state.BlockBehaviour; import net.minecraft.world.level.block.SoundType; import net.minecraft.world.level.block.Block; import net.minecraft.world.level.BlockGetter; import net.minecraft.world.item.TooltipFlag; import net.minecraft.world.item.ItemStack; import net.minecraft.network.chat.Component; import net.minecraft.core.Direction; import net.minecraft.core.BlockPos; import java.util.List; import java.util.Collections; import java.util.ArrayList; import net.minecraft.world.level.LevelAccessor; import net.minecraft.world.entity.Entity; import net.minecraft.world.level.Level; import java.util.Random; import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.world.level.block.EntityBlock; import javax.annotation.Nullable; import net.minecraft.world.level.block.RenderShape; public class SoulSensorBlock extends Block implements EntityBlock { public static final IntegerProperty POWER = IntegerProperty.create("power", 0, 15); public SoulSensorBlock() { super(Properties.of().instrument(NoteBlockInstrument.BASEDRUM).sound(SoundType.STONE).strength(1f, 10f).noOcclusion().isRedstoneConductor((bs, br, bp) -> true)); this.registerDefaultState(((BlockState) this.stateDefinition.any()).setValue(POWER, 15)); } protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> builder) { builder.add(POWER); } @Nullable @Override public BlockEntity newBlockEntity(BlockPos pos, BlockState state) { return MyBlockEntityRegistry.SOUL_SENSOR.get().create(pos, state); } @org.jetbrains.annotations.Nullable @Override public <T extends BlockEntity> BlockEntityTicker<T> getTicker(Level level, BlockState state, BlockEntityType<T> type) { return TickableBlockEntity.getTickerHelper(level); } @Override public boolean triggerEvent(BlockState state, Level world, BlockPos pos, int eventID, int eventParam) { super.triggerEvent(state, world, pos, eventID, eventParam); BlockEntity blockEntity = world.getBlockEntity(pos); return blockEntity == null ? false : blockEntity.triggerEvent(eventID, eventParam); } @Override public void onPlace(BlockState state, Level level, BlockPos pos, BlockState state1, boolean b) { Direction[] directions = Direction.values(); for (Direction direction : directions) { level.updateNeighborsAt(pos.relative(direction), this); } } @Override public void onRemove(BlockState state, Level level, BlockPos pos, BlockState state1, boolean b) { if (!b) { Direction[] directions = Direction.values(); for (Direction direction : directions) { level.updateNeighborsAt(pos.relative(direction), this); } } } @Override public void appendHoverText(ItemStack itemstack, BlockGetter world, List<Component> list, TooltipFlag flag) { super.appendHoverText(itemstack, world, list, flag); } @Override public int getLightBlock(BlockState state, BlockGetter worldIn, BlockPos pos) { return 15; } @Override public VoxelShape getVisualShape(BlockState state, BlockGetter world, BlockPos pos, CollisionContext context) { return Shapes.empty(); } @Override public boolean isSignalSource(BlockState state) { return true; } @Override public int getSignal(BlockState blockstate, BlockGetter blockAccess, BlockPos pos, Direction direction) { return blockstate.getValue(POWER); } @Override public int getDirectSignal(BlockState blockstate, BlockGetter blockAccess, BlockPos pos, Direction direction) { return blockstate.getValue(POWER); } @Override public boolean canConnectRedstone(BlockState state, BlockGetter world, BlockPos pos, Direction side) { return true; } @Override public List<ItemStack> getDrops(BlockState state, LootParams.Builder builder) { List<ItemStack> dropsOriginal = super.getDrops(state, builder); if (!dropsOriginal.isEmpty()) return dropsOriginal; return Collections.singletonList(new ItemStack(this, 1)); } } And here's the code of block entity: package net.mabutingtao.fadinglight.block; import net.mabutingtao.fadinglight.init.*; import net.mabutingtao.fadinglight.init.MyBlockEntityRegistry; import net.mabutingtao.fadinglight.util.TickableBlockEntity; import net.minecraft.core.Direction; import net.minecraft.world.entity.player.Player; import net.minecraft.world.level.BlockGetter; import net.minecraft.world.level.Level; import net.minecraft.world.level.block.*; import net.minecraft.world.level.block.entity.BlockEntityTicker; import net.minecraft.world.level.block.state.properties.BlockStateProperties; import net.minecraft.world.phys.Vec3; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.api.distmarker.OnlyIn; import net.minecraftforge.api.distmarker.Dist; import net.minecraft.world.level.block.entity.BlockEntity; import net.minecraft.core.BlockPos; import net.minecraft.world.level.block.state.BlockState; import net.minecraft.world.level.block.entity.BlockEntityType; import net.minecraftforge.registries.RegistryObject; import net.minecraft.core.Registry; public class SoulSensorEntityBlock extends BlockEntity implements TickableBlockEntity { private int last_output = 0; public SoulSensorEntityBlock(BlockPos pos, BlockState state) { super(MyBlockEntityRegistry.SOUL_SENSOR.get(), pos, state); } public void tick() { Level level = this.getLevel(); BlockPos pos = this.getBlockPos(); BlockState state = this.getBlockState(); int output = 0; if (isPlayerNearby(level, pos, 4)) { output = 15; } if (output != last_output) { level.setBlockAndUpdate(pos, state.setValue(SoulSensorBlock.POWER, output)); this.updateNeighbours(state, level, pos); } last_output = output; } private void updateNeighbours(BlockState state, Level level, BlockPos pos) { level.updateNeighborsAt(pos, state.getBlock()); Direction[] directions = Direction.values(); for (Direction direction : directions) { level.updateNeighborsAt(pos.relative(direction), state.getBlock()); } } private boolean isPlayerNearby(Level level, BlockPos pos, double distance) { for (Player player : level.players()) { if (player.distanceToSqr(Vec3.atCenterOf(pos)) <= distance) return true; } return false; } } Thanks in advance for help. Edited December 23, 2023 by mabutingtao Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.