Jump to content

Recommended Posts

Posted

Okay so im trying to add a door to my mod, but i have had no success, ive tried extending, i've tried making new door class files, and no luck, anybody know how to add them in? be much appreciated :)

Posted

Hi

 

Why not just use the existing door?

 

i.e. what do you want to do differently?

 

Door is a bit complicated because it needs its own renderer and it's made up of two blocks not one.  It's also got a pile of logic  related to opening & closing, whether entities can pass through it or not, changes to the bounding box, etc.

 

If you want to tweak something simple, like the sound it makes when it opens, then it's easy.  Otherwise it's going to take a fair bit of skill and knowledge about the vanilla door and renderers in particular.

 

-TGG

 

 

Posted

Hi

 

Why not just use the existing door?

 

i.e. what do you want to do differently?

 

Door is a bit complicated because it needs its own renderer and it's made up of two blocks not one.  It's also got a pile of logic  related to opening & closing, whether entities can pass through it or not, changes to the bounding box, etc.

 

If you want to tweak something simple, like the sound it makes when it opens, then it's easy.  Otherwise it's going to take a fair bit of skill and knowledge about the vanilla door and renderers in particular.

 

-TGG

I want to create a new door. with the material of rock, my own texture, name, and id. Doesn't it use the texture-map?

Posted

Hi

 

In that case, I think you're in luck.  I'd suggest

 

create your

class BlockMyNewDoor extends BlockDoor

add a constructor

add icon member variables (copy the ones from BlockDoor)

override

    public void registerIcons(IconRegister par1IconRegister)

to register your new icons/textures into BlockMyNewDoor member variables (the BlockDoor ones are private unfortunately)

 

and override

    public Icon getBlockTexture(IBlockAccess par1IBlockAccess, int par2, int par3, int par4, int par5)

copy the code from BlockDoor.getBlockTexture into BlockMyNewDoor.getBlockTexture and change the references to the icon fields to your own icon texture member variables.

 

The material is in the constructor so it's relatively easy - and if you want your stone door to act like a wooden door (i.e. players can open it) then you probably don't need to change onBlockActivated either.

 

-TGG

 

 

Posted

Thanks Man, Figured It Out :) Here's The Code For Those Who Are Struggling With This :)

 

Main Class

//Making The Door And Item
public final static Block AdobeDoor = new AdobeDoor(900, Material.rock)
		.setHardness(2.0F).setResistance(10.0F)
		.setStepSound(Block.soundStoneFootstep)
		.setUnlocalizedName("adobe_door");
public final static Item AdobeDoorItem = new AdobeDoorItem(901, AdobeDoor)
		.setUnlocalizedName("adobe_door_icon");
//Registering The Door And Items
LanguageRegistry.addName(AdobeDoorItem, "Adobe Door");
GameRegistry.registerBlock(AdobeDoor, "AdobeDoor");
LanguageRegistry.addName(AdobeDoor, "Adobe Door");

 

Item Class

package SavageCraft.Adobe;

import net.minecraft.block.Block;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.item.ItemDoor;
import net.minecraft.item.ItemStack;
import net.minecraft.util.MathHelper;
import net.minecraft.world.World;

public class AdobeDoorItem extends Item {
public Block doorBlock;

public AdobeDoorItem(int par1, Block block) {
	super(par1);
	this.doorBlock = block;
	this.maxStackSize = 1;
	this.setCreativeTab(CreativeTabs.tabRedstone);
}

public boolean onItemUse(ItemStack par1ItemStack,
		EntityPlayer par2EntityPlayer, World par3World, int par4, int par5,
		int par6, int par7, float par8, float par9, float par10) {
	if (par7 != 1) {
		return false;
	} else {
		++par5;
		Block block = this.doorBlock;

		if (par2EntityPlayer.canPlayerEdit(par4, par5, par6, par7,
				par1ItemStack)
				&& par2EntityPlayer.canPlayerEdit(par4, par5 + 1, par6,
						par7, par1ItemStack)) {
			if (!block.canPlaceBlockAt(par3World, par4, par5, par6)) {
				return false;
			} else {
				int i1 = MathHelper
						.floor_double((double) ((par2EntityPlayer.rotationYaw + 180.0F) * 4.0F / 360.0F) - 0.5D) & 3;
				ItemDoor.placeDoorBlock(par3World, par4, par5, par6, i1,
						block);
				--par1ItemStack.stackSize;
				return true;
			}
		} else {
			return false;
		}
	}
}

@Override
public void registerIcons(IconRegister iconRegister) {
	itemIcon = iconRegister.registerIcon(AdobeInfo.NAME.toLowerCase()
			+ ":adobe_door_icon");
}
}

 

Door block Class

package SavageCraft.Adobe;

import java.util.Random;

import net.minecraft.block.BlockDoor;
import net.minecraft.block.material.Material;
import net.minecraft.client.renderer.IconFlipped;
import net.minecraft.client.renderer.texture.IconRegister;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.Item;
import net.minecraft.util.Icon;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;

public class AdobeDoor extends BlockDoor {
public Item placerItem;
public Icon topDoorIcon;
public Icon[] flippedIcons = new Icon[2];

public AdobeDoor(int par1, Material par2Material) {
	super(par1, par2Material);
	float f = 0.5F;
	float f1 = 1.0F;
	this.setLightOpacity(0);
	this.setBlockBounds(0.5F - f, 0.0F, 0.5F - f, 0.5F + f, f1, 0.5F + f);
}

public Icon getBlockTexture(IBlockAccess par1IBlockAccess, int par2,
		int par3, int par4, int par5) {
	if (par5 == 1 || par5 == 0) {
		return this.blockIcon;
	}
	int meta = getFullMetadata(par1IBlockAccess, par2, par3, par4);
	boolean flag = (meta & 4) != 0;
	int halfMeta = meta & 3;
	boolean flipped = false;

	if (flag) {
		if (halfMeta == 0 && par5 == 2)
			flipped = !flipped;
		else if (halfMeta == 1 && par5 == 5)
			flipped = !flipped;
		else if (halfMeta == 2 && par5 == 3)
			flipped = !flipped;
		else if (halfMeta == 3 && par5 == 4)
			flipped = !flipped;
	} else {
		if (halfMeta == 0 && par5 == 5)
			flipped = !flipped;
		else if (halfMeta == 1 && par5 == 3)
			flipped = !flipped;
		else if (halfMeta == 2 && par5 == 4)
			flipped = !flipped;
		else if (halfMeta == 3 && par5 == 2)
			flipped = !flipped;
		if ((meta & 16) != 0)
			flipped = !flipped;
	}

	if (flipped)
		return flippedIcons[(meta &  != 0 ? 1 : 0];
	else
		return (meta &  != 0 ? this.topDoorIcon : this.blockIcon;
}

public Icon getIcon(int par1, int par2) {
	return this.blockIcon;
}

@Override
public void registerIcons(IconRegister iconRegister) {
	this.blockIcon = iconRegister.registerIcon(AdobeInfo.NAME.toLowerCase()
			+ ":adobe_door_lower");
	this.topDoorIcon = iconRegister.registerIcon(AdobeInfo.NAME
			.toLowerCase() + ":adobe_door_upper");
	this.flippedIcons[0] = new IconFlipped(blockIcon, true, false);
	this.flippedIcons[1] = new IconFlipped(topDoorIcon, true, false);
}

public int idPicked(World par1World, int par2, int par3, int par4) {
	return AdobeBlock.AdobeDoorItem.itemID;
}

public int idDropped(int par1, Random par2Random, int par3) {
	return (par1 &  != 0 ? 0 : (AdobeBlock.AdobeDoorItem.itemID);
}
        
        //Remove This Below If You Want It To Open Like A Wooden Door
public boolean onBlockActivated(World par1World, int par2, int par3,
		int par4, EntityPlayer par5EntityPlayer, int par6, float par7,
		float par8, float par9) {
	return false;
}

}

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • https://mclo.gs/9y5ciD2 anyone ever had this issue?  Internal exception illegal argument exception: unable to fit 3194354 into 3
    • Hoffman Law Recovery helped me recovered my lost funds
    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.