Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.20.1] [SOLVED] Mod Config Screen disables keys after exiting

Zeher_Monkey

By Zeher_Monkey
in Modder Support

 Share

Recommended Posts

Zeher_Monkey Creeper Killer

Zeher_Monkey

Posted
Posted (edited)

So this has been an issue for me for a while, but I would like to have it resolved now. I have tried a myriad of things to fix it.

Basically when I open the config screen for my mod, everything works as normal. However once I exit the screen, all keys are disabled, WASD, E for inventory etc. ESC still works, but my character cannot move or open the inventory. Any help would be appreciated :)

Exiting to the main menu and then returning to the game also does nothing, the game has to be fully closed and restarted.

 

ModBusManager.java

  Reveal hidden contents

 

ScreenConfiguration.java

  Reveal hidden contents

 

I believe it is something to do with the onClose function, but I am not sure.

Edited by Zeher_Monkey
  • 2 weeks later...
  • 3 weeks later...
dee12452 Stone Miner

dee12452

Posted
Posted
  Quote

I believe it is something to do with the onClose function, but I am not sure.

Expand  

Yeh you might be on to something. Have you tried not setting the screen on close? Screen default behavior pops the gui anyways so not sure it's needed

Screen.java 

    public void onClose() {
        this.minecraft.popGuiLayer();
    }

 

Although it could be this also being a problem 

	@Override
	public boolean keyPressed(int mouseX, int mouseY, int ticks) {
		if (this.CURRENT_SCREEN == "blocks") {
			return this.EDIT_BOX_BLOCKS.getEditBox().keyPressed(mouseX, mouseY, ticks);
		} else if (this.CURRENT_SCREEN == "items") {
			return this.EDIT_BOX_ITEMS.getEditBox().keyPressed(mouseX, mouseY, ticks);
		} else if (this.CURRENT_SCREEN == "commands") {
			return this.EDIT_BOX_COMMANDS.getEditBox().keyPressed(mouseX, mouseY, ticks);
		}
		
		return super.keyPressed(mouseX, mouseY, ticks);
	}

 

I'd suggest starting by changing onClose to just  

    @Override
    public void onClose() {
        ConfigurationManager.save();
    	super.onClose();
    }

and see if that fixes it.

 

If not try commenting out your `keyPressed` function to see if that was it.

Zeher_Monkey Creeper Killer

Zeher_Monkey

Posted
  • Author
Posted
  On 3/15/2024 at 1:48 PM, dee12452 said:

Yeh you might be on to something. Have you tried not setting the screen on close? Screen default behavior pops the gui anyways so not sure it's needed

Screen.java 

    public void onClose() {
        this.minecraft.popGuiLayer();
    }

 

Although it could be this also being a problem 

	@Override
	public boolean keyPressed(int mouseX, int mouseY, int ticks) {
		if (this.CURRENT_SCREEN == "blocks") {
			return this.EDIT_BOX_BLOCKS.getEditBox().keyPressed(mouseX, mouseY, ticks);
		} else if (this.CURRENT_SCREEN == "items") {
			return this.EDIT_BOX_ITEMS.getEditBox().keyPressed(mouseX, mouseY, ticks);
		} else if (this.CURRENT_SCREEN == "commands") {
			return this.EDIT_BOX_COMMANDS.getEditBox().keyPressed(mouseX, mouseY, ticks);
		}
		
		return super.keyPressed(mouseX, mouseY, ticks);
	}

 

I'd suggest starting by changing onClose to just  

    @Override
    public void onClose() {
        ConfigurationManager.save();
    	super.onClose();
    }

and see if that fixes it.

 

If not try commenting out your `keyPressed` function to see if that was it.

Expand  

Hi, thanks for the reply.

I tried what you suggested, along with a number of other things and it is still doing the same thing. I'm pulling my hair out at this point.

I also tried commenting out the other functions relating to Mouse or Keyboard inputs and no luck.

Mouse movement works, but mouse buttons do not. No keyboard inputs are accepted other than ESC to open the Pause Screen. When the pause screen or Main Menu screens are open mouse and keyboard inputs work as expected.

I have searched high and low on this forum and not encountered anyone else with the same problem, and the documentation is frustratingly lacking for this particular area.

I have even delved into some of Minecrafts own settings screens and they don't do it a different way. All of them just use the 

minecraft.setScreen(screen);

function.

dee12452 Stone Miner

dee12452

Posted
Posted (edited)

Alright you might have to unfortunately take a big step back. What if you comment out every piece of functionality in your custom screen, so as much as possible till it’s basically a blank screen that does nothing, and add one thing back at a time until the problem pops up?
 

I am also curious, when and how does this screen appear to the player? That may have something to do with it.

Edited by dee12452
Punctuation
Zeher_Monkey Creeper Killer

Zeher_Monkey

Posted
  • Author
Posted (edited)
  On 3/15/2024 at 4:46 PM, dee12452 said:

Alright you might have to unfortunately take a big step back. What if you comment out every piece of functionality in your custom screen, so as much as possible till it’s basically a blank screen that does nothing, and add one thing back at a time until the problem pops up?
 

I am also curious, when and how does this screen appear to the player? That may have something to do with it.

Expand  

I can certainly try that for sure.

It is shown to the player only if they go into it, it uses Forge's ConfigScreenFactory system.

This is the registry code: 

@OnlyIn(Dist.CLIENT)
Public static void registerClient(ModLoadingContext context) {
	context.registerExtensionPoint(ConfigScreenFactory.class, () -> new ConfigScreenFactory((mc, screen) -> { return new ScreenConfiguration(screen); }));
}

Main Menu -> Mods -> Mod -> Config (this is when my screen class comes in)

I have used plenty of other mods who use the same system and never had an issue. It could be an issue with Forge, but I am not sure.

Edited by Zeher_Monkey
dee12452 Stone Miner

dee12452

Posted
Posted

I gotchya. So I copied your code and removed all the things that I don't have access to in this post (i.e. any of the CosmosOptionListTextEntry) and I didn't get the issue you're talking about.

 

Can you post the implementation of `CosmosOptionListTextEntry`? The problem might be in there.

Zeher_Monkey Creeper Killer

Zeher_Monkey

Posted
  • Author
Posted
  On 3/15/2024 at 9:08 PM, dee12452 said:

I gotchya. So I copied your code and removed all the things that I don't have access to in this post (i.e. any of the CosmosOptionListTextEntry) and I didn't get the issue you're talking about.

 

Can you post the implementation of `CosmosOptionListTextEntry`? The problem might be in there.

Expand  

I was about to say during my testing I removed all of my custom Option List code and it worked, but obviously stopped the screen from doing what I need it to.

Code available at its GitHub Repo:

https://github.com/CosmosMods/CosmosLibrary/tree/1.20.1-10.3.1.0/src/main/java/com/tcn/cosmoslibrary/client/ui/screen/option

All of the Options related classes are in there.

dee12452 Stone Miner

dee12452

Posted
Posted

Oh man, so I skimmed through what I thought to be relevant and I didn't see a smoking gun. My guess is a widget such as an EditBox is taking and keeping key presses but I'm not 100% on that. Sorry I can't be more helpful at this point, I think for you at this point it's unfortunately going to be a game of needle in the haystack

Zeher_Monkey Creeper Killer

Zeher_Monkey

Posted
  • Author
Posted (edited)
  On 3/15/2024 at 9:46 PM, dee12452 said:

Oh man, so I skimmed through what I thought to be relevant and I didn't see a smoking gun. My guess is a widget such as an EditBox is taking and keeping key presses but I'm not 100% on that. Sorry I can't be more helpful at this point, I think for you at this point it's unfortunately going to be a game of needle in the haystack

Expand  

I much appreciate the help.

I figured it out!

So I have a custom Options class which extends the vanilla Options class. When I initialize it in the ConfigScreen, I need to supply a file. I chose to use a blank file with "." as the path.

For some reason this appears to be the issue, despite never actually using a physical file, because I am using the Forge config system, this has finally fixed the issue.

OLD: 

public void initOptions() {
	this.OPTIONS_ROW_LIST = new CosmosOptionsList(
		this.minecraft, this.width, this.height, OPTIONS_LIST_TOP_HEIGHT, this.height - OPTIONS_LIST_BOTTOM_OFFSET, 
		OPTIONS_LIST_ITEM_HEIGHT, OPTIONS_LIST_BUTTON_HEIGHT, 310, new CosmosOptions(Minecraft.getInstance(), new File("."))
	);
}


NEW: 

public void initOptions() {
	this.OPTIONS_ROW_LIST = new CosmosOptionsList(
		this.minecraft, this.width, this.height, OPTIONS_LIST_TOP_HEIGHT, this.height - OPTIONS_LIST_BOTTOM_OFFSET, 
		OPTIONS_LIST_ITEM_HEIGHT, OPTIONS_LIST_BUTTON_HEIGHT, 310, new CosmosOptions(Minecraft.getInstance(), new File(this.minecraft.gameDirectory.getAbsolutePath() + "/dimpockets"))
	);
}


Such a strange issue, but thats Minecraft & Forge :P

Still giving some strange issues, but it doesn't require a full restart anymore.

Edited by Zeher_Monkey
  • Zeher_Monkey changed the title to [1.20.1] [SOLVED] Mod Config Screen disables keys after exiting

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept