Hello my fellow Modders
this is the event code it's working fine with every mob and attack except witches it didn't trigger when witches attacked the player .. can you help me with this problem ... this is the code 
I'm new to coding in general 

 

@SubscribeEvent(priority = EventPriority.HIGH)
    public void AttackEvent(LivingAttackEvent event) {
  
        if (!event.getEntity().getCommandSenderWorld().isClientSide) {
          
            if (!(event.getEntity() instanceof ServerPlayer player)) return;
            ItemStack ring = Utils.getFirstCurio(ModItemGod.divinering.get(), player);
            Entity attacker2 = event.getSource().getEntity();
            Entity attacker = event.getSource().getDirectEntity();

            if (ring != null && attacker instanceof SummonedZombie summonedzombie || attacker instanceof SummonedSkeleton summoneskeleton || attacker instanceof SummonedVex summonedvex || attacker instanceof Vex vex ) {
              
                ((Monster) attacker).knockback(10,2 ,10);
                attacker.kill();
                event.setCanceled(true);
            }
          
            else if (ring != null && attacker2 instanceof SummonedZombie summonedzombie || attacker2 instanceof SummonedSkeleton summoneskeleton || attacker2 instanceof SummonedVex summonedvex || attacker2 instanceof Vex vex) {
              
                ((Monster) attacker2).knockback(10,2 ,10);
                attacker2.kill();
                event.setCanceled(true);
            }
            else if (ring != null) {
                ((LivingEntity) attacker2).addEffect((new MobEffectInstance(MobEffects.BLINDNESS, 200, 2, false, false)));
                ((LivingEntity) attacker2).setHealth(((LivingEntity) attacker2).getHealth() / 2);
                ((LivingEntity) attacker2).knockback(10, 3, 10);
                event.setCanceled(true);
            }
        }
    }

 

Edited February 5, 20241 yr by NoahKassem
clean the code

18 hours ago, NoahKassem said:

can you help me with this problem

Unfortunately I don't think the entity that threw the potion is propagated to the LivingAttackEvent. What you could do is subscribe to the PotionAddedEvent and check if the source entity is a witch.

i couldn't find the event PotionAddedEvent .. im modding for MC 1.20.1 

2 hours ago, NoahKassem said:

i couldn't find the event PotionAddedEvent .. im modding for MC 1.20.1 

Yes, sorry about that, looks like the name was changed to MobEffectEvent.Added.

Quote

 Yes, sorry about that, looks like the name was changed to MobEffectEvent.Added

thank you. I appreciate your effort to help me it is working. thanks again ..