Level capability isnt saving.

[MatNX]

i have created a Level Capability to store data to the level, allowing for blocks to be painted by the player. The basic implementation works, i can right click a block and it gets a tint as defined. However, when I close the game and reopen it, all painted areas are gone, that is, it seems to either not save or reload the capabilties to or from disk. I have made a similar cabability for blockentities, and those save fine, so it seems to be related to the level. Perhaps a server/client issue? Either way, I'm not sure where to go, so any help would be greatly appreciated.

package com.matnx.masonry.multiblock.capability;

import net.minecraft.core.BlockPos;
import net.minecraft.nbt.CompoundTag;
import net.minecraftforge.common.capabilities.AutoRegisterCapability;
import org.checkerframework.checker.units.qual.A;

import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.List;
import java.util.stream.Collectors;

@AutoRegisterCapability
public class ColorCapability {
    private List<Integer> color = new ArrayList<>();
    private List<BlockPos> pos = new ArrayList<>();

    public int getColor(int i) {
        if (color.size() > i) {
            return color.get(i);
        } else {
            return -1;
        }
    }

    public void setColor(int p_18944_, int i) {
        color.set(i, p_18944_);
    }

    public void addColor(int p_18944_) {
        color.add(p_18944_);
    }

    public BlockPos getPos(int i) {
        if (pos.size() > i) {
            return pos.get(i);
        } else {
            return new BlockPos(0, -500, 0);
        }
    }

    public int containsPos(BlockPos posit) {
        return pos.indexOf(posit);
    }

    public void addPos(BlockPos p_18944_) {
        pos.add(p_18944_);
    }

    public void setPos(BlockPos p_18944_, int i) {
        pos.set(i, p_18944_);
    }

    public void saveNBTData(CompoundTag nbt) {
        String[] stringArray = pos.stream()
                .map(BlockPos::toShortString)
                .toArray(String[]::new);
        String concatenatedString = String.join(";", stringArray);
        byte[] byteArray = concatenatedString.getBytes(StandardCharsets.UTF_8);
        nbt.putByteArray("pos", byteArray);
        nbt.putIntArray("color", color);
    }

    public void loadNBTData(CompoundTag nbt) {
        byte[] byteArray = nbt.getByteArray("pos");
        String restoredString = new String(byteArray, StandardCharsets.UTF_8);
        String[] restoredArray = restoredString.split(";");

        pos = Arrays.stream(restoredArray).map(s -> {
                    String[] parts = s.split(",");
                    return new BlockPos(Integer.valueOf(parts[0]), Integer.valueOf(parts[1]), Integer.valueOf(parts[2]));
                }).collect(Collectors.toList());
        color = Arrays.stream(nbt.getIntArray("color"))
                .boxed()
                .collect(Collectors.toList());
    }
}

 

[vemerion]

  On 2/17/2024 at 8:29 AM, MatNX said:

Either way, I'm not sure where to go, so any help would be greatly appreciated.

Expand  

Can you post the code for your capability provider? Also, you can use NbtUtils.writeBlockPos()/readBlockPos() to more easily write/read BlockPos to/from NBT.

[MatNX]

Provider is fairly straightforward, here you go. Thanks for the fast response and the tip!

package com.matnx.masonry.multiblock.capability;

import net.minecraft.core.Direction;
import net.minecraft.nbt.CompoundTag;
import net.minecraftforge.common.capabilities.Capability;
import net.minecraftforge.common.capabilities.CapabilityManager;
import net.minecraftforge.common.capabilities.CapabilityToken;
import net.minecraftforge.common.capabilities.ICapabilityProvider;
import net.minecraftforge.common.util.INBTSerializable;
import net.minecraftforge.common.util.LazyOptional;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

public class ColorCapabilityProvider implements ICapabilityProvider, INBTSerializable<CompoundTag> {
    public static Capability<ColorCapability> COLOR_CAPABILITY = CapabilityManager.get(new CapabilityToken<>() {
    });

    private ColorCapability colorCapability = null;
    private final LazyOptional<ColorCapability> optional = LazyOptional.of(this::createColor);

    private @NotNull ColorCapability createColor() {
        if (this.colorCapability == null) {
            this.colorCapability = new ColorCapability();
        }
        return this.colorCapability;
    }

    @Override
    public @NotNull <T> LazyOptional<T> getCapability(@NotNull Capability<T> cap, @Nullable Direction side) {
        if (cap == COLOR_CAPABILITY) {
            return optional.cast();
        }
        return LazyOptional.empty();
    }

    @Override
    public CompoundTag serializeNBT() {
        CompoundTag nbt = new CompoundTag();
        createColor().saveNBTData(nbt);
        return nbt;
    }

    @Override
    public void deserializeNBT(CompoundTag nbt) {
        createColor().loadNBTData(nbt);
    }
}

 

[vemerion]

  On 2/17/2024 at 8:56 AM, MatNX said:

Provider is fairly straightforward, here you go. Thanks for the fast response and the tip!

Expand  

Hmm, I don't see any problems with the code. You could try debugging and put breakpoints in saveNBTData() and loadNBTData() to see make sure that the methods are called and that the code in the methods works as expected.

[MatNX]

  On 2/17/2024 at 3:57 PM, vemerion said:

You could try debugging and put breakpoints in saveNBTData() and loadNBTData()

Expand  

The saveNBTData and loadNBTData both fires, and, when loading a world, I can see the data in the field while debugging. However, here is where it gets interesting: Save and load both get called 3 times, and they only have the data one the first load/save. It seems that the subsequent 2 calls override my color and pos fields. It seems like a Client/Server issue.

 

[MatNX]

Update: I got it! It was a really stupid problem: blockpos.toshortstring concatenates using , . I was checking for ,. I just missed the space. A stupid mistake, but thanks for your help anyway.