Jump to content

Recommended Posts

Posted (edited)

I have a block already registered in my mod, which I have used in some worlds. The problem arises when in code, I add a property called CURRENT_AGE, when running Minecraft it freezes. In the console it doesn't appear any excpetion except that it stays in this phase:

[Render thread/DEBUG] [ne.mi.co.ca.CapabilityManager/CAPABILITIES]: Attempting to automatically register: Lnet/minecraftforge/items/IItemHandler;

Does anyone have an idea what it could be? I show the block and its registration

public class SoulLichenBlock extends MultifaceBlock implements SimpleWaterloggedBlock, EntityBlock {

    public static final BooleanProperty WATERLOGGED = BlockStateProperties.WATERLOGGED;
    public static final IntegerProperty SKILL_LEVEL = IntegerProperty.create("soullichen_level", 0, 30);
    public static final DirectionProperty FACE = DirectionProperty.create("soullichen_face");
    public static final DirectionProperty DIRECTION = DirectionProperty.create("soullichen_direction");
    public static final IntegerProperty CURRENT_AGE = BlockStateProperties.AGE_25;
    private final MultifaceSpreader spreader = new MultifaceSpreader(this);
    private final MultifaceSpreader.DefaultSpreaderConfig config = new MultifaceSpreader.DefaultSpreaderConfig(this);
    private LivingEntity owner;
    //private static final Integer MAX_AGE = 25;

    public SoulLichenBlock(Properties properties) {
        super(properties);
        this.registerDefaultState(this
                .defaultBlockState()
                .setValue(WATERLOGGED, Boolean.FALSE)
                .setValue(SKILL_LEVEL, 0)
                .setValue(FACE, Direction.DOWN)
                .setValue(DIRECTION, Direction.DOWN)
                .trySetValue(CURRENT_AGE, 0)
        );
    }

    public static ToIntFunction<BlockState> emission(int p_181223_) {
        return (p_181221_) -> MultifaceBlock.hasAnyFace(p_181221_) ? p_181223_ : 0;
    }

    public static boolean hasFace(BlockState p_153901_, @NotNull Direction p_153902_) {
        BooleanProperty booleanproperty = getFaceProperty(p_153902_);
        return p_153901_.hasProperty(booleanproperty) && p_153901_.getValue(booleanproperty);
    }

    protected void createBlockStateDefinition(StateDefinition.@NotNull Builder<Block, BlockState> stateDefinition) {
        stateDefinition.add(WATERLOGGED).add(SKILL_LEVEL).add(FACE).add(DIRECTION).add(CURRENT_AGE);
        super.createBlockStateDefinition(stateDefinition);
    }

    public @NotNull BlockState updateShape(BlockState p_153302_, @NotNull Direction p_153303_, @NotNull BlockState p_153304_, @NotNull LevelAccessor p_153305_, @NotNull BlockPos p_153306_, @NotNull BlockPos p_153307_) {
        if (p_153302_.getValue(WATERLOGGED)) {
            p_153305_.scheduleTick(p_153306_, Fluids.WATER, Fluids.WATER.getTickDelay(p_153305_));
        }
        return super.updateShape(p_153302_, p_153303_, p_153304_, p_153305_, p_153306_, p_153307_);
    }

    @SuppressWarnings("deprecation")
    public @NotNull FluidState getFluidState(BlockState fluidState) {
        return fluidState.getValue(WATERLOGGED) ? Fluids.WATER.getSource(false) : super.getFluidState(fluidState);
    }

    public boolean propagatesSkylightDown(BlockState p_181225_, @NotNull BlockGetter blockGetter, @NotNull BlockPos blockPos) {
        return p_181225_.getFluidState().isEmpty();
    }

    public @NotNull MultifaceSpreader getSpreader() {
        return this.spreader;
    }

    public Optional<MultifaceSpreader.SpreadPos> spreadFromRandomFaceTowardRandomDirection(
            BlockState p_221620_, LevelAccessor p_221621_, BlockPos p_221622_, RandomSource p_221623_, int skillPoints, int age) {
        return Direction.allShuffled(p_221623_).stream().filter((p_221680_) -> {
            return this.config.canSpreadFrom(p_221620_, p_221680_);
        }).map((p_221629_) -> {
            return this.spreadFromFaceTowardRandomDirection(p_221620_, p_221621_, p_221622_, p_221629_, p_221623_, false, skillPoints, age);
        }).filter(Optional::isPresent).findFirst().orElse(Optional.empty());
    }

    public Optional<MultifaceSpreader.SpreadPos> spreadFromFaceTowardRandomDirection(
            BlockState blockState,
            LevelAccessor levelAccessor,
            BlockPos blockPos,
            Direction face,
            RandomSource randomSource,
            boolean aBoolean,
            int skillPoints, int age) {
        return Direction.allShuffled(randomSource).stream().map((direction) ->
                        spreadFromFaceTowardDirection(blockState, levelAccessor, blockPos, face, direction, aBoolean, skillPoints, age))
                .filter(Optional::isPresent)
                .findFirst()
                .orElse(Optional.empty());
    }

    public Optional<MultifaceSpreader.SpreadPos> spreadFromFaceTowardDirection(
            BlockState blockState,
            LevelAccessor levelAccessor,
            BlockPos blockPos,
            Direction face,
            Direction direction,
            boolean aBoolean, int skillPoints, int age) {
        //DevilRpg.LOGGER.debug("BEGIN ==================================== spreadFromFaceTowardDirection skillPoints {}", skillPoints);
        return skillPoints < 0 ? Optional.empty() : getSpreadFromFaceTowardDirection(blockState, levelAccessor, blockPos, face, direction, this::canSpreadInto)
                .flatMap((spreadPos)
                        -> {
                    //DevilRpg.LOGGER.debug("END ================================ spreadFromFaceTowardDirection spreadPos {}", spreadPos);
                    return this.spreadToFace(levelAccessor, spreadPos, aBoolean, skillPoints, direction, age);
                });
    }

    public boolean canSpreadInto(BlockGetter p_221685_, BlockPos p_221686_, MultifaceSpreader.SpreadPos p_221687_) {
        BlockState blockstate = p_221685_.getBlockState(p_221687_.pos());
        return this.stateCanBeReplaced(p_221685_, p_221686_, p_221687_.pos(), p_221687_.face(), blockstate) && isValidStateForPlacement(p_221685_, blockstate, p_221687_.pos(), p_221687_.face());
    }

    protected boolean stateCanBeReplaced(BlockGetter p_221688_, BlockPos p_221689_, BlockPos p_221690_, Direction p_221691_, BlockState p_221692_) {
        return p_221692_.isAir() || p_221692_.is(this) || p_221692_.is(Blocks.WATER) && p_221692_.getFluidState().isSource();
    }

    public Optional<MultifaceSpreader.SpreadPos> getSpreadFromFaceTowardDirection(BlockState blockState, BlockGetter blockGetter, BlockPos blockPos, Direction face, Direction direction, MultifaceSpreader.SpreadPredicate spreadPredicate) {
        //DevilRpg.LOGGER.debug("--- getSpreadFromFaceTowardDirection direction.getAxis() == face.getAxis(): {}", direction.getAxis() == face.getAxis());
        ArrayList<Direction> directions = new ArrayList<>();
        directions.add(direction);
        if (direction.getAxis() == face.getAxis()) {
            if (direction.getAxis().isHorizontal()) {
                directions = Arrays.stream(Direction.values()).filter(dir -> dir.getAxis().isVertical()).collect(Collectors.toCollection(ArrayList::new));
            }
            if (direction.getAxis().isVertical()) {
                directions = Arrays.stream(Direction.values()).filter(dir -> dir.getAxis().isHorizontal()).collect(Collectors.toCollection(ArrayList::new));
            }
        }
        for (Direction directionElement : directions) {
            /*DevilRpg.LOGGER.debug("--->> getSpreadFromFaceTowardDirection  config.isOtherBlockValidAsSource(blockState) {} || " +
                    "hasFace(blockState, face) {}  && " +
                    "!hasFace(blockState, direction) {}", config.isOtherBlockValidAsSource(blockState), hasFace(blockState, face), !hasFace(blockState, directionElement));*/
            if (config.isOtherBlockValidAsSource(blockState) ||
                    hasFace(blockState, face) &&
                            !hasFace(blockState, directionElement)) {

                for (MultifaceSpreader.SpreadType multifacespreader$spreadtype : config.getSpreadTypes()) {
                    MultifaceSpreader.SpreadPos multifacespreader$spreadpos = multifacespreader$spreadtype.getSpreadPos(blockPos, directionElement, face);
                    //DevilRpg.LOGGER.debug("--- test SpreadPos: {} direction {} face {} ", multifacespreader$spreadpos, directionElement, face);
                    if (spreadPredicate.test(blockGetter, blockPos, multifacespreader$spreadpos)) {
                        //DevilRpg.LOGGER.debug("--- spreadPredicate success:");
                        return Optional.of(multifacespreader$spreadpos);
                    }
                }
            }
        }
        return Optional.empty();
    }

    public boolean isValidStateForPlacement(@NotNull BlockGetter blockGetter, @NotNull BlockState blockState, @NotNull BlockPos blockPos, @NotNull Direction face) {
        //DevilRpg.LOGGER.debug("------ isValidStateForPlacement 1st condition: {} && ({} || {})", this.isFaceSupported(face), !blockState.is(this), !hasFace(blockState, face));
        if (this.isFaceSupported(face) && (!blockState.is(this) || !hasFace(blockState, face))) {
            BlockPos blockpos = blockPos.relative(face);
            //DevilRpg.LOGGER.debug("------ isValidStateForPlacement 2nd condition: canAttachTo {} ", secondCondition);
            return canAttachTo(blockGetter, face, blockpos, blockGetter.getBlockState(blockpos));
        } else {
            return false;
        }
    }

    @Nullable
    public BlockState getStateForPlacement(@NotNull BlockState blockState, @NotNull BlockGetter blockGetter,
                                           @NotNull BlockPos blockPos, @NotNull Direction face, int skillPoints, Direction direction, int age) {
        //DevilRpg.LOGGER.debug("--- getStateForPlacement");
        boolean isNotValidStateForPlacement = !this.isValidStateForPlacement(blockGetter, blockState, blockPos, face);
        //DevilRpg.LOGGER.debug("------- isNotValidStateForPlacement: {}", isNotValidStateForPlacement);
        if (isNotValidStateForPlacement) {
            return null;
        } else {
            BlockState blockstate;
            if (blockState.is(this)) {
                blockstate = blockState;
            } else if (this.isWaterloggable() && blockState.getFluidState().isSourceOfType(Fluids.WATER)) {
                blockstate = this.defaultBlockState().setValue(BlockStateProperties.WATERLOGGED, Boolean.TRUE);
            } else {
                blockstate = this.defaultBlockState();
            }


            //DevilRpg.LOGGER.debug("------- getStateForPlacement -> blockStateResult  ");
            return blockstate
                    .setValue(getFaceProperty(face), Boolean.TRUE)
                    .setValue(SKILL_LEVEL, skillPoints).setValue(FACE, face)
                    .setValue(DIRECTION, direction)
                    .setValue(CURRENT_AGE,age)
            ;
        }
    }

    public Optional<MultifaceSpreader.SpreadPos> spreadToFace(LevelAccessor levelAccessor, MultifaceSpreader.SpreadPos spreadPos,
                                                              boolean p_221596_, int skillPoints, Direction direction, int age) {
        BlockState blockstate = levelAccessor.getBlockState(spreadPos.pos());
        //DevilRpg.LOGGER.debug("---> spreadToFace blockstate{} direction: {}", blockstate, direction);
        return this.placeBlock(levelAccessor, spreadPos, blockstate, p_221596_, skillPoints, direction, age) ? Optional.of(spreadPos) : Optional.empty();
    }

    public boolean placeBlock(LevelAccessor p_221702_, MultifaceSpreader.SpreadPos p_221703_,
                              BlockState p_221704_, boolean p_221705_, int skillPoints, Direction direction, int age) {
        //DevilRpg.LOGGER.debug("---> placeBlock {} direction {} ", p_221703_, direction);
        BlockState blockstate = this.getStateForPlacement(p_221704_, p_221702_, p_221703_.pos(), p_221703_.face(), skillPoints, direction, age);

        if (blockstate != null) {
            if (p_221705_) {
                p_221702_.getChunk(p_221703_.pos()).markPosForPostprocessing(p_221703_.pos());
            }
            //DevilRpg.LOGGER.debug("------> setBlock");
            return p_221702_.setBlock(p_221703_.pos(), blockstate, 2);
        } else {
            return false;
        }
    }

    public long spreadFromFaceTowardAllDirections(
            BlockState blockState, LevelAccessor levelAccessor, BlockPos blockPos,
            Direction face, boolean aBoolean, int skillPoints, int age) {
        return Direction.stream().map((p_221656_) ->
                        spreadFromFaceTowardDirection(blockState, levelAccessor, blockPos, face, p_221656_, aBoolean, skillPoints, age))
                .filter(Optional::isPresent).count();
    }

    private boolean isWaterloggable() {
        return this.stateDefinition.getProperties().contains(BlockStateProperties.WATERLOGGED);
    }

    @Override
    public void setPlacedBy(@NotNull Level level, @NotNull BlockPos blockPos, @NotNull BlockState blockState, @Nullable LivingEntity livingEntity, @NotNull ItemStack itemStack) {
        super.setPlacedBy(level, blockPos, blockState, livingEntity, itemStack);
        this.setOwner(livingEntity);
    }

    public LivingEntity getOwner() {
        return this.owner;
    }

    private void setOwner(LivingEntity livingEntity) {
        this.owner = livingEntity;
    }

    @Deprecated
    @Override
    public void entityInside(@NotNull BlockState blockState, @NotNull Level level, @NotNull BlockPos blockPos, @NotNull Entity entity) {
        if (entity instanceof LivingEntity /*&& entity.getType() != EntityType.BEE*/ && entity.getType() != ModEntities.LICHEN_SEEDBALL.get()) {
            entity.makeStuckInBlock(blockState, new Vec3(0.8D, 0.75D, 0.8D));
            if (!level.isClientSide /*&& (entity.xOld != entity.getX() || entity.zOld != entity.getZ())*/) {
                // double d0 = Math.abs(entity.getX() - entity.xOld);
                // double d1 = Math.abs(entity.getZ() - entity.zOld);
                // if (d0 >= (double) 0.003F || d1 >= (double) 0.003F) {
                entity.hurt(level.damageSources().playerAttack((Player) owner), 1.0F);

                // Aplicar aceleración al movimiento
                double speedBoost = -0.4; // Ajusta este valor según lo rápido que quieras que sea el impulso
                double motionX = entity.getX() - entity.xOld;
                double motionZ = entity.getZ() - entity.zOld;
                double speed = Math.sqrt(motionX * motionX + motionZ * motionZ);
                //if (speed > 0.0) {
                entity.setDeltaMovement(entity.getDeltaMovement().multiply(
                        (motionX / speed) * speedBoost,
                        0.0,
                        (motionZ / speed) * speedBoost
                ));
                // }
                //}
            }
        }
    }

    @Nullable
    @Override
    public BlockEntity newBlockEntity(@NotNull BlockPos pos, @NotNull BlockState state) {
        return ModEntityBlocks.SOUL_LICHEN_ENTITY_BLOCK.get().create(pos, state);
    }


    @Nullable
    @Override
    public <T extends BlockEntity> BlockEntityTicker<T> getTicker(Level level, @NotNull BlockState blockState, @NotNull BlockEntityType<T> type) {
        return level.isClientSide ? null : (alevel, pos, aBlockstate, blockEntity) -> {
            if (blockEntity instanceof SoulLichenBlockEntity soulLichenBlockEntity && alevel.getGameTime() % 5 == 0) {
                soulLichenBlockEntity.tick(blockState, (ServerLevel) alevel, pos, alevel.getRandom());
                //DevilRpg.LOGGER.info("-------->tick. this: {}", this.getClass().getSimpleName());
            }
        };
    }
}

 

This is the registration:

 

public final class ModBlocks {

    public static final DeferredRegister<Block> BLOCKS = DeferredRegister.create(ForgeRegistries.BLOCKS, DevilRpg.MODID);

      ...

    public static final RegistryObject<SoulLichenBlock> SOUL_LICHEN_BLOCK = BLOCKS.register("soullichen", () -> new SoulLichenBlock(
            Block.Properties.copy(Blocks.GLOW_LICHEN).lightLevel(SoulLichenBlock.emission(7)).randomTicks()
    ));
}

 

Edited by chipoodle
  • chipoodle changed the title to Adding a property to a custom block freezes Minecraft without giving an Exception
Posted

I've found that, when I uncomment the .add(CURRENT_AGE) in the following method, Minecraft freezes without giving any exception, otherwise it runs without any problem.

 

protected void createBlockStateDefinition(StateDefinition.@NotNull Builder<Block, BlockState> stateDefinition) {
        stateDefinition.add(WATERLOGGED).add(SKILL_LEVEL).add(FACE).add(DIRECTION)
                //.add(CURRENT_AGE)
        ;
        super.createBlockStateDefinition(stateDefinition);
    }

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello everyone, i'm new with programing Mods, and will need a lot of your help if possible,  Im trying to make a new GUI interface responsible to control the Droprate of game, it will control de loot drop and loot table for mobs and even blocks, but i try to make a simple Gui Screen, and wenever i try to use it, the game crash's with the error message in the subject, here is the code im using to:  IDE: IntelliJ Comunity - latest version Forge: 47.3.0 Minecraft version: 1.20.1 mapping_channel: parchment mapping_version=2023.09.03-1.20.1 Crash report link: https://pastebin.com/6dV8k1Fw   Code im using is:    package createchronical.droprateconfig; import com.mojang.blaze3d.systems.RenderSystem; import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.components.Button; import net.minecraft.client.gui.screens.Screen; import net.minecraft.network.chat.Component; import net.minecraft.resources.ResourceLocation; import java.util.HashMap; import java.util.Map; public class ConfigScreen extends Screen { private static final ResourceLocation BACKGROUND_TEXTURE = new ResourceLocation("droprateconfig", "textures/gui/config_background.png"); // Mapa de mobs e itens com seus respectivos drop rates private final Map<String, Integer> dropRates = new HashMap<>(); public ConfigScreen() { super(Component.literal("Configurações de Drop Rate")); // Inicializa com valores de drop rate padrão dropRates.put("Zombie", 10); // Exemplo de mob dropRates.put("Creeper", 5); // Exemplo de mob dropRates.put("Iron Ore", 50); // Exemplo de item dropRates.put("Diamond", 2); // Exemplo de item } @Override protected void init() { // Cria um botão para cada mob/item e adiciona na tela int yOffset = this.height / 2 - 100; // Posicionamento inicial for (Map.Entry<String, Integer> entry : dropRates.entrySet()) { String itemName = entry.getKey(); int dropRate = entry.getValue(); // Cria um botão para cada mob/item this.addRenderableWidget(Button.builder( Component.literal(itemName + ": " + dropRate + "%"), button -> onDropRateButtonPressed(itemName) ).bounds(this.width / 2 - 100, yOffset, 200, 20).build()); yOffset += 25; // Incrementa a posição Y para o próximo botão } // Adiciona o botão de "Salvar Configurações" this.addRenderableWidget(Button.builder(Component.literal("Salvar Configurações"), button -> onSavePressed()) .bounds(this.width / 2 - 100, yOffset, 200, 20) .build()); } private void onDropRateButtonPressed(String itemName) { // Lógica para alterar o drop rate do item/mob selecionado // Aqui, vamos apenas incrementar o valor como exemplo int currentRate = dropRates.get(itemName); dropRates.put(itemName, currentRate + 5); // Aumenta o drop rate em 5% } private void onSavePressed() { // Lógica para salvar as configurações (temporariamente apenas na memória) // Vamos apenas imprimir para verificar dropRates.forEach((item, rate) -> { System.out.println("Item: " + item + " | Novo Drop Rate: " + rate + "%"); }); // Fecha a tela após salvar Screen pGuiScreen = null; assert this.minecraft != null; this.minecraft.setScreen(pGuiScreen); } @Override public void render(GuiGraphics guiGraphics, int mouseX, int mouseY, float partialTicks) { this.renderBackground(guiGraphics); guiGraphics.blit(BACKGROUND_TEXTURE, this.width / 2 - 128, this.height / 2 - 128, 0, 0, 256, 256, 256, 256); super.render(guiGraphics, mouseX, mouseY, partialTicks); } }  
    • Also add the latest.log from /logs/
    • I was hoping I could get some help with this weird crash. I've hosted many servers before and never had this issue. Now and then the server crashed with "Exception ticking world". Everywhere I looked I rarely found any info on it (usually found ticking entity instead). Any advice I did get (mostly from the modpack owner's discord) was "We don't know and it's near impossible to find out what it is". Here is the crash report:   Description: Exception ticking world java.util.ConcurrentModificationException     at java.util.HashMap$HashIterator.nextNode(Unknown Source)     at java.util.HashMap$KeyIterator.next(Unknown Source)     at net.minecraft.entity.EntityTracker.sendLeashedEntitiesInChunk(EntityTracker.java:386)     at net.minecraft.server.management.PlayerChunkMapEntry.sendToPlayers(PlayerChunkMapEntry.java:162)     at net.minecraft.server.management.PlayerChunkMap.tick(SourceFile:165)     at net.minecraft.world.WorldServer.tick(WorldServer.java:227)     at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:756)     at net.minecraft.server.dedicated.DedicatedServer.updateTimeLightAndEntities(DedicatedServer.java:397)     at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:668)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)     at java.lang.Thread.run(Unknown Source)   If you want the full version, I can link a pastebin if needed. Modpack link: https://www.curseforge.com/minecraft/modpacks/multiblock-madness Some helpful information is that: It seems to only happen when I leave my void world to enter the overworld. Only happens 5-10% of the time. Only happens when leaving the void world, and only the void world. I know it's a slim chance someone could help, but it'd be greatly appreciated.
    • thanks a lot bro i knew i shouldve gone on the actual website instead of the discord
    • Minecraft Version? Reinstall Java 17 and/or Java 21 If this is still not working, run jarfix https://johann.loefflmann.net/de/software/jarfix/index.html
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.