Jump to content

1.19.2 - Multiblock Handling, Custom block Function gets called multiple times before creating Custom Block


Nalator

Recommended Posts

Hello everyone, I'm making this post to seek help for my modded block,
It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this : 
8272e5adc60153bf51744e60a7d39375.gif


The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) : 
cf503eebf6922efdb94c1c442565a052.gif

The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :

 

Old Block Fields set
BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6}
Old Block Fields set
BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6}
Frozen Block Entity set
BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6}
Frozen Block Entity set
BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6}

here is the code inside my custom "freeze" item : 
 

@Override
    public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {
        if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {
            BlockPos blockPos = pContext.getClickedPos();
            BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));
            if (secondBlockPos != null) {
                createFrozenBlock(pContext, secondBlockPos);
            }
            createFrozenBlock(pContext, blockPos);
            return InteractionResult.SUCCESS;
        }
        return super.useOn(pContext);
    }


    public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {
        BlockState oldState = pContext.getLevel().getBlockState(blockPos);
        BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;
        CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;
        if (oldBlockEntity != null) {
            pContext.getLevel().removeBlockEntity(blockPos);
        }
        BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);
        pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);
    }


    public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {
        BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();
        ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);
        return FrozenBlock;
    }

 

Link to comment
Share on other sites

Fixed the problem by changing the way the OldBlockFields are passed to the FrozenBlock Entity :
 

public FrozenBlockEntity(BlockPos blockPos, BlockState blockState) {
        super(BlockRegister.FROZEN_BLOCK_ENTITY.get(), blockPos, blockState);
        this.frozenBlockPos = blockPos;
        this.frozenBlock = ((FrozenBlock) blockState.getBlock()).getOldBlockState() != null ? ((FrozenBlock) blockState.getBlock()).getOldBlockState() : Blocks.AIR.defaultBlockState();
        this.frozenEntity = ((FrozenBlock) blockState.getBlock()).getOldBlockEntity();
        this.frozenEntityData = ((FrozenBlock) blockState.getBlock()).getOldBlockEntityData();
    }

    public FrozenBlockEntity(BlockPos blockPos, BlockState blockState, BlockState oldBlockState, @Nullable BlockEntity frozenBlockEntity, @Nullable CompoundTag frozenEntityData) {
        super(BlockRegister.FROZEN_BLOCK_ENTITY.get(), blockPos, blockState);
        this.frozenBlockPos = blockPos;
        this.frozenBlock = oldBlockState != null ? oldBlockState : Blocks.AIR.defaultBlockState();
        this.frozenEntity = frozenBlockEntity;
        this.frozenEntityData = frozenEntityData;
    }

spacer.png

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.