Jump to content

[1.20.2] Textures for Block States that worked on 1.16 for Tile Entity are not working for Block Entity


Recommended Posts

Posted (edited)

I am migrating a mod from 1.16.5 to 1.20.2

The version for 1.16.5 can be found here https://github.com/beothorn/automataCraft

For the block called automata_start, it uses TileEntities and has blockstates, model/block and textures on json files.

This is currently working fine on 1.16.5 https://github.com/beothorn/automataCraft/tree/master/src/main/resources/assets/automata

For 1.20.2 I migrated the logic from TileEntities to BlockEntity.

The mod is working fine. All blocks and Items are working with the correct textures except for the textures for each state of the automata_start block.

No changes where made to the json files. This is the branch I am working on (there were some refactorings, but all is basically the same):

https://github.com/beothorn/automataCraft/tree/1_20/src/main/resources/assets/automata

The only difference I can think that may be related is that i had to implement createBlockStateDefinition on the BaseEntityBlock:

https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L43

This is driving me crazy.

I know the jsons are being loaded as I put a breakpoint at `net.minecraft.client.resources.model.ModelBakery#loadModel` and I can see BlockModelDefinition.fromJsonElement being called with automata_start.

I also printed the state from the arguments of the tick function call and they look correct (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/Ticker.java#L32 ):

blockState Block{automata:automata_start}[state=loadreplaceables]

In game, all I see is the no textures. I think it is weird it is not the "missing texture" texture so I think it may be related to the material, but I had no success tweaking it (https://github.com/beothorn/automataCraft/blob/1_20/src/main/java/br/com/isageek/automata/automata/AutomataStartBlock.java#L37).

 

public static final Property<AutomataStartState> state = EnumProperty.create("state", AutomataStartState.class);
    private final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType;
    private final Map<String, RegistryObject<Block>> registeredBlocks;

    public AutomataStartBlock(
        final AtomicReference<RegistryObject<BlockEntityType<?>>> blockEntityType,
        final Map<String, RegistryObject<Block>> registeredBlocks
    ) {
        super(BlockBehaviour.Properties.of().mapColor(MapColor.STONE).strength(1.5F, 6.0F));
        this.blockEntityType = blockEntityType;
        this.registeredBlocks = registeredBlocks;
        this.registerDefaultState(this.getStateDefinition().any().setValue(state, AutomataStartState.LOAD_REPLACEABLES));
    }

    @Override
    protected void createBlockStateDefinition(StateDefinition.Builder<Block, BlockState> stateBuilder) {
        stateBuilder.add(state);
    }

 

 

spacer.png

So my cry for help is, anyone has any ideas?

Is there a way to easily debug this, for example somewhere where I can list the textures for a given state, or make sure this is loaded?

 

Thanks in advance for the hints :)

Edited by Beothorn
Forgot to add some links and finish the post
Link to comment
Share on other sites

I also tried pointing a regular block to the texture supposed to be used on the block state and it rendered. So the texture and the model json are valid and the issue is specific for the block entity.

Link to comment
Share on other sites

Wow, thanks @scientistknight1 ! That was exactly it.

The issue:

I was extending BaseEntityBlock, which implements getRenderShape as invisible for some reason:

public abstract class BaseEntityBlock extends Block implements EntityBlock {
   ...
   public RenderShape getRenderShape(BlockState p_49232_) {
      return RenderShape.INVISIBLE;
   }
   ...
}

Looking at the Implementation on Block, it calls BlockBehaviour, which returns RenderShape.MODEL. Overriding it on my Entity did the trick.
 

public class AutomataStartBlock extends BaseEntityBlock {

    ...
    @Override
    public RenderShape getRenderShape(BlockState p_49232_) {
        return RenderShape.MODEL;
    }
	...
}

It now works. I wonder why why BaseEntityBlock returns INVISIBLE, though.

Link to comment
Share on other sites

I'm guessing that's so people can implement their own custom animated models? I really don't know though, since I've never had to use that at all. I just know that you can have more control over a block entity model than over a standard block model, as well as use animations. I'm glad I could help, though!

  • Like 1
Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hallo all! I'm working on a custom mod pack for a few friends an I. However, whenever I launch it, it crashes and returns this error code. It appears to be crashing while trying to render some sprites from different mods, but I can't find a way to fix this.      The game crashed whilst stitching Error:      net.minecraft.client.renderer.texture.StitcherException:      Unable to fit: minecolonies:entity/citizen/nether/noblemale3_b - size: 128x64 -      Maybe try a lower resolution resourcepack? Here's the pastebin of the crash report: https://pastebin.com/17hgAPFS
    • when i join it looks normal until i look a mob or i have some thing in my hand and my screen starts turning different colors when i look around. i can see my inventory and the menu but not mobs or blocks in my hand I've tried to turn off the anti virus  uninstall and reinstalling the best driver  going back from version 20 to 8 and putting a ton of ram into minecraft. if i could get any help. thank you
    • Hi fellow minecrafter,   We've got exciting news from the Pacific Laboratory for Artificial Intelligence (PLAI) at UBC! We're merging the worlds of Minecraft and AI research, and you're invited to join through our platform, plaicraft.ai, to aid our data collection process. It's not just playing games; it's contributing to cutting-edge AI research.   BetterStructures and more!!: We want to make the server as fun as possible for everyone so we recently added a bunch of structural plugins that adds over a hundred of new structures and sites for you to explore and challenge. We are also working on PVP, bedwars and skyblock content, which will make the server even more fun!   Here’s how you can get involved! -Register on plaicraft.ai with your email(you can fake one, as long as you can receive email from it it's fine). -Complete a consent form. -Play Minecraft and contribute to science! (all you need is a Chrome browser and a steady internet, you'll be playing on VM)   Why You Should Participate? -Support AI Research: Your gameplay directly contributes to important AI advancements.  -Free Minecraft Access: Enjoy the game without any cost. -We have shaders and a bunch of cool mods loaded on our instances  -Great Community: Our server currently has a fantastic community, with many awesome players you can meet.   Elephant in the room: Now I want to address some obvious concerns, I sure did a good job making us sound like a scam by the above content. I know that the "free Minecraft" thing has always been taboo in the Minecraft community. So how can I prove to you that this is not a scam? - The easiest way and most official way is that we are approved by the University of British Columbia ethics board, our BREB number is H23-02389. You can verify this case number yourself. - The harder way is that I'll explain the technical details of this project and why we choose to provide free Minecraft. So the goal of this project is very similar to the paper MineDojo or MineRL, we want to collect a multi-modal dataset that consists of video, audio, keyboard and mouse movement. Minecraft has been a very important simulation environment for the ML community and there are tons of papers related to it. Now we obviously don't have enough money like those big tech companies who can just pay people to play, so we have to turn to the Minecraft community. To record all the data mentioned, there needs to be a lot of setup and coding, and it's definitely impossible for us to ask people to run these recording programs on their personal computers. So we carefully configured the AWS EC2 instance to run Minecraft alongside the programs. And that's where and why we also provide you with free Minecraft licenses, of course, we are not giving the account to you, just allowing you to be able to play Minecraft on these instances. You might ask, "Why can't I log in with my account on the instances?", that's because first login with your personal Minecraft account is another privacy risk; second not all our target audiences have an account; and lastly we restricted a lot on what you can do on the instance, basically all you can do is play Minecraft and that's all the data we want, allowing you to log in will make things complicated to control.   For more information on the project and the team, visit Dr. Frank Wood’s website or follow @frankdonaldwood on Twitter. You can also learn more about PLAI lab research on our website (just search ubc plai). Join us in transforming your gaming experience into a meaningful contribution to AI research. Let’s push the boundaries of what gaming can achieve together! Happy plaiing!   Best,  The PLAI Team
    • The mod has improved a lot from yesterday just 1 last issue  Here's the crash report- https://pastebin.com/k2A1BAKn   Please help, Thanks.
    • Take Your Gaming Experience to the Next Level with These Essential Tools   If you're a Minecraft enthusiast, you've likely experienced the need to customize your world and server to make it more exciting and challenging. Fortunately, there's a perfect solution for you: https://menzatyx.xyz, the website that offers a wide selection of free and pre-configured Minecraft plugins. At https://menzatyx.xyz, you'll find a diverse range of plugins that will allow you to take your gaming experience to the next level. From server management tools to mods that add new functionalities, each of these plugins has been carefully selected and configured, so you can enjoy a more personalized and thrilling Minecraft experience. One of the primary benefits of using these pre-configured plugins is the ease of implementation. You no longer have to spend hours configuring and adjusting each individual plugin. Simply download the package that best suits your needs, and you're good to go! You'll be able to enjoy all the features and improvements without investing too much time and effort. From plugins that enhance the security of your server to mods that add new game modes, the variety offered by https://menzatyx.xyz is impressive. Moreover, as these are free plugins, you can access these tools without spending a single penny. It's the perfect opportunity to take your Minecraft experience to the next level without affecting your wallet! Whether you're a casual player or an experienced server administrator, at https://menzatyx.xyz you'll find the Minecraft plugins you need to personalize and enhance your game. Visit the website now and discover how you can transform your Minecraft world into something unique and thrilling!
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.