Jump to content

Recommended Posts

Posted (edited)

I am attempting to create a mod that adds custom statistics to Minecraft.

I've had some help from LexManos on the Discord server, but posting a lot of what I posted in the #mod-dev-support-1.20 channel here to have a more permanent spot for discussion.

 

---

 

Minecraft creates their stats like this:

Spoiler
public class Stats {
   public static final StatType<Block> BLOCK_MINED = makeRegistryStatType("mined", BuiltInRegistries.BLOCK);
   public static final StatType<Item> ITEM_CRAFTED = makeRegistryStatType("crafted", BuiltInRegistries.ITEM);
   public static final StatType<EntityType<?>> ENTITY_KILLED = makeRegistryStatType("killed", BuiltInRegistries.ENTITY_TYPE);
   public static final StatType<ResourceLocation> CUSTOM = makeRegistryStatType("custom", BuiltInRegistries.CUSTOM_STAT);
   public static final ResourceLocation LEAVE_GAME = makeCustomStat("leave_game", StatFormatter.DEFAULT);
   public static final ResourceLocation PLAY_TIME = makeCustomStat("play_time", StatFormatter.TIME);
  
   private static ResourceLocation makeCustomStat(String p_13008_, StatFormatter p_13009_) {
      ResourceLocation resourcelocation = new ResourceLocation(p_13008_);
      Registry.register(BuiltInRegistries.CUSTOM_STAT, p_13008_, resourcelocation);
      CUSTOM.get(resourcelocation, p_13009_);
      return resourcelocation;
   }

   private static <T> StatType<T> makeRegistryStatType(String p_13011_, Registry<T> p_13012_) {
      Component component = Component.translatable("stat_type.minecraft." + p_13011_);
      return Registry.register(BuiltInRegistries.STAT_TYPE, p_13011_, new StatType<>(p_13012_, component));
   }
}

and some of the registries in the code above are located in BuiltInRegistries.java like this:

Spoiler
/**
 * @deprecated Forge: Use {@link net.minecraftforge.registries.ForgeRegistries#STAT_TYPES} instead.
 */
@Deprecated
public static final Registry<StatType<?>> STAT_TYPE = forge(Registries.STAT_TYPE, (p_259967_) -> {
    return Stats.ITEM_USED;
});

public static final Registry<ResourceLocation> CUSTOM_STAT = registerSimple(Registries.CUSTOM_STAT, (p_259833_) -> {
    return Stats.JUMP;
});

and the ForgeRegistries#STAT_TYPES looks like this:

Spoiler
public static final IForgeRegistry<StatType<?>> STAT_TYPES = active(Keys.STAT_TYPES);

So, attempting to follow that and the forge documentation on registries I arrived at this:

Spoiler
public class SampleModStatisticsRegistry {

    public static final DeferredRegister<StatType<?>> STATISTICS = DeferredRegister.create(ForgeRegistries.STAT_TYPES, SampleMod.MODID);

    public static final RegistryObject<StatType<?>> FIREWORK_BOOSTS_USED = STATISTICS.register("firework_boosts_used",
            () -> makeRegistryStatType("firework_boosts_used", BuiltInRegistries.CUSTOM_STAT));

    // code stolen from Minecraft's Stats file
    public static <T> StatType<T> makeRegistryStatType(String p_13011_, Registry<T> p_13012_) {
        Component component = Component.translatable("stat_type.minecraft." + p_13011_);
        return Registry.register(BuiltInRegistries.STAT_TYPE, p_13011_, new StatType<>(p_13012_, component));
    }
}

Clearly, registering a stat twice in a row is the wrong way to do it, but the makeRegistryStatType function was used as it does give the correct return type for the code I had come up with so far.

 

---

 

At this point the game crashes upon trying to use Player#awardStat, because of a NPE that occurs in Stat#locationToKey.

Spoiler
java.lang.NullPointerException: Cannot invoke "net.minecraft.resources.ResourceLocation.toString()" because "p_12866_" is null
	at net.minecraft.stats.Stat.locationToKey(Stat.java:26) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading}
	at net.minecraft.stats.Stat.buildName(Stat.java:22) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading}
	at net.minecraft.stats.Stat.<init>(Stat.java:15) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading}
	at net.minecraft.stats.StatType.lambda$get$0(StatType.java:25) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading}
	at java.util.Map.computeIfAbsent(Map.java:1054) ~[?:?] {re:mixin}
	at net.minecraft.stats.StatType.get(StatType.java:24) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading}
	at net.minecraft.stats.StatType.get(StatType.java:38) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading}
	at net.minecraft.world.entity.player.Player.awardStat(Player.java:1364) ~[forge-1.20.2-48.1.0_mapped_official_1.20.2-recomp.jar%23199!/:?] {re:classloading,pl:accesstransformer:B}

Which happens in the 2nd Stat#locationToKey in the Stat#buildName function.

Spoiler
public static <T> String buildName(StatType<T> p_12863_, T p_12864_) {
    return locationToKey(BuiltInRegistries.STAT_TYPE.getKey(p_12863_)) + ":" + locationToKey(p_12863_.getRegistry().getKey(p_12864_));
}

The .getRegistry returns the this.registry class variable with a value of {MappedRegistry@#####} "Registry[ResourceKey[minecraft:root / minecraft:custom_stat] (Stable)]"

The value passed into .getKey is "samplemod:fireworks_boosts_used" but the reference found is null.

So Lex's conclusion was that "[I'm] passing in null because the registry doesnt have an entry for your custom stat instance. So.. register your custom stat instance in that registry."

 

---

 

So I suppose at this point my questions are

1. How can I create a supplier that returns a Supplier<? extends StatType<?>> to replace the () -> makeRegistryStatType("firework_boosts_used", BuiltInRegistries.CUSTOM_STAT) line of code.

2. Is my registry entry public static final RegistryObject<StatType<?>> FIREWORK_BOOSTS_USED the correct type?

3. Do I need to do anything additional, like create my own StatType<> or my own Stat<> ?

Edited by Toasterkid
Adding spoiler blocks to better format the post and make it easier to scroll through.
Posted (edited)

At an attempt at answering my first question I thought I might be able to change the code to this

public class SampleModStatisticsRegistry {

    public static final DeferredRegister<StatType<?>> STATISTICS = DeferredRegister.create(ForgeRegistries.STAT_TYPES, SampleMod.MODID);

    public static final RegistryObject<StatType<?>> FIREWORK_BOOSTS_USED = STATISTICS.register("firework_boosts_used", 
            () -> new StatType<>(ForgeRegistries.STAT_TYPES, Component.literal("firework_boosts")));
  
}

or to this

public class SampleModStatisticsRegistry {

    public static final DeferredRegister<StatType<?>> STATISTICS = DeferredRegister.create(ForgeRegistries.STAT_TYPES, SampleMod.MODID);

    public static final RegistryObject<StatType<?>> FIREWORK_BOOSTS_USED = STATISTICS.register("firework_boosts_used",
            () -> new StatType<>(BuiltInRegistries.STAT_TYPE, Component.literal("firework_boosts")));
  
}

but for the first code snippet the StatType constructor requires a Registry not an IForgeRegistry

and for the second code snippet we run into the same NPE issue from above.

Edited by Toasterkid
Posted (edited)

Also doubting if my usage of awardStat is correct.

It just looks like this right now:

player.awardStat(SampleModRegistry.FIREWORK_BOOSTS_USED.getId());

but there are places vanilla Minecraft uses the function like this:

.awardStat(Stats.CUSTOM.get(Stats.DAMAGE_BLOCKED_BY_SHIELD)
Edited by Toasterkid

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I am trying to make 2 recipes for a ruby. The first one is turning a block into a ruby and the other one is 9 nuggets into a ruby. But I keep on getting a error java.lang.IllegalStateException: Duplicate recipe rubymod:ruby   Any help would be great on how to fix it
    • Hello everyone, i'm new with programing Mods, and will need a lot of your help if possible,  Im trying to make a new GUI interface responsible to control the Droprate of game, it will control de loot drop and loot table for mobs and even blocks, but i try to make a simple Gui Screen, and wenever i try to use it, the game crash's with the error message in the subject, here is the code im using to:  IDE: IntelliJ Comunity - latest version Forge: 47.3.0 Minecraft version: 1.20.1 mapping_channel: parchment mapping_version=2023.09.03-1.20.1 Crash report link: https://pastebin.com/6dV8k1Fw   Code im using is:    package createchronical.droprateconfig; import com.mojang.blaze3d.systems.RenderSystem; import net.minecraft.client.gui.GuiGraphics; import net.minecraft.client.gui.components.Button; import net.minecraft.client.gui.screens.Screen; import net.minecraft.network.chat.Component; import net.minecraft.resources.ResourceLocation; import java.util.HashMap; import java.util.Map; public class ConfigScreen extends Screen { private static final ResourceLocation BACKGROUND_TEXTURE = new ResourceLocation("droprateconfig", "textures/gui/config_background.png"); // Mapa de mobs e itens com seus respectivos drop rates private final Map<String, Integer> dropRates = new HashMap<>(); public ConfigScreen() { super(Component.literal("Configurações de Drop Rate")); // Inicializa com valores de drop rate padrão dropRates.put("Zombie", 10); // Exemplo de mob dropRates.put("Creeper", 5); // Exemplo de mob dropRates.put("Iron Ore", 50); // Exemplo de item dropRates.put("Diamond", 2); // Exemplo de item } @Override protected void init() { // Cria um botão para cada mob/item e adiciona na tela int yOffset = this.height / 2 - 100; // Posicionamento inicial for (Map.Entry<String, Integer> entry : dropRates.entrySet()) { String itemName = entry.getKey(); int dropRate = entry.getValue(); // Cria um botão para cada mob/item this.addRenderableWidget(Button.builder( Component.literal(itemName + ": " + dropRate + "%"), button -> onDropRateButtonPressed(itemName) ).bounds(this.width / 2 - 100, yOffset, 200, 20).build()); yOffset += 25; // Incrementa a posição Y para o próximo botão } // Adiciona o botão de "Salvar Configurações" this.addRenderableWidget(Button.builder(Component.literal("Salvar Configurações"), button -> onSavePressed()) .bounds(this.width / 2 - 100, yOffset, 200, 20) .build()); } private void onDropRateButtonPressed(String itemName) { // Lógica para alterar o drop rate do item/mob selecionado // Aqui, vamos apenas incrementar o valor como exemplo int currentRate = dropRates.get(itemName); dropRates.put(itemName, currentRate + 5); // Aumenta o drop rate em 5% } private void onSavePressed() { // Lógica para salvar as configurações (temporariamente apenas na memória) // Vamos apenas imprimir para verificar dropRates.forEach((item, rate) -> { System.out.println("Item: " + item + " | Novo Drop Rate: " + rate + "%"); }); // Fecha a tela após salvar Screen pGuiScreen = null; assert this.minecraft != null; this.minecraft.setScreen(pGuiScreen); } @Override public void render(GuiGraphics guiGraphics, int mouseX, int mouseY, float partialTicks) { this.renderBackground(guiGraphics); guiGraphics.blit(BACKGROUND_TEXTURE, this.width / 2 - 128, this.height / 2 - 128, 0, 0, 256, 256, 256, 256); super.render(guiGraphics, mouseX, mouseY, partialTicks); } }  
    • Also add the latest.log from /logs/
    • I was hoping I could get some help with this weird crash. I've hosted many servers before and never had this issue. Now and then the server crashed with "Exception ticking world". Everywhere I looked I rarely found any info on it (usually found ticking entity instead). Any advice I did get (mostly from the modpack owner's discord) was "We don't know and it's near impossible to find out what it is". Here is the crash report:   Description: Exception ticking world java.util.ConcurrentModificationException     at java.util.HashMap$HashIterator.nextNode(Unknown Source)     at java.util.HashMap$KeyIterator.next(Unknown Source)     at net.minecraft.entity.EntityTracker.sendLeashedEntitiesInChunk(EntityTracker.java:386)     at net.minecraft.server.management.PlayerChunkMapEntry.sendToPlayers(PlayerChunkMapEntry.java:162)     at net.minecraft.server.management.PlayerChunkMap.tick(SourceFile:165)     at net.minecraft.world.WorldServer.tick(WorldServer.java:227)     at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:756)     at net.minecraft.server.dedicated.DedicatedServer.updateTimeLightAndEntities(DedicatedServer.java:397)     at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:668)     at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:526)     at java.lang.Thread.run(Unknown Source)   If you want the full version, I can link a pastebin if needed. Modpack link: https://www.curseforge.com/minecraft/modpacks/multiblock-madness Some helpful information is that: It seems to only happen when I leave my void world to enter the overworld. Only happens 5-10% of the time. Only happens when leaving the void world, and only the void world. I know it's a slim chance someone could help, but it'd be greatly appreciated.
    • thanks a lot bro i knew i shouldve gone on the actual website instead of the discord
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.