Search the Forums BEFORE making a new post.

[1.6.4]Disabling particles in updateSpawner() based on outside info

Posted January 20, 201411 yr

Hey all,

this seems simple enough but ive tried multiple ways to no avail. In a mob spawners base logic class in the updateSpawner() method there are some particles that are always running:

public void updateSpawner()
    {
        if (this.canRun())
        {        	
            double d0;

            if (this.getSpawnerWorld().isRemote)
            {
                double d1 = (double)((float)this.getSpawnerX() + this.getSpawnerWorld().rand.nextFloat());
                double d2 = (double)((float)this.getSpawnerY() + this.getSpawnerWorld().rand.nextFloat());
                d0 = (double)((float)this.getSpawnerZ() + this.getSpawnerWorld().rand.nextFloat());
                this.getSpawnerWorld().spawnParticle("smoke", d1, d2, d0, 0.0D, 0.0D, 0.0D);
                this.getSpawnerWorld().spawnParticle("flame", d1, d2, d0, 0.0D, 0.0D, 0.0D);

Ive managed to get spawning to stop on redstone signal but the particles still continue. I want them to stop as well. So far I have:

public void onNeighborBlockChange(World world, int par2, int par3, int par4, int par5)
    {
    	TileEntityCustomSpawner te = (TileEntityCustomSpawner)world.getBlockTileEntity(par2, par3, par4);
    if (world.isBlockIndirectlyGettingPowered(par2, par3, par4)) 
    {
    	te.signal = true;
    } 
    else 
    {
    	te.signal = false;
    }
    }

in my Block class and my TE class has this:

public void updateEntity()
    {
    	if(this.signal == false)
    	{
        this.field_98050_a.updateSpawner();
        super.updateEntity();
    	}

    }

As stated this stops spawning but particles still continue, can someone explain how this is the case and what I can do to stop it, ive got code blindness from staring at this problem for hours.

Thanks.

Quote

January 20, 201411 yr

Author

ok, so i think my problem is down to desynch between server and client (ive done some digging and a lot of people hit this snag when first playing with tile entities it seems). Just so im sure this is the case I placed a print statement inside the updateSpawner method and printed the spawnDelay. This is the printout from my mobspawner:

2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 20
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 20
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 19
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 19
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 20
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 18
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 19
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 17
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 16
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 18
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 15
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 17
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 14
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 16
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 13
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 15
2014-01-20 21:29:27 [iNFO] [sTDOUT] Delay 12
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 11
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 14
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 10
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 13
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 9
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 12
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 8
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 11
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 7
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 6
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 10
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 5
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 9
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 4
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 8
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 3
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 7
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 2
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 1
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 6
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 5
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 465
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 4
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 464
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 3
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 463
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 462
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 2
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 461
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 1
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 460
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 459
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:29:28 [iNFO] [sTDOUT] Delay 458

now I guessed one of those is client and 1 is server. So I put the print inside the "if (this.getSpawnerWorld().isRemote)", the result was this:

2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 20
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 19
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 20
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 19
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 18
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 17
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 16
2014-01-20 21:31:44 [iNFO] [sTDOUT] Delay 15
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 14
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 13
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 12
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 11
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 10
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 9
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 8
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 7
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 6
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 5
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 4
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 3
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 2
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 1
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:31:45 [iNFO] [sTDOUT] Delay 0
2014-01-20 21:31:46 [iNFO] [sTDOUT] Delay 0

and it stayed at 0 even though the mobspawner was still spawning. Now I have:

public Packet getDescriptionPacket()
    {
        NBTTagCompound nbttagcompound = new NBTTagCompound();
        this.writeToNBT(nbttagcompound);
        return new Packet132TileEntityData(this.xCoord, this.yCoord, this.zCoord, 1, nbttagcompound);
    }
    
    public void onDataPacket(INetworkManager net, Packet132TileEntityData pkt)
    {
            NBTTagCompound tag = pkt.data;
            readFromNBT(tag);
    }

in my Tile Entity class and I believe they are structured correctly, is there a piece to this puzzle im missing? or something im not understanding (probably the case).

Quote

January 20, 201411 yr

Author

ok so it turns out that doing the below when it gets a redstone signal:

TileEntityCustomSpawner spawner = (TileEntityCustomSpawner)world.getBlockTileEntity(x, y, z);
    		
spawner.getSpawnerLogic().spawnDelay = -1;

then, putting this in the canRun of the spawner logic class:

if(this.spawnDelay == -1)
    	{
    		return false;
    	}

makes everything work perfectly, I just set the spawn delay back to 20 when the redstone signal goes off. Now to test how it holds up on a server, I have a feeling it might not work so well...

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/15473-164disabling-particles-in-updatespawner-based-on-outside-info/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

I need help with a custom structure in my mod.

Alright, I took a look at the code... again. I assume that you are using 1.20.1, as from your last post. First, let's get the "Have you tried putting it in rice?" questions out of the way first. Have you looked from world height to bedrock? Notice anything strange in that range? Did you set the bounds of your structure properly? Have you checked multiple different locations? Did you pray before you ran your mod? Alright, now assuming that you did all of that, try this! Pray really hard, and open your log file. CONTROL+F search for the following string: "Failed Start with id". Hopefully your praying payed off and manifested this message into reality, because if not, this could be real rough. In the case that you do not see this message, the problem could be literally almost anything without any code to reference. There is a significant amount of things that could go wrong when generating structures, and it's all up to how you programmed the Structure Pieces class and your Structure class. If none of this works, please post your code here.

My previous post paragraph completely ignored the main bulk of the things you said in your post. Now I'll take it into account here. I notice that you said this one scary word: "structure block." Are you trying to use the datapack method to generate custom structures? If you are, I'm not exactly sure if this is the place for that kind of help, as I believe the people here are more experienced with PROGRAMMING WITH JAVA IN FORGE rather than operating general Minecraft datapacks. Perhaps somebody here will be more familiar with the datapack method of generating structures, but I'm not too sure. If you are trying to use the datapack method (which if you have forge and enough comfortability with java, then I would strongly recommend just making a mod instead), there is probably a more general Minecraft forum somewhere to ask in. If you are feeling up to it, you can actually very easily make a custom structure with this very old MCEdit method I remember from way back. I'm not sure if it could still work with 1.20.1, but it's worth a shot. Basically, you would just build a structure in a custom world, load that world in MCEdit, and use MCEdit to convert it into java code. I remember somebody made a program to "compress" the code that was generated from MCEdit, but I wasn't able to find the program. Sorry man.

Anyways, if you are stickin' with the datapack rotue, then I'm sorry, but I don't have enough experience to help you with that, but I wish you the best of luck!

By Jackson Perr · 51 minutes ago51 min
300+ Modpack keeps crashing

Alr, I just looked at the individual mods here (MixinBooter and Iris Flywheel Compat). I'm going to try my best to add some input here for when you get back next morning WITHOUT making a huge text wall again. Before your exception is thrown here and your game crashes, in your log you should see something like this: "Error loading class:". Try a CONTROL+F search to find it in your log file. If you do not see this message, then I really hope you have a bible on hand and a good prayer in mind, because you might be screwed. Hopefully that's not the case though. If you find this message in your log file, please post it here. Also, could you provide the name of the modpack you are using?

One more thing I should add. I'm not exactly sure that removing Iris Flywheel Compat would work, but I would encourage you to do so anyways just in case it does work. If it does not work, then the problem is 100% being caused by a bad transformer function, in which case you should provide a link to your modpack. ONE MORE THING: if you are using any other additional mods in your modpack, please provide them here, even if they are hacked clients; I cannot help you with anything revolving around hacked clients, but knowing if you have a hacked client mod will still help determine the source of the problem. Hopefully removing Iris-Compat works...

By Jackson Perr · 2 hours ago2 hr
300+ Modpack keeps crashing

Thank you both so much! I'll try it tomorrow since it's quite late.

By EditorMillie · 6 hours ago6 hr
300+ Modpack keeps crashing

Not sure if the wall of text is helpful. It looks like a Mixin from Iris is failing. Try loading without that and see if that helps.

By Jonathing · 6 hours ago6 hr
300+ Modpack keeps crashing

Hmmmmm... It looks like your problem might be being cause by a transformer function that has previously failed. Basically, the game uses transformers to literally rewrite Minecraft's code. Think of these functions like a courier service. Let's say you buy a package from FedEX. They put your package in their big ol' trucks and send 'em off. However, let's say that this truck suddenly gets stopped to be searched, e.g. the transformer editing the package (the code). The guy searching the truck finds your package and he goes, "Hey, man, this package is a bit strange so we gotta' change it a bit, here-" and he opens up the package, removes a few things, adds a few things, and finally puts the package back in the truck and sends it off. When you get your package (again, the code), it will be changed by the man who searched the truck (again, the transformer). Everything went alright, HOORAY! Now, let's say this man searching your truck runs into a bit of an issue while modifying your package, and he... gets struck by and asteroid or something, idk. Because he failed so catastrophically, you will NEVER get your package, so the truck will just have to drive off without your package. Now let's say we have another guy on the track this time that wants to search the truck, and let's say he's looking for that same package that the first guy messed up with. He goes into the truck, looks around a bit, and says, "wth, there ain't nothin' here man." Then he calls the police and says something like, "ClassMetadataNotFoundException." This could be what has happened here, although I'm not too positive. But basically, the entire package (the code needed to be modified) is GONE! But here's the thing, the exception shown in your crash report is NOT going to be the one that's actually of note, because the original guy didn't throw an exception. What you need is evidence of what failed to change the class beforehand. Here's what you can do. In your log file, try finding the point where the exception is initially thrown, then try scrolling up and see what's there. If you see anything of note, please report it here. If all else fails and nobody is able to help you here, then as a last resort you could post the log file, although I wouldn't exactly recommend this right off the bat, who knows what might be in there.

Hope this helps ya' out man!

By Jackson Perr · 6 hours ago6 hr

There are no registered users currently online

Sign In

[1.6.4]Disabling particles in updateSpawner() based on outside info

Featured Replies

Join the conversation

Posts

I need help with a custom structure in my mod.

300+ Modpack keeps crashing

300+ Modpack keeps crashing

300+ Modpack keeps crashing

300+ Modpack keeps crashing

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)