Jump to content

Recommended Posts

Posted

I am trying to render additional pieces onto the player model using the RenderPlayerEvent.Pre event. I basically watch the event and fire the .render() for a custom ModelRenderer class.

 

The render is only supposed to run on me (so only my player entity has a special model).

 

It seemed to work beautifully, until I joined a server and others around me noticed that when I was in their field of view, they too had the special model parts...but rotated to fit the orientation of my player. Needless to say, I would like to fix this, as would everyone else with random floating body parts.

 

Here is the code:

@ForgeSubscribe
public void addReikaModel(RenderPlayerEvent.Pre evt) {
	RenderPlayer render = evt.renderer;
	EntityPlayer ep = evt.entityPlayer;
	float tick = evt.partialRenderTick;
	if (ep != null) {
		if ("Reika_Kalseki".equals(ep.getEntityName())) {
			//render.setRenderPassModel(modelReika);
			ReikaTextureHelper.bindFinalTexture(DragonAPICore.class, "/Reika/DragonAPI/Resources/reika_tex.png");
			GL11.glScaled(1, -1, 1);
			GL11.glFrontFace(GL11.GL_CW);
			modelReika.renderBodyParts(ep, tick);
			GL11.glFrontFace(GL11.GL_CCW);
			GL11.glScaled(1, -1, 1);
		}
	}
}

 

The very weird part is that I am using variable "ep" (the render player instance) to check the name of the player we should be rendering "on", yet somehow the rendering also happens for other players. However, the argument is still actually my player, because the rotation is that of my player entity.

Posted

Hi

 

My guess is:

(1) RenderPlayerEvent is called for all players being rendered on a client, not just the user. (that's just a guess, I haven't checked it)

(2) Your rendering routine uses the coordinates of the user for some reason, instead of the (non-user)player being rendered.

 

Adding System.out.println to your addReikaModel should show this pretty quickly if it's really the reason.

 

-TGG

Posted
  On 3/9/2014 at 11:10 AM, TheGreyGhost said:

Hi

 

My guess is:

(1) RenderPlayerEvent is called for all players being rendered on a client, not just the user. (that's just a guess, I haven't checked it)

(2) Your rendering routine uses the coordinates of the user for some reason, instead of the (non-user)player being rendered.

 

Adding System.out.println to your addReikaModel should show this pretty quickly if it's really the reason.

 

-TGG

That was one of the first things I tried. The result was as expected:

EntityClientPlayerMP['Reika_Kalseki'/1564, l='MpServer', x=-1148.29, y=8.16, z=-427.23] of class net.minecraft.client.entity.EntityClientPlayerMP

Posted

Hi

 

So I guess that's what prints out on your client, which seems to work as expected.

 

What prints out on the clients of other users looking at you?

 

@ForgeSubscribe
public void addReikaModel(RenderPlayerEvent.Pre evt) {
	RenderPlayer render = evt.renderer;
	EntityPlayer ep = evt.entityPlayer;
// add System.out.println here
	float tick = evt.partialRenderTick;
//...
		if ("Reika_Kalseki".equals(ep.getEntityName())) {
// add System.out.println here

 

-TGG

Posted
  On 3/9/2014 at 10:03 PM, TheGreyGhost said:

Hi

 

So I guess that's what prints out on your client, which seems to work as expected.

 

What prints out on the clients of other users looking at you?

 

@ForgeSubscribe
public void addReikaModel(RenderPlayerEvent.Pre evt) {
	RenderPlayer render = evt.renderer;
	EntityPlayer ep = evt.entityPlayer;
// add System.out.println here
	float tick = evt.partialRenderTick;
//...
		if ("Reika_Kalseki".equals(ep.getEntityName())) {
// add System.out.println here

 

-TGG

No idea, because they are using modpack-release versions of the mod and thus cannot have system prints.

Posted

Hi

 

In that case, I would suggest either you get someone else to run a client in a debugger, or you write to a disk file, or you change the player name from Reika to the name of one of the other players.  So you see will the weird bodypart rendering that they see when looking at you, and you can debug it.

 

-TGG

Posted
  On 3/10/2014 at 6:44 AM, TheGreyGhost said:

Hi

 

In that case, I would suggest either you get someone else to run a client in a debugger, or you write to a disk file, or you change the player name from Reika to the name of one of the other players.  So you see will the weird bodypart rendering that they see when looking at you, and you can debug it.

 

-TGG

 

Or, if your PC can handle it, you could just run a dedicated server, a client with "Reika_Kalseki" as username and a client with a random username in Eclipse, connect both clients to the server and see the results.

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

  Quote

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

Any word on this?

 

I needed to do some custom rendering as well, and Reika's method described above (assuming it works) might be just the thing. If Reika, or anybody else, figured out how to solve the issue, I'd love to know.

Posted
  On 3/11/2014 at 7:42 AM, SanAndreasP said:

  Quote

Hi

 

In that case, I would suggest either you get someone else to run a client in a debugger, or you write to a disk file, or you change the player name from Reika to the name of one of the other players.  So you see will the weird bodypart rendering that they see when looking at you, and you can debug it.

 

-TGG

 

Or, if your PC can handle it, you could just run a dedicated server, a client with "Reika_Kalseki" as username and a client with a random username in Eclipse, connect both clients to the server and see the results.

I tried that, and Eclipse tends to crash one of the two clients after a few seconds.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
    • Also remove VS Create Armor, createbigcannons and The Factory Must Grow
    • Add the latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.