Jump to content

[1.7.2] Glitchy Slabs


Godson

Recommended Posts

I'm starting to feel like an idiot for posting so many help threads. But there's not many places I can go to learn about 1.7's code.

 

Well, I've created a custom slab, and it works...Kinda.

 

Normally I'd be able to stack them up, and make them look like a full block. Instead, they do this. http://puu.sh/7pkr0.png

 

Here's the code for the slabs.

 

public class NegativeWoodSlabs extends BlockSlab {
public static final String[] field_150005_b = new String[] {"negative"};

public NegativeWoodSlabs(boolean p_i45437_1_)
    {
        super(p_i45437_1_, Material.wood);
    }

/**
     * Gets the block's texture. Args: side, meta
     */
    @SideOnly(Side.CLIENT)
    public IIcon getIcon(int p_149691_1_, int p_149691_2_)
    {
        return Mod1.NegativeOakPlanks.getIcon(p_149691_1_, p_149691_2_ & 7);
    }

    public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
    {
        return Item.getItemFromBlock(Mod1.NegativeOakSlab);
    }

    /**
     * Returns an item stack containing a single instance of the current block type. 'i' is the block's subtype/damage
     * and is ignored for blocks which do not support subtypes. Blocks which cannot be harvested should return null.
     */
    protected ItemStack createStackedBlock(int p_149644_1_)
    {
        return new ItemStack(Item.getItemFromBlock(Blocks.wooden_slab), 2, p_149644_1_ & 7);
    }

    public String func_150002_b(int p_150002_1_)
    {
        if (p_150002_1_ < 0 || p_150002_1_ >= field_150005_b.length)
        {
            p_150002_1_ = 0;
        }

        return super.getUnlocalizedName() + "." + field_150005_b[p_150002_1_];
    }
    
    @SideOnly(Side.CLIENT)
    public void getSubBlocks(Item p_149666_1_, CreativeTabs p_149666_2_, List p_149666_3_)
    {
        if (p_149666_1_ != Item.getItemFromBlock(Mod1.NegativeOakDoubleSlab))
        {
            for (int i = 0; i < field_150005_b.length; ++i)
            {
                p_149666_3_.add(new ItemStack(p_149666_1_, 1, i));
            }
        }
    }

    @SideOnly(Side.CLIENT)
    public void registerBlockIcons(IIconRegister p_149651_1_) {}
}

 

And the code for registering the slabs.

 

NegativeOakSlab = new NegativeWoodSlabs(false).setHardness(2.0F).setResistance(5.0F).setCreativeTab(tabNegative).setBlockName("NegativeOakSlab");
NegativeOakDoubleSlab = new NegativeWoodSlabs(true).setHardness(2.0F).setResistance(5.0F).setCreativeTab(tabNegative).setBlockName("NegativeOakDoubleSlab");

 

Not sure what I'm doing wrong, everything looks fine, it's similar to vanilla's code, so I don't see the problem...

I may ask questions asking for help, but I know what I'm doing. If my post is helpful in any way, give a "Thank You" in return, I'd really appreciate it.

Link to comment
Share on other sites

Sorry if bumping is against some rule or anything. But I had to. >_>

 

Le Bump.

I may ask questions asking for help, but I know what I'm doing. If my post is helpful in any way, give a "Thank You" in return, I'd really appreciate it.

Link to comment
Share on other sites

...Huh. I didn't even notice I sent that mistake in the code. Cause that's already fixed, and it still doesn't work. ._.

 

I'll just...repost the code...in case there are more mistakes I've already fixed from then and now.

 

public class NegativeWoodSlabs extends BlockSlab
{
    public static final String[] field_150005_b = new String[] {"negative"};
    private static final String __OBFID = "CL_00000337";

    public NegativeWoodSlabs(boolean p_i45437_1_)
    {
        super(p_i45437_1_, Material.wood);
        this.setCreativeTab(Mod1.tabNegative);
    }

    /**
     * Gets the block's texture. Args: side, meta
     */
    @SideOnly(Side.CLIENT)
    public IIcon getIcon(int p_149691_1_, int p_149691_2_)
    {
        return Mod1.NegativeOakPlanks.getIcon(p_149691_1_, p_149691_2_ & 7);
    }

    public Item getItemDropped(int p_149650_1_, Random p_149650_2_, int p_149650_3_)
    {
        return Item.getItemFromBlock(Mod1.NegativeOakSlab);
    }

    /**
     * Returns an item stack containing a single instance of the current block type. 'i' is the block's subtype/damage
     * and is ignored for blocks which do not support subtypes. Blocks which cannot be harvested should return null.
     */
    protected ItemStack createStackedBlock(int p_149644_1_)
    {
        return new ItemStack(Item.getItemFromBlock(Mod1.NegativeOakSlab), 2, p_149644_1_ & 7);
    }

    public String func_150002_b(int p_150002_1_)
    {
        if (p_150002_1_ < 0 || p_150002_1_ >= field_150005_b.length)
        {
            p_150002_1_ = 0;
        }

        return super.getUnlocalizedName() + "." + field_150005_b[p_150002_1_];
    }

    /**
     * returns a list of blocks with the same ID, but different meta (eg: wood returns 4 blocks)
     */
    @SideOnly(Side.CLIENT)
    public void getSubBlocks(Item p_149666_1_, CreativeTabs p_149666_2_, List p_149666_3_)
    {
        if (p_149666_1_ != Item.getItemFromBlock(Mod1.NegativeOakSlabDouble))
        {
            for (int i = 0; i < field_150005_b.length; ++i)
            {
                p_149666_3_.add(new ItemStack(p_149666_1_, 1, i));
            }
        }
    }

    @SideOnly(Side.CLIENT)
    public void registerBlockIcons(IIconRegister p_149651_1_) {}
}

I may ask questions asking for help, but I know what I'm doing. If my post is helpful in any way, give a "Thank You" in return, I'd really appreciate it.

Link to comment
Share on other sites

._.

 

I just looked at the photo, and now I feel like an idiot.

 

This is what's going on.

 

http://puu.sh/7sc5L.png

 

The slab doesn't stack up like normal slabs, but instead gets placed .5 blocks higher than usual. As if the slab was a full block.

I may ask questions asking for help, but I know what I'm doing. If my post is helpful in any way, give a "Thank You" in return, I'd really appreciate it.

Link to comment
Share on other sites

Take a look at BlockSlab#func150003_a(Block) is private and specific to vanilla slabs. So, you have to override the two functions that call it in your class.

  • boolean shouldSideBeRendered(IBlockAccess p_149646_1_, int p_149646_2_, int p_149646_3_, int p_149646_4_, int p_149646_5_)
  • Item getItem(World p_149694_1_, int p_149694_2_, int p_149694_3_, int p_149694_4_)

Look at the code in BlockSlab and modify

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • hola thanks for answering  i set some system outs to see what was happening and is a little weirder than i thought     @Override     protected void saveAdditional( CompoundTag nbt ){                  nbt.put("itemhandler", itemhandler.serializeNBT() );         nbt.putInt("progress", this.progress );         System.out.println("saveAdditional(nbt)");                 System.out.println(NbtUtils.prettyPrint(nbt)); //<-- this is whats getting saved         super.saveAdditional( nbt );     }     @Override     public void load( CompoundTag nbt ){         itemhandler.deserializeNBT( nbt.getCompound("itemhandler") );         this.progress = nbt.getInt("progress" );         System.out.println(NbtUtils.prettyPrint(nbt)); //<-- this is whats minecraft is giving back to the entity          System.out.println("load(nbt)");         super.load( nbt );     }   this dead adventurer body has two parts a block and the blockItem  both has their own itemhandlers and their own menus  *when i change some element inside the menu gui  it triguers the saveAdditional(nbt) system out whit a pretty print of the data beign saved  *when the world map loads it triguers the load(nbt) system out whit a pretty print of the data minecraft is gibing to this BlockEntity       ################ first i set the block entity (dead adventurer body like shaped) and put only a weath seed  in the slot 10 and i get this in the console soo its all right    close minecraft launch it again i see the system out whit the data returned to the entity and its look good theres is only a weed seed  ################ Second, now i gonna change the seed for two arrows  the console says its all right the two arrows are beign saved    now close and fireback again minecraft bam minecraft returns again the original data whit only a wheat seed the arrow data has been loss   try again now i gonna put 3 wheat seeds minecraft's system out says he gets it and save it    close fire again  data loss once more time  and it return just the original wheat seed    ####################################################################################### sorry for the long post and the crappy video  this is the reason why i say its saving the Block Entity data only when it feels like             
    • Yesterday I buy a minecraft server to play with my friends you know... One of my friends send me the list of mods to add and then i start to dowload them, when i add them to the server it start crashing but i don't know about this things because it's my first time buying a minecraft server This is the error: https://paste.ee/p/sJf7B
    • Discovering that a trusted colleague had accessed my Bitcoin account and transferred $30,000 worth of bitcoins was a devastating blow. It shattered the trust I had placed in them and left me feeling vulnerable and betrayed. However, in the face of adversity, I turned to MUYERN TRUST HACKER for assistance in reclaiming control over my finances and holding the perpetrators accountable for their actions. One of the standout features of MUYERN TRUST HACKER was its ability to provide real-time alerts and notifications, keeping me informed every step of the way. With the support of MUYERN TRUST HACKER, I was able to gather irrefutable evidence of the perpetrator's actions and hold them accountable for their crimes. Armed with the information provided by the platform, I pursued legal recourse and ensured that justice was served. The perpetrator faced severe consequences for their actions, including legal penalties and financial restitution. Beyond its role in facilitating the recovery process, MUYERN TRUST HACKER provided me with a sense of empowerment and resilience in the face of adversity. While the experience was undoubtedly challenging, it ultimately served as a testament to the importance of vigilance and the power of technology in safeguarding our digital assets. Thanks to MUYERN TRUST HACKER, I emerged stronger and more resilient, ready to face whatever challenges the future may hold. Mail; muyerntrusted[At] mail-me .c o m
    • Discovering that a trusted colleague had accessed my Bitcoin account and transferred $30,000 worth of bitcoins was a devastating blow. It shattered the trust I had placed in them and left me feeling vulnerable and betrayed. However, in the face of adversity, I turned to MUYERN TRUST HACKER web [ ht tps:// muyerntrusthack.solutions/ ] for assistance in reclaiming control over my finances and holding the perpetrators accountable for their actions. One of the standout features of MUYERN TRUST HACKER was its ability to provide real-time alerts and notifications, keeping me informed every step of the way. With the support of MUYERN TRUST HACKER, I was able to gather irrefutable evidence of the perpetrator's actions and hold them accountable for their crimes. Armed with the information provided by the platform, I pursued legal recourse and ensured that justice was served. The perpetrator faced severe consequences for their actions, including legal penalties and financial restitution. Beyond its role in facilitating the recovery process, MUYERN TRUST HACKER provided me with a sense of empowerment and resilience in the face of adversity. While the experience was undoubtedly challenging, it ultimately served as a testament to the importance of vigilance and the power of technology in safeguarding our digital assets. Thanks to MUYERN TRUST HACKER, I emerged stronger and more resilient, ready to face whatever challenges the future may hold. Mail; muyerntrusted[At] mail-me .c o m  
    • Do you have still this problem? (I have it too so I want to know if you did something with it)  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.