Jump to content

Recommended Posts

Posted

I'm currently working on a chat mod and am experiencing a weird issue with my code.  It works perfectly in the dev environment, but as soon as I put it in an obfuscated environment, it refuses to work.

 

I'm using reflection on ClientCommandHandler.executeCommand in order to keep compatibility in case Forge isn't installed.  Here is my code.  Yes, it is inside a try/catch.

 

Class clntCmdHndlr = Class.forName("net.minecraftforge.client.ClientCommandHandler");
Method exeCmd = clntCmdHndlr.getMethod("executeCommand", ICommandSender.class, String.class);
Object instance = clntCmdHndlr.getField("instance").get(null);
int value = (Integer) exeCmd.invoke(instance, mc.thePlayer,message);

 

Unfortunately, it throws a MethodNotFoundException when obfuscated.

 

java.lang.NoSuchMethodException: net.minecraftforge.client.ClientCommandHandler.executeCommand(net.minecraft.command.ICommandSender, java.lang.String)

 

I checked to make sure it was fully obfuscated, and it is.  Could someone help me out with this?  Here's the full code for reference.  I'm using Forge 1024.

Posted

Yes, but you said this.

 

  Quote
I'm using reflection on ClientCommandHandler.executeCommand in order to keep compatibility in case Forge isn't installed.

 

That will not work in any environment, obfuscated or not, should Forge not be installed. Hence, the try catch. :)

 

If you want to work within the environment as provided, use the provided API for command handlers.

Posted

It doesn't work in an obfuscated environment because it's an obfuscated environment. This means class names, fields and methods are an alphabet soup.

ClientCommandHandler is a forge class, which means that its name is not obfuscated. This is why you are able to fetch the class. The reason why you are unable to fetch the method is because ClientCommandHandler extends CommandHandler, which is a vanilla class. Any overrided methods in ClientCommandHandler will therefore have a reobfuscated name in an obfuscated environment.

 

In an obfuscated environment, the "executeCommand" method is called "a". You'll have to account for that.

Posted

Thanks, @Glenn.  I didn't realize that ClientCommandHandler was extending CommandHandler.  @sequituri would've been more helpful if he told me why exactly I needed another try/catch block.  I've changed my code to this.

 

Class clntCmdHndlr = Class.forName("net.minecraftforge.client.ClientCommandHandler");
Method exeCmd;
try {
exeCmd = clntCmdHndlr.getMethod("func_71556_a",ICommandSender.class, String.class);
} catch (NoSuchMethodException e) {
exeCmd = clntCmdHndlr.getMethod("executeCommand",ICommandSender.class, String.class);
}
Object instance = clntCmdHndlr.getField("instance").get(null);
int value = (Integer) exeCmd.invoke(instance, mc.thePlayer,message);

 

Edit: If Forge is installed, we're not going to be using notch names.  It's func_71556_a, not a.

Posted

Seems like not many people know about this, so I'll drop this here: You can also use the ObfuscationReflectionHelper class instead of this try-catch block ;)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

  Quote

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Posted

True that.

 

But, my understanding was that the OP was talking about making a mod that didn't necessarily depend on Forge. I guess that was a misunderstanding. Yes, I would have suggested the helper if I had understood correctly. Sorry for piping in.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • just rewatched the tutorial and my code is exactly the same as kaupenjoe's.  the item is added into the game but like i said to start it doesnt have a texture or a proper name for whatever reason.
    • yes the name is en_us.json and it is in resources -> assests -> testmod -> lang folders.  i have checked my code and am pretty confident that the code itself is correct.  i even tried loading the project in eclipse and it has the same problems, I think i will just rewatch the whole tutorial and will give an update on the situation.
    • same error, I also tried removing Valkyrian skies as well because I noticed it coming up a lot in the debug log errors
    • Hey man,    i have only been modding Minecraft for a few days but maybe I can help you. First of all make sure to follow every step of Kaupenjoe's tutorial, I found it to been very helpful and complete. The game uses the raw translation key for the item (in your case "item.testmod.alexandrite") if it can't find the correct lang file. Make sure it's name is "en_us.json" and it is saved under "ressources" -> "assets" -> "testmod".
    • whenever I try to get this item to render into the game it appears with the not texture purple and black squares and calls itself by the lang translation file path instead of the name i gave it.   { "item.testmod.alexandrite": "Alexandrite" } this is the lang json file package net.Hurst.testmod.item; import net.Hurst.testmod.TestMod; import net.minecraft.world.item.Item; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.registries.DeferredRegister; import net.minecraftforge.registries.ForgeRegistries; import net.minecraftforge.registries.RegistryObject; public class ModItems { public static final DeferredRegister<Item> ITEMS = DeferredRegister.create(ForgeRegistries.ITEMS, TestMod.MOD_ID); public static final RegistryObject<Item> ALEXANDRITE = ITEMS.register("alexandrite", () -> new Item(new Item.Properties())); public static void register(IEventBus eventBus){ ITEMS.register(eventBus); } } this is my ModItems.java file package net.Hurst.testmod; import com.mojang.logging.LogUtils; import net.Hurst.testmod.item.ModItems; import net.minecraft.world.item.CreativeModeTabs; import net.minecraftforge.api.distmarker.Dist; import net.minecraftforge.common.MinecraftForge; import net.minecraftforge.event.BuildCreativeModeTabContentsEvent; import net.minecraftforge.event.server.ServerStartingEvent; import net.minecraftforge.eventbus.api.IEventBus; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.fml.ModLoadingContext; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.fml.config.ModConfig; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.event.lifecycle.FMLCommonSetupEvent; import net.minecraftforge.fml.javafmlmod.FMLJavaModLoadingContext; import org.slf4j.Logger; // The value here should match an entry in the META-INF/mods.toml file @Mod(TestMod.MOD_ID) public class TestMod { public static final String MOD_ID = "testmod"; private static final Logger LOGGER = LogUtils.getLogger(); public TestMod() { IEventBus modEventBus = FMLJavaModLoadingContext.get().getModEventBus(); modEventBus.addListener(this::commonSetup); ModItems.register(modEventBus); MinecraftForge.EVENT_BUS.register(this); modEventBus.addListener(this::addCreative); ModLoadingContext.get().registerConfig(ModConfig.Type.COMMON, Config.SPEC); } private void commonSetup(final FMLCommonSetupEvent event) { } // Add the example block item to the building blocks tab private void addCreative(BuildCreativeModeTabContentsEvent event) { if(event.getTabKey() == CreativeModeTabs.INGREDIENTS){ event.accept(ModItems.ALEXANDRITE); } } // You can use SubscribeEvent and let the Event Bus discover methods to call @SubscribeEvent public void onServerStarting(ServerStartingEvent event) { } // You can use EventBusSubscriber to automatically register all static methods in the class annotated with @SubscribeEvent @Mod.EventBusSubscriber(modid = MOD_ID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { } } } this is my TestMod.java file { "parent": "minecraft:item/generated", "textures": { "layer0": "testmod:item/generated" } } this is my model file for the item. I am using intellij 2025.1.2 with fdk 1.21 and java 21 I would appreciate the help.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.