[1.7.2][Solved] Sending text from onBlockActivated sends message twice

[simwir]

So i want it to be so that when you right click the block with a item, it prints the fluid inside the tank to the chat.

I have got it so that it prints it to the chat, but it prints it twice.

}else if(heldtItem.isItemEqual(new ItemStack(CompactTanks.meter))){ //checks if it's the right item
Debug.consoleln("Fluid Meter found"); //Everything prefixed with Debug just prints to the console
if(tileSmallTank.isTankEmpty()){ 
	ChatHandler.sendToPlayer("The tank is empty", par5EntityPlayer);//the text that gets printed twice
}else{
	ChatHandler.sendToPlayer("Current fluid in tank: " + tileSmallTank.getFluidName(), par5EntityPlayer);//the text that gets printed twice
	ChatHandler.sendToPlayer("Amount of fluid in tank: " + tileSmallTank.getFluidAmount(), par5EntityPlayer);//the text that gets printed twice
	return true;
}
}

 

The code in the ChatHandler looks like this:

public class ChatHandler {

public static void sendToPlayer(String par1Message, EntityPlayer par2Player){
	if(par1Message.length() > 0){
		par2Player.addChatMessage(new ChatComponentTranslation(par1Message));
	}
}

}

 

and the isTankEmpty code looks lige this:

public boolean isTankEmpty(){
	if(tank.getFluid() == null){
		return true;
	}else{
		return false;
	}
}

 

 

All the code can be found here: https://github.com/simwir/Compact-Tanks/tree/Tank

and the files in question are:

ChatHandler - https://github.com/simwir/Compact-Tanks/blob/Tank/main/java/simwir/ct/handler/ChatHandler.java

BlockSmallTank - https://github.com/simwir/Compact-Tanks/blob/Tank/main/java/simwir/ct/blocks/BlockSmallTank.java

TileSmallTank - https://github.com/simwir/Compact-Tanks/blob/Tank/main/java/simwir/ct/tile/TileSmallTank.java

 

[simwir]

The method gets called twice, once for client and once for server. You should only send the message on the server (

world.isRemote == false

).

 

Thanks that worked

[Alix_The_Alicorn]

diesieben, I know this is solved, but was looking around the forum, and notice you used == false. You can just do

if(!world.isRemote)

. Just though I would point it out, I generally use that method because its faster.

 

Happy coding!