Search the Forums BEFORE making a new post.

[SOLVED][1.7.2] Getting Enchantment Off A Tool

Start new topic

Posted April 3, 201411 yr

I have looked at some other posts but none of them seem to have worked, I have also tried some round-about ways of doing this but again, to no avail. I need to check for the pick having Silk Touch to prevent the mob from spawning when you break the ore with a silk pick.

here is my ores code:

package me.saxon564.mobores.blocks;

import java.lang.reflect.InvocationTargetException;
import java.util.List;
import java.util.Random;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

import me.saxon564.mobores.MobOres;
import me.saxon564.mobores.MobOresReference;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.monster.EntityCreeper;
import net.minecraft.entity.monster.EntitySilverfish;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.world.World;

public class BlockCreeptoniteOre extends Block {

private boolean hasSilkTouch;
private EntityPlayer pPlayer;

public BlockCreeptoniteOre() {

	super(Material.rock);
	setBlockName("creeptoniteOre");
	setBlockTextureName(MobOresReference.MODID + ":" + getUnlocalizedName().substring(5));
	setCreativeTab(MobOres.mobOresTab);
	setHardness(6.5F);
	setResistance(25.0F);
	setLightLevel(0.3F);

}

public void onBlockHarvested(World world, int x, int y, int z, int meta, EntityPlayer player) {

	pPlayer = player;

}

public void onBlockDestroyedByPlayer(World world, int x, int y, int z, int meta)
    {
        if ((!world.isRemote) && (!checkSilk()))
        {
            EntityCreeper entitycreeper = new EntityCreeper(world);
            entitycreeper.setLocationAndAngles((double)x + 0.5D, (double)y, (double)z + 0.5D, 0.0F, 0.0F);
            world.spawnEntityInWorld(entitycreeper);
            entitycreeper.spawnExplosionParticle();
        }

        super.onBlockDestroyedByPlayer(world, x, y, z, 1);
    }

public Item getItemDropped(int par1, Random par2, int par3)
    {
        return MobOres.deadCreeptoniteOre.getItemDropped(par1, par2, par3);
    }

public boolean checkSilk() {
	ItemStack item = pPlayer.inventory.getCurrentItem();
	hasSilkTouch = false;
	if (item != null) {
	   NBTTagList enchants = (NBTTagList) item.stackTagCompound.getTag("StoredEnchantments");
	   for (int i = 0; i < enchants.tagCount(); i++) {
		   NBTTagCompound enchant = ((NBTTagList) enchants).getCompoundTagAt(i);
	      if (enchant.getShort("id") == 33)/*.getTag("id") == 33)*/ {
	         hasSilkTouch = true;
	         break;
	      }
	   }
	   System.out.println(hasSilkTouch);
	}
	return hasSilkTouch;
}

}

it ALWAYS crashes on this line specifically:

NBTTagList enchants = (NBTTagList) item.stackTagCompound.getTag("StoredEnchantments");

and I have no idea why, since i did take a look at some other bits of code in the game and it uses the same code.

Does any one have any idea why it is crashing on that line only?

April 3, 201411 yr

The ItemStack's stackTagCompound may be null, so if you are using an unenchanted item, that line will crash. Simply null check.

http://i.imgur.com/NdrFdld.png[/img]

April 3, 201411 yr

Author

how would you suggest checking if it was null? I used

if (item.stackTagCompound.getTag("StoredEnchantments") != null) {

but it crashed on that check.

stacktrace:

Stacktrace:
at me.saxon564.mobores.blocks.BlockCreeptoniteOre.onBlockHarvested(BlockCreeptoniteOre.java:50)
at net.minecraft.server.management.ItemInWorldManager.removeBlock(ItemInWorldManager.java:274)
at net.minecraft.server.management.ItemInWorldManager.tryHarvestBlock(ItemInWorldManager.java:328)
at net.minecraft.server.management.ItemInWorldManager.uncheckedTryHarvestBlock(ItemInWorldManager.java:241)
at net.minecraft.network.NetHandlerPlayServer.processPlayerDigging(NetHandlerPlayServer.java:541)
at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:64)
at net.minecraft.network.play.client.C07PacketPlayerDigging.processPacket(C07PacketPlayerDigging.java:98)
at net.minecraft.network.NetworkManager.processReceivedPackets(NetworkManager.java:246)

April 3, 201411 yr

You first need to check if stacktagCompound != null.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

April 3, 201411 yr

Author

ok, so that seems to have fixed it not getting past that point, now here is the new code:

public void onBlockHarvested(World world, int x, int y, int z, int meta,
		EntityPlayer player) {

	ItemStack item = player.inventory.getCurrentItem();
	hasSilkTouch = false;
	if (item != null) {
		if (item.stackTagCompound != null) {
			if (item.stackTagCompound.getTag("ench") != null) {
				NBTTagList enchants = (NBTTagList) item.stackTagCompound
						.getTag("StoredEnchantments");
					for (int i = 0; i < enchants.tagCount(); i++) {
						NBTTagCompound enchant = ((NBTTagList) enchants)
								.getCompoundTagAt(i);
						if (enchant.getTag("id").getId() == 33) {
							hasSilkTouch = true;
							break;
						}
					}
				}
			}
		}
	}

now the crashing point is herewith a NPE:

for (int i = 0; i < enchants.tagCount(); i++) {

i did try throwing that into an if statement to try and check it, but it crashed in the if statement.

April 4, 201411 yr

Why are you testing this tag:

if (item.stackTagCompound.getTag("ench") != null)

and then using this other tag as if you know its contents are non-null:

enchants = (NBTTagList) item.stackTagCompound.getTag("StoredEnchantments")

? The "ench" tag is not the same tag as the "StoredEnchantments" tag. Why not test the tag you are actually setting enchants to?

-S- (if I helped, please click Thank and applaud)

width=471 height=128 http://6upnqa.dm2301.livefilestore.com/y2mtf-vG7Tqq1TiiVpIm53KWj7294NDPoHfSHHb4PzZiMAUfRCfK0UY0MwOu7Q3zTBNVTKqWjr2-xgBfFRpQT5p-QivtvknPpoABMNUw9br9WuZcBFkjePhnAbW500gVm-P/sequiturian.png[/img]

April 4, 201411 yr

Author

i forgot to change "StoredEnchantments" to ench on the second one thats why, but thats not the problem, its not even getting to that second test

EDIT: OHHHHH ok, i wasnt thinking when i first wrote this reply. well that fixed the last crash, now i juts need to figure out why it only reads false when checking the enchantment id.

April 4, 201411 yr

Author

Ok, i finally got it working like its suppose to.

here is the "final" code:

package me.saxon564.mobores.blocks;

import java.lang.reflect.InvocationTargetException;
import java.util.List;
import java.util.Random;

import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;

import me.saxon564.mobores.MobOres;
import me.saxon564.mobores.MobOresReference;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.EntityLiving;
import net.minecraft.entity.monster.EntityCreeper;
import net.minecraft.entity.monster.EntitySilverfish;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTBase;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.world.World;

public class BlockCreeptoniteOre extends Block {

private boolean hasSilkTouch;

public BlockCreeptoniteOre() {

	super(Material.rock);
	setBlockName("creeptoniteOre");
	setBlockTextureName(MobOresReference.MODID + ":"
			+ getUnlocalizedName().substring(5));
	setCreativeTab(MobOres.mobOresTab);
	setHardness(6.5F);
	setResistance(25.0F);
	setLightLevel(0.3F);

}

public void onBlockHarvested(World world, int x, int y, int z, int meta,
		EntityPlayer player) {

	ItemStack item = player.inventory.getCurrentItem();
	hasSilkTouch = false;
	if (item != null) {
		if (item.stackTagCompound != null) {
			if (item.stackTagCompound.getTag("ench") != null) {
				NBTTagList enchants = (NBTTagList) item.stackTagCompound
						.getTag("ench");
				for (int i = 0; i < enchants.tagCount(); i++) {
					NBTTagCompound enchant = ((NBTTagList) enchants)
							.getCompoundTagAt(i);
					if (enchant.getInteger("id") == 33) {
						hasSilkTouch = true;
						break;
					}
				}
			}
		}
	}
}

public void onBlockDestroyedByPlayer(World world, int x, int y, int z,
		int meta) {
	if ((!world.isRemote) && (!hasSilkTouch)) {
		EntityCreeper entitycreeper = new EntityCreeper(world);
		entitycreeper.setLocationAndAngles((double) x + 0.5D, (double) y,
				(double) z + 0.5D, 0.0F, 0.0F);
		world.spawnEntityInWorld(entitycreeper);
		entitycreeper.spawnExplosionParticle();
	}

	super.onBlockDestroyedByPlayer(world, x, y, z, 1);
}

public Item getItemDropped(int par1, Random par2, int par3) {
	return MobOres.deadCreeptoniteOre.getItemDropped(par1, par2, par3);
}

}

This topic is now closed to further replies.

https://forums.minecraftforge.net/topic/17715-solved172-getting-enchantment-off-a-tool/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

New Forum Design/Update: Issues and Suggestions

Thanks for your feedback and suggestions. The new forums run Invision Community 5 - some things are more customisable, other things a lot less. I'm happy to adjust the settings as desired but not sure where they'd be or if they're still available in the new version, so if you could let me know I'll give it a go.

By Paint_Ninja · 25 minutes ago25 min
Orbital strike cannon fishing rod mod

This is the Forge forums. Only Forge is supported here, not Fabric.

By Paint_Ninja · 28 minutes ago28 min
Need help with server (lilypad)

Remove the client-side-only mods from your server

Start with smartkeyprompts

By TileEntity · 5 hours ago5 hr
Orbital strike cannon fishing rod mod

When will it be done for fabric 1.21.5 and is it server side or client side?? @FoxyWoxy

By JayKing014 · 7 hours ago7 hr
Need help with server (lilypad)

paste bin of error code, i made this modpack myself n it works perfectly in single player but for some reason the server just breaks if i try to put it into a server host. https://pastebin.com/KU4wT89Z

By kodapendense · Posted 8 hours ago8 hr

Sign In

[SOLVED][1.7.2] Getting Enchantment Off A Tool

Featured Replies

Posts

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Need help with server (lilypad)

Orbital strike cannon fishing rod mod

Need help with server (lilypad)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)