Jump to content

Recommended Posts

Posted

I just noticed whenever I test my mod the console log tells me that all my item and block IDs are mismatched and the mod IDs all seem to come directly after Vanilla IDs:

 

[00:15:05] [server thread/INFO] [FML]: Found item id mismatch starlight:chaosSword : 4112 4188

[00:15:05] [server thread/INFO] [FML]: Found item id mismatch starlight:wall_white : 185 186

[00:15:05] [server thread/INFO] [FML]: Found item id mismatch starlight:ChaoticHelmet: 4177 4165

[00:15:05] [server thread/INFO] [FML]: Found item id mismatch starlight:meteorite : 4139 4127

 

...and it keeps going and going for over a hundred lines with every item/block.

 

 

This is all the coding for an example item to show what I assumed would set my IDs:

 

In the main class there's

 

public static Item chaosSword;

public final int chaosSwordID = 10020;

 

and

 

@EventHandler

public void preInit(FMLPreInitializationEvent event)

{

chaosSword = new com.starlight.weapons.chaosSword(chaosSwordID, ChaosSword).setUnlocalizedName("chaosSword").setTextureName("starlight:chaosSword");

GameRegistry.registerItem(chaosSword, "chaosSword");

}

 

 

And in the item's class

 

package com.starlight.weapons;

import net.minecraft.item.ItemSword;

public class chaosSword extends ItemSword

{

public chaosSword (int id, ToolMaterial ChaosSword)

{

super(ChaosSword);

this.setMaxStackSize(1);

                this.setCreativeTab(tabStarlightWeapons);

}

}

 

 

So can someone tell me what I'm doing wrong?

Posted

public chaosSword (int id, ToolMaterial ChaosSword)
   {
      super(ChaosSword);
      this.setMaxStackSize(1);
                this.setCreativeTab(tabStarlightWeapons);
   }

"id" is totally unused in this constructor. Removing is advised.

Posted

Why would you want that?

 

Why wouldn't I? It's kind of annoying that every time I add a new item it changes the ID of every single other item. Won't that cause problems?

Posted

No, because you register the items with a string, so that's how minecraft now determins what item's should go where. So you shouldn't have to worry about that.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

 

1.12 -> 1.13 primer by williewillus.

 

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

 

http://www.howoldisminecraft1710.today/

Posted

IDs still technically exist, but they're now handled internally by Minecraft and are dynamically assigned per world (if you load a world, then add a mod and reload the world, that mods items won't exist (as far as I've seen and found for myself))

The further a society drifts from the truth, the more it hates those who speak it.

Posted

As long as you aren't relying on IDs anywhere in your code (like Block.getIdFromBlock() or Item.getIdFromItem()), everything will work perfectly fine, as both Minecraft and Forge have moved off of complete Data Value reliance.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Different problem now. https://paste.ee/p/iDo8lS35
    • I would like to have a BoP sapling drop from my block if it is also installed. I think I have done everything and I cannot pinpoint the problem, which is the error in the logs that appears when joining a world:   [Worker-Main-11/ERROR] [ne.mi.co.ForgeHooks/]: Couldn't parse element loot_tables:grasses:blocks/leaves_block com.google.gson.JsonSyntaxException: Expected name to be an item, was unknown string 'biomesoplenty:magic_sapling' My code:   LootItemConditions.CONDITIONS.register(modEventBus); public class LootItemConditions { public static final DeferredRegister<LootItemConditionType> CONDITIONS = DeferredRegister.create(Registries.LOOT_CONDITION_TYPE, Grasses.MOD_ID); public static final RegistryObject<LootItemConditionType> IS_MOD_LOADED = CONDITIONS.register("is_mod_loaded", () -> new LootItemConditionType(new IsModLoaded.ConditionSerializer())); } public class IsModLoaded implements LootItemCondition { private final boolean exists; private final String modID; public IsModLoaded(String modID) { this.exists = ModList.get().isLoaded(modID); this.modID = modID; } @Override public LootItemConditionType getType() { return LootItemConditions.IS_MOD_LOADED.get(); } @Override public boolean test(LootContext context) { return this.exists; } public static LootItemCondition.Builder builder(String modid) { return () -> new IsModLoaded(modid); } public static class ConditionSerializer implements Serializer<IsModLoaded> { @Override public void serialize(JsonObject json, IsModLoaded instance, JsonSerializationContext ctx) { json.addProperty("modid", instance.modID); } @Override public IsModLoaded deserialize(JsonObject json, JsonDeserializationContext ctx) { return new IsModLoaded(GsonHelper.getAsString(json, "modid")); } } } protected LootTable.Builder createLeavesDropsWithModIDCheck(Block selfBlock, Item sapling, Property<?>[] properties, String modIDToCheck, float... chances) { CopyBlockState.Builder blockStateCopyBuilder = CopyBlockState.copyState(selfBlock); for(Property<?> property : properties) { blockStateCopyBuilder.copy(property); } return LootTable.lootTable() .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(LootItem.lootTableItem(selfBlock) .when(HAS_SHEARS_OR_SILK_TOUCH) .apply(blockStateCopyBuilder))) .withPool(LootPool.lootPool().setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionCondition(selfBlock, LootItem.lootTableItem(sapling)) .when(IsModLoaded.builder(modIDToCheck))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, chances)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH)) .withPool(LootPool.lootPool().name("sticks").setRolls(ConstantValue.exactly(1.0F)) .add(this.applyExplosionDecay(selfBlock, LootItem.lootTableItem(Items.STICK). apply(SetItemCountFunction.setCount(UniformGenerator.between(1.0F, 2.0F)))) .when(BonusLevelTableCondition.bonusLevelFlatChance(Enchantments.BLOCK_FORTUNE, NORMAL_LEAVES_STICK_CHANCES)) .when(HAS_NO_SHEARS_OR_SILK_TOUCH))); } I don't know. Am I making a mistake somewhere? Am I forgetting something? Should there be something else?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.