Jump to content

Recommended Posts

Posted

I have figured out what I need to do to submit a pull request but I did not find a singular location describing how to do it and explaining the build environment. I am having concerns I did it wrong due to some of the things I have noticed while setting up my build environment. For example, if I set my workspace to "C:\ForgeFork\mcp71\MinecraftForge\eclipse" (after running "setup.bat") neither "Clean-Client" nor "Forge-Client" show up as projects and need to be added by hand

 

Is there any tutorial that I just missed? I just want to make sure I am not starting down the wrong path.

Posted

You fork from the MinecraftForge repo on github, and then hit the pull request button, add a title and description, etc.

So, what would happen if I did push that shiny red button over there? ... Really? ... Can I try it? ... Damn.

Posted

Except that you skipped the part about if you don't name the folder "forge" instead of the default "ForgeClient" it breaks the build. Or that the two eclipse projects are not added and must be added by and that will mess up the ".metadata" folder so you will need to not commit those changes, or whats the difference between Clean-Client and Forge-Client, or how the build script works, or the 100 other little things that come up that could be easily explained in a step by tutorial.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.