Jump to content

[SOLVED] [1.7.2] byte array seems to be null when mod run as packed jar


SanAndreaP

Recommended Posts

I solved it by adding @SortingOrder(1001) above my FMLLoadingPlugin (thank you diesieben07)

 

So I've got a strange problem with my current coremod, which I try to update to 1.7.2.

I use several ASM transformers and they seem to run fine and do the correct changes (I wrote the classes as files and opened them with JD-GUI, every patch is correctly applied)

However when I pack / build my coremod, put it into the mods folder and try to start Minecraft, I get a NullPointerException. The byte array supplied by the transform method is null (I put a println with the byte array and it printed null)

 

Here some details:

Forge version used: 10.12.1.1061

Crash report: https://gist.github.com/SanAndreasP/a18ef19f6f5efce65464

whole log file: (seems to be cut off and doesn't show the error, idk why) https://gist.github.com/SanAndreasP/4a6d737d043276f4b50e

offending class: https://github.com/SanAndreasP/SAPManagerPack/blob/master/java/de/sanandrew/core/manpack/transformer/TransformPlayerDismountCtrl.java#L23

whole source: https://github.com/SanAndreasP/SAPManagerPack/tree/master/java/de/sanandrew/core/manpack

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

If I remember correctly your transformer will be called with a null byte array if a class couldn't be found in some cases. Try and check for null and if it is null, just return null yourself. Then it will not crash with your ClassTransformer and you will get a proper stack trace as to where the CNFE is coming from.

Just an idea.

 

Yes, seems like my ChannelHandler caused it when I initialized it statically like static final Inst var = new Inst(params);

Now the only problem persisting is that it seems that I can't use COMPUTE_FRAMES flag for the ClassWriter when I convert the transformed class back into a byte array... And again, only in a non-dev environment, in eclipse, everything works as expected.

It just gives me an InvocationTargetException caused by a ClassNotFoundException

 

[12:41:19 INFO]: Client> java.lang.reflect.InvocationTargetException
[12:41:19 INFO]: Client> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.reflect.Method.invoke(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.Launch.launch(Launch.java:134) [launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> Caused by: java.lang.NoClassDefFoundError: net/minecraft/entity/projectile/EntitySnowball
[12:41:19 INFO]: Client> 	at net.minecraft.item.Item.func_150900_l(Item.java:171) ~[abn.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.init.Bootstrap.func_151354_b(SourceFile:358) ~[kb.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.Minecraft.<init>(Minecraft.java:266) ~[azd.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.main.Main.main(SourceFile:84) ~[Main.class:?]
[12:41:19 INFO]: Client> 	... 6 more
[12:41:19 INFO]: Client> Caused by: java.lang.ClassNotFoundException: net.minecraft.entity.projectile.EntitySnowball
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:188) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.item.Item.func_150900_l(Item.java:171) ~[abn.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.init.Bootstrap.func_151354_b(SourceFile:358) ~[kb.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.Minecraft.<init>(Minecraft.java:266) ~[azd.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.main.Main.main(SourceFile:84) ~[Main.class:?]
[12:41:19 INFO]: Client> 	... 6 more
[12:41:19 INFO]: Client> Caused by: java.lang.NoClassDefFoundError: net/minecraft/entity/projectile/EntityThrowable
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.defineClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.security.SecureClassLoader.defineClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:180) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.item.Item.func_150900_l(Item.java:171) ~[abn.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.init.Bootstrap.func_151354_b(SourceFile:358) ~[kb.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.Minecraft.<init>(Minecraft.java:266) ~[azd.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.main.Main.main(SourceFile:84) ~[Main.class:?]
[12:41:19 INFO]: Client> 	... 6 more
[12:41:19 INFO]: Client> Caused by: java.lang.ClassNotFoundException: net.minecraft.entity.projectile.EntityThrowable
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:188) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.defineClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.security.SecureClassLoader.defineClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:180) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.item.Item.func_150900_l(Item.java:171) ~[abn.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.init.Bootstrap.func_151354_b(SourceFile:358) ~[kb.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.Minecraft.<init>(Minecraft.java:266) ~[azd.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.main.Main.main(SourceFile:84) ~[Main.class:?]
[12:41:19 INFO]: Client> 	... 6 more
[12:41:19 INFO]: Client> Caused by: java.lang.RuntimeException: java.lang.ClassNotFoundException: ayi
[12:41:19 INFO]: Client> 	at org.objectweb.asm.ClassWriter.getCommonSuperClass(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.ClassWriter.a(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.Frame.a(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.Frame.a(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.MethodWriter.visitMaxs(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.tree.MethodNode.accept(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.tree.MethodNode.accept(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at org.objectweb.asm.tree.ClassNode.accept(Unknown Source) ~[asm-all-4.1.jar:4.1]
[12:41:19 INFO]: Client> 	at de.sanandrew.core.manpack.transformer.ASMHelper.createBytes(ASMHelper.java:124) ~[sAPManPack-1.7.2-2.0.0.jar:?]
[12:41:19 INFO]: Client> 	at de.sanandrew.core.manpack.transformer.TransformEntityThrowable.transformLqThrowable(TransformEntityThrowable.java:108) ~[sAPManPack-1.7.2-2.0.0.jar:?]
[12:41:19 INFO]: Client> 	at de.sanandrew.core.manpack.transformer.TransformEntityThrowable.transform(TransformEntityThrowable.java:37) ~[sAPManPack-1.7.2-2.0.0.jar:?]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.runTransformers(LaunchClassLoader.java:276) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:174) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.defineClass1(Native Method) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.defineClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.security.SecureClassLoader.defineClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.launchwrapper.LaunchClassLoader.findClass(LaunchClassLoader.java:180) ~[launchwrapper-1.9.jar:?]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at java.lang.ClassLoader.loadClass(Unknown Source) ~[?:1.7.0_25]
[12:41:19 INFO]: Client> 	at net.minecraft.item.Item.func_150900_l(Item.java:171) ~[abn.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.init.Bootstrap.func_151354_b(SourceFile:358) ~[kb.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.Minecraft.<init>(Minecraft.java:266) ~[azd.class:?]
[12:41:19 INFO]: Client> 	at net.minecraft.client.main.Main.main(SourceFile:84) ~[Main.class:?]
[12:41:19 INFO]: Client> 	... 6 more

 

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Hrm.

COMPUTE_FRAMES

is always a dangerous spot, because it triggers class-loading of other classes.

I see you are using "notched" class-names in your transformation. Don't do that, FML transforms all the classes to have their MCP name at runtime, so if you use those you should be fine. Maybe that is the problem.

 

I'm only using notched class names when I search for a needle in a haystack (since the ClassNode has it's instructions only in notched code for whatever reason)

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Oh. If you do @SortingIndex(1001) (or bigger) on your IFMLLoadingPlugin your transformers run after the deobfuscation transformer.

 

In all honesty I am quite unsure as to where your error is originating from :(

 

 

 

 

The sorting index worked like a charm and instantly killed all my problems. Also I don't have to worry about the notched method/field/class naming crap anymore.

I can't thank you enough \o/

Don't ask for support per PM! They'll get ignored! | If a post helped you, click the "Thank You" button at the top right corner of said post! |

mah twitter

This thread makes me sad because people just post copy-paste-ready code when it's obvious that the OP has little to no programming experience. This is not how learning works.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • version used : minecraft forge 1.20.1 Logs : https://bytebin.lucko.me/rtG4EA0vfb hi! so when i try to create a new minecraft world in single player, it just crashes?? does anyone has an idea what could be causing this ?
    • Hey today I was trying to play in 1.21 modpack that I made on fabric (my version of fabric is in 0.16.0) with this list of mods : - Entity Model Features (by traben_0) - Entity Texture Features (by traben_0) - Advanced Chat (by Wesley8081) - Ambient Environment (by Jaredlll08) - Ambient Souds 6 (by CreativeMD) - Animatica (by FoundationGames) - Armor Statues (by Fuzs) - Auto HUD (by Crendgrim) - Bad Packets (by badasintended) - Balm (by BlayTheNinth) - Better Beds (by Motschen) - Better Chunk Loading (by someaddon) - Better Compatibility Checker (by Gaz-) - Better FPS [Render Distance] (by someaddon) - Better Ping Display (by Quintinity) - Better Statistics Screen (by TheCSDev) - Better Armor HUD (by efekos) - Better F3 ( by cominixo) - Blur + (by Motschen) - Bobby (by Johni0702) - Cat Jam (by shmove) - Catalogue (by MrCrayfish) - Chat Heads (by dzwdz) - Cherished Worlds (by TheIllusiveC4) - Chunk Sending (by someaddon) - Chunks Fade In (by kerudion) - Chunky (by pop4959) - Cloth Config (by shedaniel) - Clumps (by Jaredlll08) - Cobweb (CrystalSpider) - Collective (by Serilum) - Configured (by MrCrayfish) - Connectivity (by someaddon) - Continuity (by Pepper_Bell) - Creative Core (by CreativeMD) - Cupboard (by someaddon) - Cut Through (by Fuzs) - Dark Loading Screen (by Neecko5b84) - Debugify (by XanderIsDev) - Double Doors (by Serilum) - Dynamic FPS (by juliand665) - Dynamic Lights (by Tschipcraft) - Easy Anvils (by Fuzs) - Easy Magic (by Fuzs) - Easy Shulker Boxes (by Fuzs) - Eating Animation (by theone-ss) - Enhanced Attack Indicator (by Mineash) - Enhanced Block Entities (by FoundationGames) - Enhanced Visuals (by CreativeMD) - Entity Culling (by tr7zw) - Environmental Water (by AgentMindStorm) - Essential (by SparkUniverse_) - Extra Thicc Packets (by JaselUmena) - Fabric (by modmuss50) - Fabric Language Kotlin (by modmuss50) - Falling Leaves (by RandomMcSomethin) - Fancy Block Particles (by Hantonik) - Fancy Health Bar (by efekos) - Farsight (by someaddon) - Fast IP Ping (by Fallen_Breath) - Ferrite Core (by  malte0811) - Fish On The Line (by Serilum) - Fix GPU Memory Leak  (by someaddon) - Forge Config API Port (by Fuzs) - FPS Reducer (by bre2el) - Freecam (by hashalite) - Fzzy Config (by fzzyhmstrs) - Get It Together (by bl4ckscor3) - Global Packs (by JTK222) - Harvest With Ease (by CrystalSpider) - Ichuntil Util (by iChun) - Immediately Fast (by RaphilMC) - Immersive UI (by SSKirillSS) - Indium (by comp500) - Inventory HUD+ (by dmitrylovin) - Iris Shaders (by coderbot) - Item Physic Full (by CreativeMD) - Jade (by Snownee) - Journey Map (by techbrew) - Just Enough Breeding (by Christofmeg) - Just Enough Items (by mezz) - Just Enough Professions (by Mrbysco) - Language Reload (by Jerozgen) - Leaves Be Gone (by Fuzs) - Let Me Despawn (by frikinjay) - Let Sleeping Dogs Lie (by iChun) - Lithium (by JellySquid) - Loading Backgrounds (by Lupin) - Mineblock's Repeated Utilities (by itsmineblock11) - Menulogue (by MrCrayfish) - Mob Plaques (by Fuzs) - Mod Menu (by Prospector) - Model Gap Fix (by MehVahdJukaar) - Mouse Tweaks (by YaLTeR) - Nether Portal Fix (by BlayTheNinth) - Nicer Skies (by ztereohype) - Noisium (by Steveplays28) - Not Enough Animations (by tr7zw) - Opti GUI (by opekope2) - Packet Fixer (by TonimatasDEV) - Particle Core (by fzzyhmstrs) - Passive Shields (by Serilum) - Pick Up Notifier (by Fuzs) - Ping Wheel (by LukenSkyne) - Puzzle (by Motschen) - Puzzles LIB (by Fuzs) - Reese's Sodium Options (by FlashyReese) - Resource Pack Overrides (by Fuzs) - Server Country Flags (by khajiitos) - Server Performance (by someaddon) - Skin Layer 3D (by tr7zw) - Sodium (by JellySquid) - Sodium Extra (by FlashyReese) - Sodium Shadowy Path Blocks (by Rynnavinx) - Sound Physics Remastered (by henkelmax) - Sounds (by itsmineblock11) - Spark (by lucko) - Stack Refill (by Serilum) - Structure Essentials (by someaddon) - TCD Commons API (by TheCSDev) - Text Placeholder API (by Patbox) - Villager Names (by Serilum) - Visual Overhaul (by Motschen) - Visual Workbench (by Fuzs) - Visuality (by PinkGoosik) - Wakes (by Goby56) - Wavey Capes (by tr7zw) - YDM'S Weapon Master  (by YourDailyModderx) - Yet Another Config LIB (by XanderIsDev) - Zoomify (by XanderIsDev) And When I load it it work, I can create a world and even let him open forever at least I didn't move cause if so the game just crash and tell me this message :   Encountered an unexpected exception net.minecraft.class_148: Ticking entity at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1025) at net.minecraft.server.MinecraftServer.method_3748(MinecraftServer.java:912) at net.minecraft.class_1132.method_3748(class_1132.java:114) at net.minecraft.server.MinecraftServer.method_29741(MinecraftServer.java:697) at net.minecraft.server.MinecraftServer.method_29739(MinecraftServer.java:281) at java.base/java.lang.Thread.run(Thread.java:1583) Caused by: java.lang.NullPointerException: Cannot invoke "net.minecraft.class_4706.isEmpty()" because "tickets" is null at net.minecraft.class_3204.canNoneExpire(class_3204.java:1034) at net.minecraft.class_3204.handler$dln000$lithium$unregisterExpiringTicket(class_3204.java:1075) at net.minecraft.class_3204.method_17645(class_3204.java:172) at net.minecraft.class_3204.method_17292(class_3204.java:194) at net.minecraft.class_3215.method_17300(class_3215.java:443) at com.betterchunkloading.chunk.PlayerChunkData.checkPrediction(PlayerChunkData.java:406) at com.betterchunkloading.chunk.PlayerChunkData.checkDirection(PlayerChunkData.java:353) at com.betterchunkloading.chunk.PlayerChunkData.trackPlayerMovement(PlayerChunkData.java:177) at com.betterchunkloading.chunk.PlayerChunkData.onChunkChanged(PlayerChunkData.java:130) at com.betterchunkloading.event.EventHandler.onPlayerTick(EventHandler.java:200) at net.minecraft.class_3222.handler$zed000$betterchunkloading$onPlayerTick(class_3222.java:2618) at net.minecraft.class_3222.method_5773(class_3222.java:564) at net.minecraft.class_3218.mixinextras$bridge$method_5773$202(class_3218.java) at net.minecraft.class_3218.wrapOperation$eei000$puzzleslib$tickNonPassenger(class_3218.java:7797) at net.minecraft.class_3218.method_18762(class_3218.java:770) at net.minecraft.class_1937.method_18472(class_1937.java:498) at net.minecraft.class_3218.method_31420(class_3218.java:408) at net.minecraft.class_5574.method_31791(class_5574.java:54) at net.minecraft.class_3218.method_18765(class_3218.java:372) at net.minecraft.server.MinecraftServer.method_3813(MinecraftServer.java:1021) ... 5 more Sorry guys if it obvious but actually I'm an old player of Minecraft but I'm new in modding so yup. But Thanks everyone by advance to help me with this.
    • These forums are for Minecraft Forge, not Fabric. You would probably be better served posting this question wherever fabric support is given, most likely their discord server.
    • Add the new latest.log (logs-folder) with sites like https://mclo.gs/ and paste the link to it here
    • Update: I tried to reproduce the bug and found out that if I place a flare on a block and then dismantle it with the pickarang (Quark), the flare gets no NBT Tag after getting assigned an empty one through the offhand.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.