Jump to content

Recommended Posts

Posted

Hey guys. I've been trying to suss through most of this without asking any questions on the forums - but I've hit an issue I can't seem to find an answer to. I have a TileEntity that when placed, assigns the placing player as its owner (just a string on the tileentity that gets saved in the nbt). However, I want that data to persist if the player breaks the block (and thus its in their inventory) and later places it. Sort of like how the Tesseracts in TE remember their owner (and other settings), etc. Any ideas?

Posted

You'll need to use the ItemStack's NBTTagCompound.

 

In your Block's getDrops method you should get the TileEntity. TileYours being your TileEntity

 

TileYours tile = (TileYours)world.getTileEntity(x, y, z)

You should probably also perform a check on the tile to ensure it is instanceof TileYours

Then you need to get the value from the tile. You need to create the getPlayerName method in your tile entity class and insert it into a new stack's nbttag

	@Override
public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
	ArrayList<ItemStack> items = new ArrayList<ItemStack>();

	TileEntity t = world.getTileEntity(x, y, z);

	if (t instanceof TileYours) {
		TileYours tile = (TileYours)t;
		String name = tile.getPlayerName();

		ItemStack stack = new ItemStack(world.getBlock(x, y, z), 1, metadata);
		if (!stack.hasTagCompound()) {
			stack.setTagCompound(new NBTTagCompound());
		}
		stack.getTagCompound().setString("playerName", name);
		items.add(stack);
	}

	return items;

}

 

And in your onBlockPlaced you will need do the opposite and set the name in the tileentity

I'm Sparkst3r, that kid who makes Sphax textures.

Well hi there. :D

Posted

Hmm. It seems as though the TileEntity has already been destroyed by the time getDrops is called. Any ideas?

 

  On 5/1/2014 at 1:45 AM, TheSparkst3r said:

You'll need to use the ItemStack's NBTTagCompound.

 

In your Block's getDrops method you should get the TileEntity. TileYours being your TileEntity

 

TileYours tile = (TileYours)world.getTileEntity(x, y, z)

You should probably also perform a check on the tile to ensure it is instanceof TileYours

Then you need to get the value from the tile. You need to create the getPlayerName method in your tile entity class and insert it into a new stack's nbttag

	@Override
public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
	ArrayList<ItemStack> items = new ArrayList<ItemStack>();

	TileEntity t = world.getTileEntity(x, y, z);

	if (t instanceof TileYours) {
		TileYours tile = (TileYours)t;
		String name = tile.getPlayerName();

		ItemStack stack = new ItemStack(world.getBlock(x, y, z), 1, metadata);
		if (!stack.hasTagCompound()) {
			stack.setTagCompound(new NBTTagCompound());
		}
		stack.getTagCompound().setString("playerName", name);
		items.add(stack);
	}

	return items;

}

 

And in your onBlockPlaced you will need do the opposite and set the name in the tileentity

Posted

Hmm, I was afraid of that. TE uses a tool to dismantle the blocks safely by purposely calling the methods to break the block and saving the tile data in the correct order. You'll have to look around for a method in your block that calls before the tile is deleted so long as you have access to the world and coordinates and able to return the stack to drop.

I'm Sparkst3r, that kid who makes Sphax textures.

Well hi there. :D

Posted

Override the breakBlock() method and put your code in that.

if (user.hasKnowledgeOfJava) {

    if (user.question.hasCode) {

        return interpetHelpfulResponse(user.getQuestion());

    } else {

        return "Could you post your code please?";

    }

} else {

    return "Learn some freaking Java!";

}

Posted

Yeah, I was just going to post the same thing.  The TileEntity is removed in the block's breakBlock() method.  So you just need to Override that in your custom block where you save the data somehow before the tile entity is removed.

 

Here's the vanilla method:

 

  Reveal hidden contents

 

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

Yeah, that'd work. But you'll also need to make sure the normal drop is disabled or you'll have 2 items dropping.

You'll also need to create an entityitem in the breakBlock method and spawn that in the world manually for your drop.

I'm Sparkst3r, that kid who makes Sphax textures.

Well hi there. :D

Posted

Is there a good example to look at for spawning the entityItem?

 

  On 5/1/2014 at 5:04 AM, TheSparkst3r said:

Yeah, that'd work. But you'll also need to make sure the normal drop is disabled or you'll have 2 items dropping.

You'll also need to create an entityitem in the breakBlock method and spawn that in the world manually for your drop.

Posted

If you look at the BlockContainer class, inside the breakBlock method, there is a removeTileEntity method. My guess is, you could pop your NBT-adding code into there. Of course, there is always events, but if you don't have to use them, then don't.

Posted

I'll give you an alternative idea that assumes one bloke per player.

 

On the savenbt method in the tile, check for the owner to be online and save its nbt to the player.  Then you never need to mess with the rest.

Long time Bukkit & Forge Programmer

Happy to try and help

  • 7 months later...
Posted
  On 5/1/2014 at 1:45 AM, TheSparkst3r said:

You'll need to use the ItemStack's NBTTagCompound.

 

In your Block's getDrops method you should get the TileEntity. TileYours being your TileEntity

 

TileYours tile = (TileYours)world.getTileEntity(x, y, z)

You should probably also perform a check on the tile to ensure it is instanceof TileYours

Then you need to get the value from the tile. You need to create the getPlayerName method in your tile entity class and insert it into a new stack's nbttag

	@Override
public ArrayList<ItemStack> getDrops(World world, int x, int y, int z, int metadata, int fortune) {
	ArrayList<ItemStack> items = new ArrayList<ItemStack>();

	TileEntity t = world.getTileEntity(x, y, z);

	if (t instanceof TileYours) {
		TileYours tile = (TileYours)t;
		String name = tile.getPlayerName();

		ItemStack stack = new ItemStack(world.getBlock(x, y, z), 1, metadata);
		if (!stack.hasTagCompound()) {
			stack.setTagCompound(new NBTTagCompound());
		}
		stack.getTagCompound().setString("playerName", name);
		items.add(stack);
	}

	return items;

}

 

And in your onBlockPlaced you will need do the opposite and set the name in the tileentity

 

I have the part that you put in breakBlock(), but what do you put in onBlockPlaced? You said "the opposite" and I don't quite get what the code for that would be.

glubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglub.

Posted

It is pretty much exactly the same as what I currently have.

 

This is the code that I have in the PotentialBlock class in the breakBlock() method.

 

@Override
public void breakBlock(World world, int x, int y, int z, Block block, int p_149749_6_)
{
	TilePotBlock t = (TilePotBlock)world.getTileEntity(x, y, z);
	ArrayList<ItemStack> items = new ArrayList<ItemStack>();
	if (t instanceof TilePotBlock) {
		TilePotBlock tile = (TilePotBlock)t;

		ItemStack stack = new ItemStack(world.getBlock(x, y, z), 1);
		if (!stack.hasTagCompound()) {
			stack.setTagCompound(new NBTTagCompound());
		}
		stack.getTagCompound().setBoolean("potBlockR", tile.red);
		stack.getTagCompound().setBoolean("potBlockG", tile.green);
		stack.getTagCompound().setBoolean("potBlockB", tile.blue);
		stack.getTagCompound().setBoolean("potBlockIR", tile.ir);


		items.add(stack);
		world.spawnEntityInWorld(new EntityItem(world, x, y, z, items.get(0)));
		world.setBlock(x, y, z, Blocks.air);

	}


}

It is deleting the information when I'm placing it back down.

glubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglubglub.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The specific issue is that items in my inventory wont stack properly. For instance, if I punch a tree down to collect wood, the first block I collected goes to my hand. So when I punch the second block of wood to collect it, it drops, but instead of stacking with the piece of wood already in my hand, it goes to the second slot in my hotbar instead. Another example is that I'll get some dirt, and then when I'm placing it down later I'll accidentally place a block where I don't want it. When I harvest it again, it doesn't go back to the stack that it came from on my hotbar, where it should have gone, but rather into my inventory. That means that if my inventory is full, then the dirt wont be picked up even though there should be space available in the stack I'm holding. The forge version I'm using is 40.3.0, for java 1.18.2. I'll leave the mods I'm using here, and I'd appreciate it if anybody can point me in the right direction in regards to figuring out how to fix this. I forgot to mention that I think it only happens on my server but I&#39;m not entirely sure. PLEASE HELP ME! LIST OF THE MODS. aaa_particles Adorn AdvancementPlaques AI-Improvements AkashicTome alexsdelight alexsmobs AmbientSounds amwplushies Animalistic another_furniture AppleSkin Aquaculture aquamirae architectury artifacts Atlas-Lib AutoLeveling AutoRegLib auudio balm betterfpsdist biggerstacks biomancy BiomesOPlenty blockui blueprint Bookshelf born_in_chaos Botania braincell BrassAmberBattleTowers brutalbosses camera CasinoCraft cfm (MrCrayfish’s Furniture Mod) chat_heads citadel cloth-config Clumps CMDCam CNB cobweb collective comforts convenientcurioscontainer cookingforblockheads coroutil CosmeticArmorReworked CozyHome CrabbersDelight crashexploitfixer crashutilities Create CreativeCore creeperoverhaul cristellib crittersandcompanions Croptopia CroptopiaAdditions CullLessLeaves curios curiouslanterns curiouslights Curses' Naturals CustomNPCs CyclopsCore dannys_expansion decocraft Decoration Mod DecorationDelightRefurbished Decorative Blocks Disenchanting DistantHorizons doubledoors DramaticDoors drippyloadingscreen durabilitytooltip dynamic-fps dynamiclights DynamicTrees DynamicTreesBOP DynamicTreesPlus Easy Dungeons EasyAnvils EasyMagic easy_npc eatinganimation ecologics effective_fg elevatorid embeddium emotecraft enchantlimiter EnchantmentDescriptions EnderMail engineersdecor entityculling entity_model_features entity_texture_features epicfight EvilCraft exlinefurniture expandability explosiveenhancement factory-blocks fairylights fancymenu FancyVideo FarmersDelight fast-ip-ping FastSuite ferritecore finsandtails FixMySpawnR Forge Middle Ages fossil FpsReducer2 furnish GamingDeco geckolib goblintraders goldenfood goodall H.e.b habitat harvest-with-ease hexerei hole_filler huge-structure-blocks HunterIllager iammusicplayer Iceberg illuminations immersive_paintings incubation infinitybuttons inventoryhud InventoryProfilesNext invocore ItemBorders itemzoom Jade jei (Just Enough Items) JetAndEliasArmors journeymap JRFTL justzoom kiwiboi Kobolds konkrete kotlinforforge lazydfu LegendaryTooltips libIPN lightspeed lmft lodestone LongNbtKiller LuckPerms Lucky77 MagmaMonsters malum ManyIdeasCore ManyIdeasDoors marbledsarsenal marg mcw-furniture mcw-lights mcw-paths mcw-stairs mcw-trapdoors mcw-windows meetyourfight melody memoryleakfix Mimic minecraft-comes-alive MineTraps minibosses MmmMmmMmmMmm MOAdecor (ART, BATH, COOKERY, GARDEN, HOLIDAYS, LIGHTS, SCIENCE) MobCatcher modonomicon mods_optimizer morehitboxes mowziesmobs MutantMonsters mysticalworld naturalist NaturesAura neapolitan NekosEnchantedBooks neoncraft2 nerb nifty NightConfigFixes nightlights nocube's_villagers_sell_animals NoSeeNoTick notenoughanimations obscure_api oculus oresabovediamonds otyacraftengine Paraglider Patchouli physics-mod Pillagers Gun PizzaCraft placeableitems Placebo player-animation-lib pneumaticcraft-repressurized polymorph PrettyPipes Prism projectbrazier Psychadelic-Chemistry PuzzlesLib realmrpg_imps_and_demons RecipesLibrary reeves-furniture RegionsUnexplored restrictedportals revive-me Scary_Mobs_And_Bosses selene shetiphiancore ShoulderSurfing smoothboot
    • Hi everyone, I'm currently developing a Forge 1.21 mod for Minecraft and I want to display a custom HUD overlay for a minigame. My goal: When the game starts, all players should see an item/block icon (from the base game, not a custom texture) plus its name/text in the HUD – similar to how the bossbar overlay works. The HUD should appear centered above the hotbar (or at a similar prominent spot), and update dynamically (icon and name change as the target item changes). What I've tried: I looked at many online tutorials and several GitHub repos (e.g. SeasonHUD, MiniHUD), but most of them use NeoForge or Forge versions <1.20 that provide the IGuiOverlay API (e.g. implements IGuiOverlay, RegisterGuiOverlaysEvent). In Forge 1.21, it seems that neither IGuiOverlay nor RegisterGuiOverlaysEvent exist anymore – at least, I can't import them and they are missing from the docs and code completion. I tried using RenderLevelStageEvent as a workaround but it is probably not intended for custom HUDs. I am not using NeoForge, and switching the project to NeoForge is currently not an option for me. I tried to look at the original minecraft source code to see how elements like hearts, hotbar etc are drawn on the screen but I am too new to Minecraft modding to understand. What I'm looking for: What is the correct way to add a custom HUD element (icon + text) in Forge 1.21, given that the previous overlay API is missing? Is there a new recommended event, callback, or method in Forge 1.21 for custom HUD overlays, or is everyone just using a workaround? Is there a minimal open-source example repo for Forge 1.21 that demonstrates a working HUD overlay without relying on NeoForge or deprecated Forge APIs? My ideal solution: Centered HUD element with an in-game item/block icon (from the base game's assets, e.g. a diamond or any ItemStack / Item) and its name as text, with a transparent background rectangle. It should be visible to the players when the mini game is running. Easy to update the item (e.g. static variable or other method), so it can change dynamically during the game. Any help, code snippets, or up-to-date references would be really appreciated! If this is simply not possible right now in Forge 1.21, it would also help to know that for sure. Thank you very much in advance!
    • The simple answer is there is not an easy way. You would need to know how to program in Java, as well as at least some familiarity with how Forge works so you could port the differences. You would also need the sourcecode for the original mod, and permission from the author to modify it, if they did not use some sort of open source license. So it's not impossible, but it would take some effort, but doing so would open up a whole new world of possibilities for you!
    • Does it still crash if you remove holdmyitems? Looks like that mod doesn't work on a server as far as I can tell from the error.  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.