Problems adding new functional slots to custom furnace

[Rokuw]

Hey guys, this is my first post so please don't be harsh on me... if i commit any mistake, don't hesitate correcting me so that i improve my "posting abilities"  . Anyways, as the title says, i made a custom furnace by looking at the codes of the vanilla furnace and some mods's furnaces, and i got my normal furnace to work. However, when trying to add 1 more slot of each (input, fuel and output), they just do nothing. Yes, the "original" ones are working, but the additional ones are useless. I am ,in fact, able to place items in both input and fuel slots and not able to put items in the output. These aspects are working. I just want to know what do i have to do to have them working normally. Also, as I'm new to both modding and java, please be patient; and if possible, maybe even adding some examples.

 

The source code is on GitHub: https://github.com/pedromendes99/AmethystModSource/tree/master/src/main/java/com/rokuw/modding/furnaces/amethystfurnace

 

 

Thanks for your time and sorry if there are grammar errors here, english is not my native language 

[ShaneCraft]

Your tileentity and container classes are missing.

container for the inventory slots and tileentity for the actions.

[Rokuw]

Oops, sorry, i forgot to add them

All the classes should be there by now ^^

[MoxEmerald]

From ContainerAmethystOven.java

        this.addSlotToContainer(new Slot(par2TileEntityAmethystOven, 0, 56, 17));
        this.addSlotToContainer(new Slot(par2TileEntityAmethystOven, 1, 56, 53));
        this.addSlotToContainer(new SlotAmethystOven(par1InventoryPlayer.player, par2TileEntityAmethystOven, 2, 116, 35));
        this.addSlotToContainer(new Slot(par2TileEntityAmethystOven, 4, 26, 17));
        this.addSlotToContainer(new Slot(par2TileEntityAmethystOven, 4, 26, 53));
        this.addSlotToContainer(new SlotAmethystOven(par1InventoryPlayer.player, par2TileEntityAmethystOven, 5, 141, 35));

 

Add slots with ids 0, 1, 4 and 4 for the tileentity? And I don't know about this custom slot business but you also appear to have slot ids 2 and 5. 3 is jealous of 4 dude. Don't disrespect 3 like that.

[Rokuw]

Slots 0, 1 and 2 are the original, working ones. slots "4", 4 and 5 are the ones i added. And yes, i switched the first "4" id, it was supposed to be 3 (sorry about disrespecting you, '3' )... I changed '4' to '3' but they're still not working

[ShaneCraft]

You don't do anything with the other indexes of your tileentity's ItemStack array furnaceItemstacks.

What did you expect to happen?

Your tileentity only calls slot 0 through 2, you never used 3 through 5.

 

There is no error in your code, there just is no code for your other slots.

[Rokuw]

Okay, so i should set the furnace item stack array to 3, the original value, and the additional slots ids to their respective function, correct? (0 = input, 1 = fuel and 2 = outut, right?)

 

EDIT: i did change the ids, but as they were colliding (the originals with the addtionals) when i put an item in te furnace, obviously, the items duplicate aswell... I just want the additional slots to be "independent", like two furnaces in one block...

[ShaneCraft]

  On 5/20/2014 at 8:57 PM, Rokuw said:

Okay, so i should set the furnace item stack array to 3, the original value, and the additional slots ids to their respective function, correct? (0 = input, 1 = fuel and 2 = outut, right?)

 

EDIT: i did change the ids, but as they were colliding (the originals with the addtionals) when i put an item in te furnace, obviously, the items duplicate aswell... I just want the additional slots to be "independent", like two furnaces in one block...

 

But you're not calling anything beyond furnaceItemStacks[2];

4th slot = furnaceItemStack[3]

5th slot = furnaceItemStack[4]

6th slot = furnaceItemStack[5]

 

Nowhere in your code you're telling it to be that slot.

Heck, you're not even calling those itemstacks at all. So nothing is going to work.

If you want to have 2 furnaces in 1, you can just copy everything containing furnaceItemStack[0] (1st slot) and replace 1 with 3(4th slot) to what you've copied.

DONE!

[Rokuw]

I've changed some stuff here and now 1 fuel slot burns 2 input slots and returns the items in the 2 output slots...

 

 

Tile Entity Class:

 

  Reveal hidden contents

package com.rokuw.modding.furnaces.amethystfurnace;

import cpw.mods.fml.common.registry.GameRegistry;
import cpw.mods.fml.relauncher.Side;
import cpw.mods.fml.relauncher.SideOnly;
import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.Blocks;
import net.minecraft.init.Items;
import net.minecraft.inventory.ISidedInventory;
import net.minecraft.item.Item;
import net.minecraft.item.ItemBlock;
import net.minecraft.item.ItemHoe;
import net.minecraft.item.ItemStack;
import net.minecraft.item.ItemSword;
import net.minecraft.item.ItemTool;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.tileentity.TileEntity;

public class TileEntityAmethystOven extends TileEntity implements ISidedInventory
{
    private static final int[] slotsTop = new int[] {0};
    private static final int[] slotsBottom = new int[] {2, 1};
    private static final int[] slotsSides = new int[] {1};
    /**
     * The ItemStacks that hold the items currently being used in the furnace
     */
    private ItemStack[] furnaceItemStacks = new ItemStack[6];
    /** The number of ticks that the furnace will keep burning */
    public int furnaceBurnTime;
    /**
     * The number of ticks that a fresh copy of the currently-burning item would keep the furnace burning for
     */
    public int currentItemBurnTime;
    /** The number of ticks that the current item has been cooking for */
    public int furnaceCookTime;
    private String field_145958_o;
    private static final String __OBFID = "CL_00000357";

    /**
     * Returns the number of slots in the inventory.
     */
    public int getSizeInventory()
    {
        return this.furnaceItemStacks.length;
    }

    /**
     * Returns the stack in slot i
     */
    public ItemStack getStackInSlot(int par1)
    {
        return this.furnaceItemStacks[par1];
    }

    /**
     * Removes from an inventory slot (first arg) up to a specified number (second arg) of items and returns them in a
     * new stack.
     */
    public ItemStack decrStackSize(int par1, int par2)
    {
        if (this.furnaceItemStacks[par1] != null)
        {
            ItemStack itemstack;

            if (this.furnaceItemStacks[par1].stackSize <= par2)
            {
                itemstack = this.furnaceItemStacks[par1];
                this.furnaceItemStacks[par1] = null;
                return itemstack;
            }
            else
            {
                itemstack = this.furnaceItemStacks[par1].splitStack(par2);

                if (this.furnaceItemStacks[par1].stackSize == 0)
                {
                    this.furnaceItemStacks[par1] = null;
                }

                return itemstack;
            }
        }
        else
        {
            return null;
        }
    }

    /**
     * When some containers are closed they call this on each slot, then drop whatever it returns as an EntityItem -
     * like when you close a workbench GUI.
     */
    public ItemStack getStackInSlotOnClosing(int par1)
    {
        if (this.furnaceItemStacks[par1] != null)
        {
            ItemStack itemstack = this.furnaceItemStacks[par1];
            this.furnaceItemStacks[par1] = null;
            return itemstack;
        }
        else
        {
            return null;
        }
    }

    /**
     * Sets the given item stack to the specified slot in the inventory (can be crafting or armor sections).
     */
    public void setInventorySlotContents(int par1, ItemStack par2ItemStack)
    {
        this.furnaceItemStacks[par1] = par2ItemStack;

        if (par2ItemStack != null && par2ItemStack.stackSize > this.getInventoryStackLimit())
        {
            par2ItemStack.stackSize = this.getInventoryStackLimit();
        }
    }

    /**
     * Returns the name of the inventory
     */
    public String getInventoryName()
    {
        return "Amethyst Furnace";
    }

    /**
     * Returns if the inventory is named
     */
    public boolean hasCustomInventoryName()
    {
        return true;
    }

    public void func_145951_a(String p_145951_1_)
    {
        this.field_145958_o = p_145951_1_;
    }

    public void readFromNBT(NBTTagCompound p_145839_1_)
    {
        super.readFromNBT(p_145839_1_);
        NBTTagList nbttaglist = p_145839_1_.getTagList("Items", 10);
        this.furnaceItemStacks = new ItemStack[this.getSizeInventory()];

        for (int i = 0; i < nbttaglist.tagCount(); ++i)
        {
            NBTTagCompound nbttagcompound1 = nbttaglist.getCompoundTagAt(i);
            byte b0 = nbttagcompound1.getByte("Slot");

            if (b0 >= 0 && b0 < this.furnaceItemStacks.length)
            {
                this.furnaceItemStacks[b0] = ItemStack.loadItemStackFromNBT(nbttagcompound1);
            }
        }

        this.furnaceBurnTime = p_145839_1_.getShort("BurnTime");
        this.furnaceCookTime = p_145839_1_.getShort("CookTime");
        this.currentItemBurnTime = getItemBurnTime(this.furnaceItemStacks[1]);

        if (p_145839_1_.hasKey("CustomName", )
        {
            this.field_145958_o = p_145839_1_.getString("CustomName");
        }
    }

    public void writeToNBT(NBTTagCompound p_145841_1_)
    {
        super.writeToNBT(p_145841_1_);
        p_145841_1_.setShort("BurnTime", (short)this.furnaceBurnTime);
        p_145841_1_.setShort("CookTime", (short)this.furnaceCookTime);
        NBTTagList nbttaglist = new NBTTagList();

        for (int i = 0; i < this.furnaceItemStacks.length; ++i)
        {
            if (this.furnaceItemStacks[i] != null)
            {
                NBTTagCompound nbttagcompound1 = new NBTTagCompound();
                nbttagcompound1.setByte("Slot", (byte)i);
                this.furnaceItemStacks[i].writeToNBT(nbttagcompound1);
                nbttaglist.appendTag(nbttagcompound1);
            }
        }

        p_145841_1_.setTag("Items", nbttaglist);

        if (this.hasCustomInventoryName())
        {
            p_145841_1_.setString("CustomName", this.field_145958_o);
        }
    }

    /**
     * Returns the maximum stack size for a inventory slot.
     */
    public int getInventoryStackLimit()
    {
        return 128;
    }

    /**
     * Returns an integer between 0 and the passed value representing how close the current item is to being completely
     * cooked
     */
    @SideOnly(Side.CLIENT)
    public int getCookProgressScaled(int p_145953_1_)
    {
        return this.furnaceCookTime * p_145953_1_ / 175;
    }

    /**
     * Returns an integer between 0 and the passed value representing how much burn time is left on the current fuel
     * item, where 0 means that the item is exhausted and the passed value means that the item is fresh
     */
    @SideOnly(Side.CLIENT)
    public int getBurnTimeRemainingScaled(int p_145955_1_)
    {
        if (this.currentItemBurnTime == 0)
        {
            this.currentItemBurnTime = 175;
        }

        return this.furnaceBurnTime * p_145955_1_ / this.currentItemBurnTime;
    }

    /**
     * Furnace isBurning
     */
    public boolean isBurning()
    {
        return this.furnaceBurnTime > 0;
    }

    public void updateEntity()
    {
        boolean flag = this.furnaceBurnTime > 0;
        boolean flag1 = false;

        if (this.furnaceBurnTime > 0)
        {
            --this.furnaceBurnTime;
        }

        if (!this.worldObj.isRemote)
        {
            if (this.furnaceBurnTime == 0 && this.canSmelt())
            {
                this.currentItemBurnTime = this.furnaceBurnTime = getItemBurnTime(this.furnaceItemStacks[1]);

                if (this.furnaceBurnTime > 0)
                {
                    flag1 = true;

                    if (this.furnaceItemStacks[1] != null)
                    {
                        --this.furnaceItemStacks[1].stackSize;

                        if (this.furnaceItemStacks[1].stackSize == 0)
                        {
                            this.furnaceItemStacks[1] = furnaceItemStacks[1].getItem().getContainerItem(furnaceItemStacks[1]);
                        }
                    }
                }
            }

            if (this.isBurning() && this.canSmelt())
            {
                ++this.furnaceCookTime;

                if (this.furnaceCookTime == 175)
                {
                    this.furnaceCookTime = 0;
                    this.smeltItem();
                    flag1 = true;
                }
            }
            else
            {
                this.furnaceCookTime = 0;
            }

            if (flag != this.furnaceBurnTime > 0)
            {
                flag1 = true;
                AmethystOven.updateFurnaceBlockState(this.furnaceBurnTime > 0, this.worldObj, this.xCoord, this.yCoord, this.zCoord);
            }
        }

        if (flag1)
        {
            this.markDirty();
        }
    }

    /**
     * Returns true if the furnace can smelt an item, i.e. has a source item, destination stack isn't full, etc.
     */
    private boolean canSmelt()
    {
        if (this.furnaceItemStacks[0] == null || this.furnaceItemStacks[3] == null)
        {
            return false;
        }
        else
        {
            ItemStack itemstack = AmethystOvenRecipes.smelting().getSmeltingResult(this.furnaceItemStacks[0]);
            if (itemstack == null) return false;
            if (this.furnaceItemStacks[2] == null || this.furnaceItemStacks[5] == null) return true;
            if (!this.furnaceItemStacks[2].isItemEqual(itemstack) || !this.furnaceItemStacks[5].isItemEqual(itemstack)) return false;
            int result = furnaceItemStacks[2].stackSize + itemstack.stackSize;
            return result <= getInventoryStackLimit() && result <= this.furnaceItemStacks[2].getMaxStackSize() && result <= this.furnaceItemStacks[5].getMaxStackSize(); //Forge BugFix: Make it respect stack sizes properly.
        }
    }

    /**
     * Turn one item from the furnace source stack into the appropriate smelted item in the furnace result stack
     */
    public void smeltItem()
    {
        if (this.canSmelt())
        {
            ItemStack itemstack = AmethystOvenRecipes.smelting().getSmeltingResult(this.furnaceItemStacks[0]);

            if (this.furnaceItemStacks[2] == null || this.furnaceItemStacks[5] == null)
            {
                this.furnaceItemStacks[2] = itemstack.copy();
                this.furnaceItemStacks[5] = itemstack.copy();
            }
            else if (this.furnaceItemStacks[2].getItem() == itemstack.getItem() || this.furnaceItemStacks[5].getItem() == itemstack.getItem())
            {
                this.furnaceItemStacks[2].stackSize += itemstack.stackSize;
                this.furnaceItemStacks[5].stackSize += itemstack.stackSize;// Forge BugFix: Results may have multiple items
            }

            --this.furnaceItemStacks[0].stackSize;
            --this.furnaceItemStacks[3].stackSize;

            if (this.furnaceItemStacks[0].stackSize <= 0 || this.furnaceItemStacks[3].stackSize <= 0)
            {
                this.furnaceItemStacks[0] = null;
                this.furnaceItemStacks[3] = null;
            }
        }
    }

    /**
     * Returns the number of ticks that the supplied fuel item will keep the furnace burning, or 0 if the item isn't
     * fuel
     */
    public static int getItemBurnTime(ItemStack p_145952_0_)
    {
        if (p_145952_0_ == null)
        {
            return 0;
        }
        else
        {
            Item item = p_145952_0_.getItem();

            if (item instanceof ItemBlock && Block.getBlockFromItem(item) != Blocks.air)
            {
                Block block = Block.getBlockFromItem(item);

                if (block == Blocks.wooden_slab)
                {
                    return 165;
                }

                if (block.getMaterial() == Material.wood)
                {
                    return 315;
                }

                if (block == Blocks.coal_block)
                {
                    return 16015;
                }
            }

            if (item instanceof ItemTool && ((ItemTool)item).getToolMaterialName().equals("WOOD")) return 215;
            if (item instanceof ItemSword && ((ItemSword)item).getToolMaterialName().equals("WOOD")) return 215;
            if (item instanceof ItemHoe && ((ItemHoe)item).getToolMaterialName().equals("WOOD")) return 215;
            if (item == Items.stick) return 115;
            if (item == Items.coal) return 1615;
            if (item == Items.lava_bucket) return 20015;
            if (item == Item.getItemFromBlock(Blocks.sapling)) return 115;
            if (item == Items.blaze_rod) return 2415;
            return GameRegistry.getFuelValue(p_145952_0_);
        }
    }

    public static boolean isItemFuel(ItemStack p_145954_0_)
    {
        /**
         * Returns the number of ticks that the supplied fuel item will keep the furnace burning, or 0 if the item isn't
         * fuel
         */
        return getItemBurnTime(p_145954_0_) > 0;
    }

    /**
     * Do not make give this method the name canInteractWith because it clashes with Container
     */
    public boolean isUseableByPlayer(EntityPlayer par1EntityPlayer)
    {
        return this.worldObj.getTileEntity(this.xCoord, this.yCoord, this.zCoord) != this ? false : par1EntityPlayer.getDistanceSq((double)this.xCoord + 0.5D, (double)this.yCoord + 0.5D, (double)this.zCoord + 0.5D) <= 64.0D;
    }

    public void openInventory() {}

    public void closeInventory() {}

    /**
     * Returns true if automation is allowed to insert the given stack (ignoring stack size) into the given slot.
     */
    public boolean isItemValidForSlot(int par1, ItemStack par2ItemStack)
    {
        return par1 == 2 ? false : (par1 == 1 ? isItemFuel(par2ItemStack) : true);
    }

    /**
     * Returns an array containing the indices of the slots that can be accessed by automation on the given side of this
     * block.
     */
    public int[] getAccessibleSlotsFromSide(int par1)
    {
        return par1 == 0 ? slotsBottom : (par1 == 1 ? slotsTop : slotsSides);
    }

    /**
     * Returns true if automation can insert the given item in the given slot from the given side. Args: Slot, item,
     * side
     */
    public boolean canInsertItem(int par1, ItemStack par2ItemStack, int par3)
    {
        return this.isItemValidForSlot(par1, par2ItemStack);
    }

    /**
     * Returns true if automation can extract the given item in the given slot from the given side. Args: Slot, item,
     * side
     */
    public boolean canExtractItem(int par1, ItemStack par2ItemStack, int par3)
    {
        return par3 != 0 || par1 != 1 || par2ItemStack.getItem() == Items.bucket;
    }
}

 

[ShaneCraft]

I suggest you to learn more java first.

You need a separate timer for your other 3 slots...

[Rokuw]

Yeah well, thanks i suppose...

[MoxEmerald]

Let's be perfectly clear. You have essentially copy-pasted a series of methods from the furnace class which contain algorithms that make slots with ids 0, 1 and 2 work. Now you need to add additional algorithms which will be almost identical to the originals, except that they will use slots 3, 4 and 5. You already have the code in front of you so the only other things you need are 1) understand the code and 2) step by step logic.

 

Learning how to code is time consuming and we can't do it for you even if we wanted to. As someone who only started with java a year ago I can't recommend that you start learning java through Minecraft.

[AskHow1248]

watch this, it might help:

[Rokuw]

Okay, thank you guys, i think that i'll stick with what i know of modding and try not to compliccate things...

AskHow, as for the video, i really appreciate that you're trying to help me, but as i sad, i think i'll just stay with basic code, simply because i don't know java at all (thats because i'm 14 years old...) So yaeh, thats pretty much it, and again, Thanks!